From dd0c1ac5b2d5f3e34628b5380bebb2e96dc69e46 Mon Sep 17 00:00:00 2001 From: anatoly yakovenko Date: Tue, 17 Jul 2018 08:20:35 -0700 Subject: [PATCH] Error counters for streamer (#658) * error counters for streamer * more counters --- src/crdt.rs | 4 +++- src/streamer.rs | 15 ++++++++++++--- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/crdt.rs b/src/crdt.rs index 6e49449db0..a0ad00fe81 100644 --- a/src/crdt.rs +++ b/src/crdt.rs @@ -537,6 +537,7 @@ impl Crdt { ) -> Result<()> { if broadcast_table.is_empty() { warn!("{:x}:not enough peers in crdt table", me.debug_id()); + inc_new_counter!("crdt-broadcast-not_enough_peers_error", 1, 1); Err(CrdtError::TooSmall)?; } trace!("broadcast nodes {}", broadcast_table.len()); @@ -643,7 +644,8 @@ impl Crdt { .collect(); for e in errs { if let Err(e) = &e { - error!("broadcast result {:?}", e); + inc_new_counter!("crdt-retransmit-send_to_error", 1, 1); + error!("retransmit result {:?}", e); } e?; } diff --git a/src/streamer.rs b/src/streamer.rs index e30f2ae400..033c70df7a 100644 --- a/src/streamer.rs +++ b/src/streamer.rs @@ -583,7 +583,10 @@ pub fn window( match e { Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), - _ => error!("window error: {:?}", e), + _ => { + inc_new_counter!("streamer-window-error", 1, 1); + error!("window error: {:?}", e); + } } } let _ = repair_window( @@ -729,7 +732,10 @@ pub fn broadcaster( Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), Error::CrdtError(CrdtError::TooSmall) => (), // TODO: Why are the unit-tests throwing hundreds of these? - _ => error!("broadcaster error: {:?}", e), + _ => { + inc_new_counter!("streamer-broadcaster-error", 1, 1); + error!("broadcaster error: {:?}", e); + } } } } @@ -782,7 +788,10 @@ pub fn retransmitter( match e { Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), - _ => error!("retransmitter error: {:?}", e), + _ => { + inc_new_counter!("streamer-retransmit-error", 1, 1); + error!("retransmitter error: {:?}", e); + } } } }