Revert "Revert "simulateTransaction now returns the correct error code if accounts are provided as input (#21715)""

This reverts commit 6deb0a9f5d.
This commit is contained in:
Tyera Eulberg
2021-12-16 14:27:42 -07:00
committed by Tyera Eulberg
parent 93a8fd6a2b
commit df40ede6ea

View File

@ -3223,38 +3223,37 @@ pub mod rpc_full {
return Err(Error::invalid_params("base58 encoding not supported")); return Err(Error::invalid_params("base58 encoding not supported"));
} }
if config_accounts.addresses.len() > post_simulation_accounts.len() { let number_of_accounts = transaction.message.account_keys.len();
if config_accounts.addresses.len() > number_of_accounts {
return Err(Error::invalid_params(format!( return Err(Error::invalid_params(format!(
"Too many accounts provided; max {}", "Too many accounts provided; max {}",
post_simulation_accounts.len() number_of_accounts
))); )));
} }
let mut accounts = vec![]; if result.is_err() {
for address_str in config_accounts.addresses { Some(vec![None; config_accounts.addresses.len()])
let address = verify_pubkey(&address_str)?; } else {
accounts.push(if result.is_err() { let mut accounts = vec![];
None for address_str in config_accounts.addresses {
} else { let address = verify_pubkey(&address_str)?;
(0..transaction.message.account_keys.len()) accounts.push(
.position(|i| { post_simulation_accounts
post_simulation_accounts .iter()
.get(i) .find(|(key, _account)| key == &address)
.map(|(key, _account)| *key == address) .map(|(pubkey, account)| {
.unwrap_or(false) UiAccount::encode(
}) pubkey,
.map(|i| { account,
UiAccount::encode( accounts_encoding,
&address, None,
&post_simulation_accounts[i].1, None,
accounts_encoding, )
None, }),
None, );
) }
}) Some(accounts)
});
} }
Some(accounts)
} else { } else {
None None
}; };