gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove hostname() from calls to metrics as it's expensive operation (#1557)

Browse Source
This commit is contained in:
Pankaj Garg 2018-10-20 06:38:20 -07:00 committed by GitHub
parent f8516b677a
commit df9ccce5b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/replicate_stage.rs
View File

@ -22,7 +22,6 @@ use std::thread::{self, Builder, JoinHandle};
use std::time::Duration; use std::time::Duration;
use std::time::Instant; use std::time::Instant;
use streamer::{responder, BlobSender}; use streamer::{responder, BlobSender};
use sys_info::hostname;
use vote_stage::send_validator_vote; use vote_stage::send_validator_vote;
#[derive(Debug, PartialEq, Eq, Clone)] #[derive(Debug, PartialEq, Eq, Clone)]
@ -75,10 +74,7 @@ impl ReplicateStage {
metrics::submit( metrics::submit(
influxdb::Point::new("replicate-stage") influxdb::Point::new("replicate-stage")
.add_field( .add_field("count", influxdb::Value::Integer(entries.len() as i64))
"host",
influxdb::Value::String(hostname().unwrap_or_else(|_| "?".to_string())),
).add_field("count", influxdb::Value::Integer(entries.len() as i64))
.to_owned(), .to_owned(),
); );

6
src/retransmit_stage.rs
View File

@ -17,7 +17,6 @@ use std::sync::{Arc, RwLock};
use std::thread::{self, Builder, JoinHandle}; use std::thread::{self, Builder, JoinHandle};
use std::time::Duration; use std::time::Duration;
use streamer::BlobReceiver; use streamer::BlobReceiver;
use sys_info::hostname;
use window::SharedWindow; use window::SharedWindow;
use window_service::window_service; use window_service::window_service;
@ -34,10 +33,7 @@ fn retransmit(
metrics::submit( metrics::submit(
influxdb::Point::new("retransmit-stage") influxdb::Point::new("retransmit-stage")
.add_field( .add_field("count", influxdb::Value::Integer(dq.len() as i64))
"host",
influxdb::Value::String(hostname().unwrap_or_else(|_| "?".to_string())),
).add_field("count", influxdb::Value::Integer(dq.len() as i64))
.to_owned(), .to_owned(),
); );

14
src/window_service.rs
View File

@ -18,7 +18,6 @@ use std::sync::{Arc, RwLock};
use std::thread::{Builder, JoinHandle}; use std::thread::{Builder, JoinHandle};
use std::time::{Duration, Instant}; use std::time::{Duration, Instant};
use streamer::{BlobReceiver, BlobSender}; use streamer::{BlobReceiver, BlobSender};
use sys_info::hostname;
use timing::duration_as_ms; use timing::duration_as_ms;
use window::{blob_idx_in_window, SharedWindow, WindowUtil}; use window::{blob_idx_in_window, SharedWindow, WindowUtil};
@ -122,9 +121,6 @@ fn retransmit_all_leader_blocks(
metrics::submit( metrics::submit(
influxdb::Point::new("retransmit-queue") influxdb::Point::new("retransmit-queue")
.add_field( .add_field(
"host",
influxdb::Value::String(hostname().unwrap_or_else(|_| "?".to_string())),
).add_field(
"count", "count",
influxdb::Value::Integer(retransmit_queue.len() as i64), influxdb::Value::Integer(retransmit_queue.len() as i64),
).to_owned(), ).to_owned(),
@ -177,10 +173,7 @@ fn recv_window(
metrics::submit( metrics::submit(
influxdb::Point::new("recv-window") influxdb::Point::new("recv-window")
.add_field( .add_field("count", influxdb::Value::Integer(dq.len() as i64))
"host",
influxdb::Value::String(hostname().unwrap_or_else(|_| "?".to_string())),
).add_field("count", influxdb::Value::Integer(dq.len() as i64))
.to_owned(), .to_owned(),
); );
@ -314,10 +307,7 @@ pub fn window_service(
metrics::submit( metrics::submit(
influxdb::Point::new("window-stage") influxdb::Point::new("window-stage")
.add_field( .add_field("consumed", influxdb::Value::Integer(consumed as i64))
"host",
influxdb::Value::String(hostname().unwrap_or_else(|_| "?".to_string())),
).add_field("consumed", influxdb::Value::Integer(consumed as i64))
.to_owned(), .to_owned(),
); );