gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove activated feature that checks tx signature len (#21747)

Browse Source
This commit is contained in:
Justin Starry
2021-12-14 09:23:05 -05:00
committed by GitHub
parent 746869fdac
commit e5476913fe
5 changed files with 13 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
runtime/src/bank.rs
View File

@@ -5264,10 +5264,6 @@ impl Bank {
})
}?;
if self.verify_tx_signatures_len_enabled() && !sanitized_tx.verify_signatures_len() {
return Err(TransactionError::SanitizeFailure);
}
if verification_mode == TransactionVerificationMode::HashAndVerifyPrecompiles
|| verification_mode == TransactionVerificationMode::FullVerification
{
@@ -5752,11 +5748,6 @@ impl Bank {
.is_active(&feature_set::no_overflow_rent_distribution::id())
}
pub fn verify_tx_signatures_len_enabled(&self) -> bool {
self.feature_set
.is_active(&feature_set::verify_tx_signatures_len::id())
}
pub fn versioned_tx_message_enabled(&self) -> bool {
self.feature_set
.is_active(&feature_set::versioned_tx_message_enabled::id())
@@ -14994,12 +14985,14 @@ pub(crate) mod tests {
Some(TransactionError::SanitizeFailure),
);
}
// Too many signatures: Success without feature switch
// Too many signatures: Sanitization failure
{
let tx = make_transaction(TestCase::AddSignature);
assert!(bank
.verify_transaction(tx.into(), TransactionVerificationMode::FullVerification)
.is_ok());
assert_eq!(
bank.verify_transaction(tx.into(), TransactionVerificationMode::FullVerification)
.err(),
Some(TransactionError::SanitizeFailure),
);
}
}