Cli: transfer ALL; check spend+fee in client (#10012)

* lamports->SOL in user-facing error msg

* Check for sufficient balance for spend and fee

* Add ALL option to solana transfer

* Rework TransferAmount to check for sign_only in parse

* Refactor TransferAmount & fee-check handling to be more general

* Add addl checks mechanism

* Move checks out of cli.rs

* Rename to SpendAmount to be more general & move

* Impl ALL/spend helpers for create-nonce-account

* Impl spend helpers for create-vote-account

* Impl ALL/spend helpers for create-stake-account

* Impl spend helpers for ping

* Impl ALL/spend helpers for pay

* Impl spend helpers for validator-info

* Remove unused fns

* Remove retry_get_balance

* Add a couple unit tests

* Rework send_util fn signatures

client/src/mock_rpc_client_request.rs

@@ -117,7 +117,7 @@ impl GenericRpcClientRequest for MockRpcClientRequest {
                 };
                 Value::String(signature)
             }
-            RpcRequest::GetMinimumBalanceForRentExemption => Value::Number(Number::from(1234)),
+            RpcRequest::GetMinimumBalanceForRentExemption => Value::Number(Number::from(20)),
             _ => Value::Null,
         };
         Ok(val)

client/src/rpc_client.rs

@@ -499,24 +499,6 @@ impl RpcClient {
         Ok(())
     }
 
-    pub fn retry_get_balance(
-        &self,
-        pubkey: &Pubkey,
-        retries: usize,
-    ) -> Result<Option<u64>, Box<dyn error::Error>> {
-        let request = RpcRequest::GetBalance;
-        let balance_json = self
-            .client
-            .send(request, json!([pubkey.to_string()]), retries)
-            .map_err(|err| err.into_with_request(request))?;
-
-        Ok(Some(
-            serde_json::from_value::<Response<u64>>(balance_json)
-                .map_err(|err| ClientError::new_with_request(err.into(), request))?
-                .value,
-        ))
-    }
-
     pub fn get_account(&self, pubkey: &Pubkey) -> ClientResult<Account> {
         self.get_account_with_commitment(pubkey, CommitmentConfig::default())?
             .value