gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cap split stake at source stake when splitting entire balance (#13754)

Browse Source
This commit is contained in:
Tyera Eulberg
2020-11-23 10:11:10 -07:00
committed by GitHub
parent 879646dee9
commit f0f99ffc7e
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
programs/stake/src/stake_state.rs
View File

@ -978,13 +978,20 @@ impl<'a> StakeAccount for KeyedAccount<'a> {
// split account. Since split accounts retain the state of their source // split account. Since split accounts retain the state of their source
// account, this prevents any magic activation of stake by prefunding the // account, this prevents any magic activation of stake by prefunding the
// split account. // split account.
( // The new split stake also needs to ignore any positive delta between the
lamports.saturating_sub(meta.rent_exempt_reserve), // original rent_exempt_reserve and the split_rent_exempt_reserve, in order
// to prevent magic activation of stake by splitting between accounts of
// different sizes.
let remaining_stake_delta =
lamports.saturating_sub(meta.rent_exempt_reserve);
let split_stake_amount = std::cmp::min(
lamports - split_rent_exempt_reserve, lamports - split_rent_exempt_reserve,
) remaining_stake_delta,
);
(remaining_stake_delta, split_stake_amount)
} else { } else {
// Otherwise, the new split stake should reflect the entire split // Otherwise, the new split stake should reflect the entire split
// requested, less any lamports needed to cover the rent-exempt reserve // requested, less any lamports needed to cover the split_rent_exempt_reserve
( (
lamports, lamports,
lamports - split_rent_exempt_reserve.saturating_sub(split.lamports()?), lamports - split_rent_exempt_reserve.saturating_sub(split.lamports()?),
@ -4365,7 +4372,9 @@ mod tests {
assert_eq!(Ok(*state), stake_keyed_account.state()); assert_eq!(Ok(*state), stake_keyed_account.state());
} }
StakeState::Stake(meta, stake) => { StakeState::Stake(meta, stake) => {
let expected_stake = stake_lamports - expected_rent_exempt_reserve; // Expected stake should reflect original stake amount so that extra lamports
// from the rent_exempt_reserve inequality do not magically activate
let expected_stake = stake_lamports - rent_exempt_reserve;
assert_eq!( assert_eq!(
Ok(StakeState::Stake( Ok(StakeState::Stake(
@ -4382,7 +4391,9 @@ mod tests {
); );
assert_eq!( assert_eq!(
split_stake_keyed_account.account.borrow().lamports, split_stake_keyed_account.account.borrow().lamports,
expected_stake + expected_rent_exempt_reserve expected_stake
+ expected_rent_exempt_reserve
+ (rent_exempt_reserve - expected_rent_exempt_reserve)
); );
assert_eq!( assert_eq!(
Ok(StakeState::Stake( Ok(StakeState::Stake(