compute_bank_stats needs to return newly computed ForkStats (#8608)

* Fix broken confirmation, add test

programs/vote/src/lib.rs

@@ -1,6 +1,7 @@
 pub mod authorized_voters;
 pub mod vote_instruction;
 pub mod vote_state;
+pub mod vote_transaction;
 
 #[macro_use]
 extern crate solana_metrics;

programs/vote/src/vote_transaction.rs

@@ -0,0 +1,30 @@
+use solana_sdk::{
+    clock::Slot,
+    hash::Hash,
+    signature::{Keypair, Signer},
+    transaction::Transaction,
+};
+
+use crate::{vote_instruction, vote_state::Vote};
+
+pub fn new_vote_transaction(
+    slots: Vec<Slot>,
+    bank_hash: Hash,
+    blockhash: Hash,
+    node_keypair: &Keypair,
+    vote_keypair: &Keypair,
+    authorized_voter_keypair: &Keypair,
+) -> Transaction {
+    let votes = Vote::new(slots, bank_hash);
+    let vote_ix = vote_instruction::vote(
+        &vote_keypair.pubkey(),
+        &authorized_voter_keypair.pubkey(),
+        votes,
+    );
+
+    let mut vote_tx = Transaction::new_with_payer(vec![vote_ix], Some(&node_keypair.pubkey()));
+
+    vote_tx.partial_sign(&[node_keypair], blockhash);
+    vote_tx.partial_sign(&[authorized_voter_keypair], blockhash);
+    vote_tx
+}