fix: correctly count duplicate signing keys

2019-05-08 11:00:05 -07:00
parent 48f0bcc2bf
commit f7a02e54df
2 changed files with 25 additions and 3 deletions
--- a/web3.js/src/transaction.js
+++ b/web3.js/src/transaction.js
@@ -163,10 +163,10 @@ export class Transaction {

      instruction.keys.forEach(keySignerPair => {
        const keyStr = keySignerPair.pubkey.toString();
-        if (keySignerPair.isSigner) {
-          numRequiredSignatures += 1;
-        }
        if (!keys.includes(keyStr)) {
+          if (keySignerPair.isSigner) {
+            numRequiredSignatures += 1;
+          }
          keys.push(keyStr);
        }
      });