Remove some TODOs (#6488)
* Remove stale TODOs * Ban TODO markers from markdown * Scrub all TODOs from ci/ and book/
This commit is contained in:
@@ -377,9 +377,9 @@ EOF
|
||||
)
|
||||
|
||||
if [[ $airdropsEnabled != true ]]; then
|
||||
echo "TODO: archivers not supported without airdrops"
|
||||
# TODO: need to provide the `--identity` argument to an existing system
|
||||
# account with lamports in it
|
||||
# If this ever becomes a problem, we need to provide the `--identity`
|
||||
# argument to an existing system account with lamports in it
|
||||
echo "Error: archivers not supported without airdrops"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
|
@@ -66,7 +66,6 @@ local|tar|skip)
|
||||
solana_cli=solana
|
||||
solana_gossip=solana-gossip
|
||||
solana_install=solana-install
|
||||
solana_keygen=solana-keygen
|
||||
;;
|
||||
*)
|
||||
echo "Unknown deployment method: $deployMethod"
|
||||
@@ -85,11 +84,8 @@ fi
|
||||
|
||||
echo "+++ $sanityTargetIp: validators"
|
||||
(
|
||||
# Ensure solana-cli has a keypair even though it doesn't really need one...
|
||||
# TODO: Remove when https://github.com/solana-labs/solana/issues/6375 is fixed
|
||||
$solana_keygen new --force -o temp-id.json
|
||||
set -x
|
||||
$solana_cli --keypair temp-id.json --url http://"$sanityTargetIp":8899 show-validators
|
||||
$solana_cli --url http://"$sanityTargetIp":8899 show-validators
|
||||
)
|
||||
|
||||
echo "+++ $sanityTargetIp: node count ($numSanityNodes expected)"
|
||||
|
@@ -126,7 +126,7 @@ cloud_Initialize() {
|
||||
declare networkName="$1"
|
||||
# ec2-provider.sh creates firewall rules programmatically, should do the same
|
||||
# here.
|
||||
echo "TODO: create $networkName firewall rules programmatically instead of assuming the 'testnet' tag exists"
|
||||
echo "Note: one day create $networkName firewall rules programmatically instead of assuming the 'testnet' tag exists"
|
||||
}
|
||||
|
||||
#
|
||||
|
@@ -3,8 +3,8 @@ set -ex
|
||||
#
|
||||
# Prevent background upgrades that block |apt-get|
|
||||
#
|
||||
# TODO: This approach is pretty uncompromising. An alternative solution that
|
||||
# doesn't involve deleting system files would be welcome.
|
||||
# This approach is pretty uncompromising. An alternative solution that doesn't
|
||||
# involve deleting system files would be welcome.
|
||||
|
||||
[[ $(uname) = Linux ]] || exit 1
|
||||
[[ $USER = root ]] || exit 1
|
||||
|
@@ -122,7 +122,7 @@ cloud_Initialize() {
|
||||
declare networkName="$1"
|
||||
# ec2-provider.sh creates firewall rules programmatically, should do the same
|
||||
# here.
|
||||
echo "TODO: create $networkName firewall rules programmatically instead of assuming the 'testnet' tag exists"
|
||||
echo "Note: one day create $networkName firewall rules programmatically instead of assuming the 'testnet' tag exists"
|
||||
}
|
||||
|
||||
#
|
||||
@@ -170,8 +170,8 @@ cloud_CreateInstances() {
|
||||
if $enableGpu; then
|
||||
# Custom Ubuntu 18.04 LTS image with CUDA 9.2 and CUDA 10.0 installed
|
||||
#
|
||||
# TODO: Unfortunately this image is not public. When this becomes an issue,
|
||||
# use the stock Ubuntu 18.04 image and programmatically install CUDA after the
|
||||
# Unfortunately this image is not public. When this becomes an issue, use
|
||||
# the stock Ubuntu 18.04 image and programmatically install CUDA after the
|
||||
# instance boots
|
||||
#
|
||||
imageName="ubuntu-1804-bionic-v20181029-with-cuda-10-and-cuda-9-2"
|
||||
|
Reference in New Issue
Block a user