Justin Starry
|
579065443a
|
v1.6: Use blake3 message hash in status cache (#16507)
|
2021-04-13 16:57:20 +08:00 |
|
mergify[bot]
|
b8198f8cc5
|
removes OrderedIterator and transaction batch iteration order (#16153) (#16285)
In TransactionBatch,
https://github.com/solana-labs/solana/blob/e50f59844/runtime/src/transaction_batch.rs#L4-L11
lock_results[i] is aligned with transactions[iteration_order[i]]:
https://github.com/solana-labs/solana/blob/e50f59844/runtime/src/bank.rs#L2414-L2424
https://github.com/solana-labs/solana/blob/e50f59844/runtime/src/accounts.rs#L788-L817
However load_and_execute_transactions is iterating over
lock_results[iteration_order[i]]
https://github.com/solana-labs/solana/blob/e50f59844/runtime/src/bank.rs#L2878-L2889
and then returning i as for the index of the retryable transaction.
If iteratorion_order is [1, 2, 0], and i is 0, then:
lock_results[iteration_order[i]] = lock_results[1]
which corresponds to
transactions[iteration_order[1]] = transactions[2]
so neither i = 0, nor iteration_order[i] = 1 gives the correct index for the
corresponding transaction (which is 2).
This commit removes OrderedIterator and transaction batch iteration order
entirely. There is only one place in blockstore processor which the
iteration order is not ordinal:
https://github.com/solana-labs/solana/blob/e50f59844/ledger/src/blockstore_processor.rs#L269-L271
It seems like, instead of using an iteration order, that can shuffle entry
transactions in-place.
(cherry picked from commit 3f63ed9a72)
Co-authored-by: behzad nouri <behzadnouri@gmail.com>
|
2021-04-01 01:28:01 +00:00 |
|
Michael Vines
|
959880db60
|
Remove unused pubkey::Pubkey imports
|
2020-10-21 19:08:13 -07:00 |
|
Michael Vines
|
7bc073defe
|
Run codemod --extensions rs Pubkey::new_rand solana_sdk::pubkey::new_rand
|
2020-10-21 19:08:13 -07:00 |
|
Tyera Eulberg
|
6c38369042
|
Use OrderedIterator in TransactionStatusService (#11149)
* Split out get-first-err for unit testing
* Add failing test
* Add missing ordering
|
2020-07-21 20:06:49 +00:00 |
|
Justin Starry
|
754f25ae99
|
Avoid AccountInUse errors when simulating transactions (#10391)
automerge
|
2020-06-04 19:06:01 -07:00 |
|
Michael Vines
|
b7b36bb0a4
|
Upgrade to Rust 1.42 (#8836)
* Upgrade to Rust 1.42
* deref
* parens
Co-authored-by: Trent Nelson <trent@solana.com>
|
2020-03-13 14:15:22 -06:00 |
|
Greg Fitzgerald
|
127553ce4b
|
Wrap ed25519_dalek::Keypair (#8247)
|
2020-02-12 14:15:12 -07:00 |
|
Jack May
|
83718a3b3e
|
Cleanup runtime use syntax (#8002)
|
2020-01-28 17:03:20 -08:00 |
|
Justin Starry
|
9807f47d4e
|
Rename genesis block to genesis config (#6816)
|
2019-11-08 23:56:57 -05:00 |
|
Greg Fitzgerald
|
fb39bd45d7
|
Revert "Rename solana-runtime to sealevel (#6239)" (#6247)
This reverts commit 2e921437cd.
|
2019-10-04 19:33:29 -06:00 |
|
Greg Fitzgerald
|
2e921437cd
|
Rename solana-runtime to sealevel (#6239)
automerge
|
2019-10-04 15:02:44 -07:00 |
|
Rob Walker
|
5cbd1190b2
|
transaction batch (#5962)
* transaction batch
* fixup
|
2019-09-19 10:06:08 -07:00 |
|