gaspersic/solana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
15,236 Commits 81 Branches 357 Tags
a8c56a1dfa3e99e63aafe31cba2af5b10ccdaaeb
Commit Graph

59 Commits

Author SHA1 Message Date
Tyera Eulberg
9f53f3455a Revert "Revert "Reformat imports to a consistent style for imports"" 
This reverts commit d7377d4794.
 2021-12-16 19:28:48 -07:00
Trent Nelson
d7377d4794 Revert "Reformat imports to a consistent style for imports" 
This reverts commit 139d15cd84.
 2021-12-13 12:46:23 -06:00
Michael Vines
139d15cd84 Reformat imports to a consistent style for imports 
rustfmt.toml configuration:
        imports_granularity = "One"
         group_imports = "One"
 2021-12-03 09:41:09 -08:00
mergify[bot]
aa8d04d44b uses nanos precision for timestamp when submitting metrics to influxdb (#20623) (#20659) 
Current datapoint_info! is apparently overwriting itself when run inside
a loop. For example in
https://github.com/solana-labs/solana/blob/005d6863f/core/src/window_service.rs#L101-L107
only one of the slots will show up in influxdb.

This is apparently because of metrics code using milliseconds as the
timestamp, as mentioned here:
https://github.com/solana-labs/solana/issues/19789#issuecomment-922482013

(cherry picked from commit cd87525f54)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
 2021-10-13 20:47:01 +00:00
mergify[bot]
03da3eaa81 Optimize RPC pubsub for multiple clients with the same subscription (backport #18943) (#19987) 
* Optimize RPC pubsub for multiple clients with the same subscription (#18943)

* reimplement rpc pubsub with a broadcast queue

* update tests for new pubsub implementation

* fix: fix review suggestions

* chore(rpc): add additional pubsub metrics

* integrate max subscriptions check into SubscriptionTracker to reduce locking

* separate subscription control from tracker

* limit memory usage of items in pubsub broadcast queue, improve error handling

* add more pubsub metrics

* add final count metrics to pubsub

* add metric for total number of subscriptions

* fix small review suggestions

* remove by_params from SubscriptionTracker and add node_progress_watchers map instead

* add subscription tracker tests

* add metrics for number of pubsub notifications as a counter

* ignore clippy lint in TokenCounter

* fix underflow in token counter

* reduce queue capacity in pubsub tests

* fix(rpc): fix test timeouts

* fix race in account subscription test

* Add RpcSubscriptions::new_for_tests

Co-authored-by: Pavel Strakhov <p.strakhov@iconic.vc>
Co-authored-by: Nikita Podoliako <n.podoliako@zubr.io>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
(cherry picked from commit 65227f44dc)

# Conflicts:
#	Cargo.lock
#	core/Cargo.toml
#	core/src/replay_stage.rs
#	core/src/validator.rs
#	replica-node/src/replica_node.rs
#	rpc/Cargo.toml

* Fix conflicts (and standardize naming to make future subscription backports easier

Co-authored-by: Pavel Strakhov <ri@idzaaus.org>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
 2021-09-20 06:00:08 +00:00
mergify[bot]
0e7512a225 Fix Nightly Clippy Warnings (backport #18065) (#18070) 
* chore: cargo +nightly clippy --fix -Z unstable-options

(cherry picked from commit 6514096a67)

# Conflicts:
#	core/src/banking_stage.rs
#	core/src/cost_model.rs
#	core/src/cost_tracker.rs
#	core/src/execute_cost_table.rs
#	core/src/replay_stage.rs
#	core/src/tvu.rs
#	ledger-tool/src/main.rs
#	programs/bpf_loader/build.rs
#	rbpf-cli/src/main.rs
#	sdk/cargo-build-bpf/src/main.rs
#	sdk/cargo-test-bpf/src/main.rs
#	sdk/src/secp256k1_instruction.rs

* chore: cargo fmt

(cherry picked from commit 789f33e8db)

* Updates BPF program assert_instruction_count tests.

(cherry picked from commit c1e03f3410)

# Conflicts:
#	programs/bpf/tests/programs.rs

* Resolve conflicts

Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Co-authored-by: Michael Vines <mvines@gmail.com>
 2021-06-18 20:02:48 +00:00
mergify[bot]
523dac1be3 metrics: Don't unwrap client instantiation errors (#18019) 
(cherry picked from commit 5cc073420a)

Co-authored-by: Trent Nelson <trent@solana.com>
 2021-06-17 07:08:36 +00:00
Ruud van Asseldonk
3f92abedd5 Make metrics tests independent of RUST_LOG env var (#16710) 
Previously, running the tests with RUST_LOG=none would fail, because the
env logger would set its filter level to reject all log messages, and
incrementing a counter only happens if the global logger has at least
the specified log level. Having the tests behave differently when
RUST_LOG is set is surprising, they should be self-contained.

Nix' buildRustPackage sets RUST_LOG="" to make the build logs less
verbose. I have trouble packaging Solana for Nix because of this, and I
believe making the tests independent of the environment is a good
solution for this.
 2021-04-21 18:14:49 -06:00
Trent Nelson
7f7370c306 Re-allow clippy::integer_arithmetic at crate-level 2021-02-17 13:55:08 -07:00
Tom Parker-Shemilt
01230a0105 Remove serial_test_derive dependency (#14891) 2021-01-28 22:35:31 -07:00
Michael Vines
cbffab7850 Upgrade to Rust v1.49.0 2021-01-23 19:16:36 -08:00
Kristofer Peterson
e23340d89e Clippy cleanup for all targets and nighly rust (also support 1.44.0) (#10445) 
* address warnings from 'rustup run beta cargo clippy --workspace'

minor refactoring in:
- cli/src/cli.rs
- cli/src/offline/blockhash_query.rs
- logger/src/lib.rs
- runtime/src/accounts_db.rs

expect some performance improvement AccountsDB::clean_accounts()

* address warnings from 'rustup run beta cargo clippy --workspace --tests'

* address warnings from 'rustup run nightly cargo clippy --workspace --all-targets'

* rustfmt

* fix warning stragglers

* properly fix clippy warnings test_vote_subscribe()
replace ref-to-arc with ref parameters where arc not cloned

* Remove lock around JsonRpcRequestProcessor (#10417)

automerge

* make ancestors parameter optional to avoid forcing construction of empty hash maps

Co-authored-by: Greg Fitzgerald <greg@solana.com>
 2020-06-09 09:38:14 +09:00
Kristofer Peterson
58ef02f02b 9951 clippy errors in the test suite (#10030) 
automerge
 2020-05-15 09:35:43 -07:00
Michael Vines
3acfe42622 Exit cleanly on panic! so the process don't limp along in a half-dead state (#9690) 2020-04-23 12:05:13 -07:00
Michael Vines
f142451a33 Reduce metrics log output 2020-04-17 23:38:14 -07:00
sakridge
7079559c2d Fix windows build by removing sys-info (#8860) 
Doesn't build for windows.
 2020-03-16 12:53:13 -07:00
Michael Vines
f4622d67e9 Submit all metrics in one HTTP POST rather than a HTTP POST per level 2020-02-20 18:12:30 -07:00
anatoly yakovenko
17fb8258e5 Datapoints overwhelm the metrics queue and blow up ram usage. (#8272) 
automerge
 2020-02-14 11:11:55 -08:00
dependabot-preview[bot]
57858b8015 Bump reqwest from 0.9.24 to 0.10.0 (#7642) 
* Bump reqwest from 0.9.24 to 0.10.0

Bumps [reqwest](https://github.com/seanmonstar/reqwest) from 0.9.24 to 0.10.0.
- [Release notes](https://github.com/seanmonstar/reqwest/releases)
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/seanmonstar/reqwest/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Make reqwest::blocking specific

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
 2020-01-08 13:31:43 -07:00
Rob Walker
a7040896f0 Update to rust 1.40.0 (#7572) 
* Update to rust 1.40.0

* fixups
 2019-12-19 23:27:54 -08:00
Michael Vines
9c00ad9ff2 Remove some low-hanging TODOs (#6839) 2019-11-08 16:41:36 -07:00
sakridge
5ef012b2c1 Tweak debug to remove unreadable datapoints (#6060) 2019-10-04 16:25:22 -07:00
Michael Vines
c1c7e0ff08 Remove reduntant semicolon 2019-10-03 16:25:00 -07:00
Tyera Eulberg
7babfd00c1 Revert back to reqwest, using rustls feature (#6041) 
* Revert back to reqwest, using rustls feature

* Cargo.lock and crate-features

* Ignore test
 2019-09-24 14:10:59 -06:00
Michael Vines
3d44cffcda ✨ Beautify metrics datapoint logging (#5998) 2019-09-20 12:00:43 -07:00
Michael Vines
a6479eb6e9 Data points are now logged according to their level, instead of always debug! (#5906) 
Note that Counters remain at debug! to avoid excessive default logging
 2019-09-14 08:52:09 -07:00
Michael Vines
df205f8752 Use ureq instead of influx_db_client (#5839) 2019-09-07 12:48:45 -07:00
Tyera Eulberg
b19d9a50d3 Transition to ureq http client (#5777) 
* Transition to ureq http client

* Remove unwrap
 2019-09-04 12:11:44 -07:00
Michael Vines
6089c8030b Validator/replicator metrics host id is no longer set by bash (#5755) 
automerge
 2019-08-30 15:33:30 -07:00
Michael Vines
f6b63a7dbc Decode SOLANA_METRICS_CONFIG instead of relying on some bash to do it (#5633) 2019-08-23 21:17:10 -07:00
Greg Fitzgerald
471bc73a23 Fix Rust 1.37.0 compiler warnings (#5530) 
Looks like most usages of trait objects should have introduced
a type variable instead.
 2019-08-15 14:00:09 -06:00
Justin Starry
0fde19239b Rate limit counter metrics points to one per second (#5496) 
* Rate limit counter metrics points to one per second

* Remove old env var

* Test that metrics counter is incrementing

* Fix typo
 2019-08-12 18:15:34 -04:00
Justin Starry
4f86c0b74a Rate limit transaction counters (#5447) 
* Rate limit transaction counters

* @sakridge feedback

* Set default high metrics rate for multinode demo

* Fix tests

* Swap defaults and fix env var tests

* Only set metrics rate if not already set
 2019-08-08 17:05:06 -04:00
Justin Starry
3ab1b46ef7 Fix vote metrics (#5377) 2019-08-01 09:11:49 -04:00
Justin Starry
84368697af Fix metrics when leader does not report metrics (#5291) 2019-07-30 16:18:33 -04:00
Michael Vines
3a69459645 Surface validator pubkey in metrics (#5227) 2019-07-22 16:08:21 -07:00
sakridge
9b54528c8e Fix some nightly warnings (#5093) 
ONCE_INIT => Once::new
Box<Error> => Box<dyn Error>
 2019-07-14 13:37:55 -07:00
Sagar Dhawan
55b8ff72d0 Enable parallel tests to reduce test time (#4919) 
* Add crate to serialize some tests

* Ignore unused attribute warning

* Enable parallel run in CI

* Try to fix lograte tests

* Fix interdependent counter tests
 2019-07-02 17:35:03 -07:00
Michael Vines
ed05aeaef8 Permit datapoints with no fields 2019-06-13 16:09:09 -07:00
carllin
c9d63204eb Replace unneeded seqcst with relaxed on atomic operations (#4587) 2019-06-06 23:53:21 -07:00
Michael Vines
a7e160e5c4 Add datapoint metrics to dashboard (#4343) 
automerge
 2019-05-19 15:07:03 -07:00
Michael Vines
6283cc916d Add SOLANA_METRICS_MAX_POINTS_PER_SECOND env var (#4342) 2019-05-19 13:56:52 -07:00
Pankaj Garg
9476fe5ce3 Use log levels for datapoint metrics (#4335) 
* Use log levels for datapoint metrics

* address review comments

* fix cyclomatic complexity
 2019-05-17 17:34:05 -07:00
Pankaj Garg
b2ce5dc9f5 Adjust log level for counter metrics (#4323) 2019-05-17 07:00:06 -07:00
Pankaj Garg
e920191de0 Rate limit metrics per log level (#4313) 
* Rate limit metrics per log level

* fix tests
 2019-05-16 22:27:05 -07:00
Dan Albert
e2830f5b0e Add rate limit to metrics datapoint submission (#4237) 
Cleanup

Raise limit on submission threshold

Pick nits and add metrics point

fmt

Fixup compiler warning

Cleanup if-else

Append new point to vec rather than submit
 2019-05-13 14:17:25 -06:00
Jack May
f567877d1d Cleanup metrics (#4230) 2019-05-10 08:33:58 -07:00
Jack May
8b34fd2c75 Fix warnings on nightly (#4028) 2019-04-26 16:25:13 -07:00
sakridge
fd60ef8a8d Allow metrics rate to differ from log rate (#3993) 
And reduce metrics rate for exchange contract counters.
Since we can go 10s-100s thousands of contracts per second,
some metrics would be dropped if submitting every time.
 2019-04-25 16:58:49 -07:00
Rob Walker
01657ddfe7 packet.rs optimizations (#3818) 
* packet.rs optimizations

* remove redundant and aggressive metric submission

* remove metrics submit(), get compiling again, honor log level in inc()
 2019-04-17 14:14:57 -07:00