mergify[bot] fbe5a89e74 retains hash value of outdated responses received from pull requests (#12513) (#12603) ...

pull_response_fail_inserts has been increasing:
https://cdn.discordapp.com/attachments/478692221441409024/759096187587657778/pull_response_fail_insert.png
but for outdated values which fail to insert:
https://github.com/solana-labs/solana/blob/a5c3fc14b3/core/src/crds_gossip_pull.rs#L332-L344
https://github.com/solana-labs/solana/blob/a5c3fc14b3/core/src/crds.rs#L104-L108
are not recorded anywhere, and so the next pull request may obtain the
same redundant payload again, unnecessary taking bandwidth.

This commit holds on to the hashes of failed-inserts for a while, similar
to purged_values:
https://github.com/solana-labs/solana/blob/a5c3fc14b3/core/src/crds_gossip_pull.rs#L380
and filter them out for the next pull request:
https://github.com/solana-labs/solana/blob/a5c3fc14b3/core/src/crds_gossip_pull.rs#L204

(cherry picked from commit 1866521df6)

Co-authored-by: behzad nouri <behzadnouri@gmail.com>

2020-10-01 01:47:20 +00:00

..

benches

builds crds filters in parallel (bp #12360) (#12571)

2020-09-30 01:08:16 +00:00

src

retains hash value of outdated responses received from pull requests (#12513) (#12603)

2020-10-01 01:47:20 +00:00

tests

retains hash value of outdated responses received from pull requests (#12513) (#12603)

2020-10-01 01:47:20 +00:00

.gitignore

tmp dirs target to farf (#5079)

2019-07-12 18:28:42 -07:00

build.rs

Introduce automatic ABI maintenance mechanism (2/2; rollout) (#8012)

2020-07-06 20:22:23 +09:00

Cargo.toml

builds crds filters in parallel (bp #12360) (#12571)

2020-09-30 01:08:16 +00:00