From 4ece9fd1f37520c91e5ab91279c61f9ffcbd5442 Mon Sep 17 00:00:00 2001
From: Yan Da <dyanab@connect.ust.hk>
Date: Sun, 1 May 2022 13:06:51 +0800
Subject: [PATCH] Move dependentDialects from .cpp to .td

---
 include/triton/Conversion/Passes.td                   |  5 +++++
 .../TritonToTritonGPU/TritonToTritonGPU.cpp           | 11 +----------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/include/triton/Conversion/Passes.td b/include/triton/Conversion/Passes.td
index 2e10e0a09..b41964657 100644
--- a/include/triton/Conversion/Passes.td
+++ b/include/triton/Conversion/Passes.td
@@ -9,6 +9,11 @@ def ConvertTritonToTritonGPU: Pass<"convert-triton-to-tritongpu", "mlir::ModuleO
         
     }];
     let constructor = "mlir::triton::createConvertTritonToTritonGPUPass()";
+
+    let dependentDialects = ["mlir::arith::ArithmeticDialect",
+                             "mlir::StandardOpsDialect",
+                             // TODO: Does this pass depend on SCF?
+                             "mlir::scf::SCFDialect"];
 }
 
 #endif
diff --git a/lib/Conversion/TritonToTritonGPU/TritonToTritonGPU.cpp b/lib/Conversion/TritonToTritonGPU/TritonToTritonGPU.cpp
index 8b8ceb289..5387df5d6 100644
--- a/lib/Conversion/TritonToTritonGPU/TritonToTritonGPU.cpp
+++ b/lib/Conversion/TritonToTritonGPU/TritonToTritonGPU.cpp
@@ -51,15 +51,6 @@ class ConvertTritonToTritonGPU:
     public ConvertTritonToTritonGPUBase<ConvertTritonToTritonGPU> {
 
 public:
-    void getDependentDialects(DialectRegistry& registry) const override {
-        registry.insert<arith::ArithmeticDialect>();
-        registry.insert<StandardOpsDialect>();
-        registry.insert<scf::SCFDialect>();
-        // LLVM15
-        // registry.insert<cf::ControlFlowDialect>()
-        // registry.insert<func::FuncDialect>()
-    }
-
     void runOnOperation() override {
         MLIRContext *context = &getContext();
         ConversionTarget target(*context);
@@ -83,4 +74,4 @@ public:
 std::unique_ptr<OperationPass<ModuleOp>>
 mlir::triton::createConvertTritonToTritonGPUPass() {
   return std::make_unique<::ConvertTritonToTritonGPU>();
-}
\ No newline at end of file
+}