From 531ef18cb663234487dff9318f2c67ffc8206317 Mon Sep 17 00:00:00 2001
From: rsanthanam-amd <70280935+rsanthanam-amd@users.noreply.github.com>
Date: Fri, 28 Oct 2022 14:06:17 -0500
Subject: [PATCH] Fix for binop % (mod) unit test failures. (#13)

If the either data type if fp, then fmod should be used for the
reference computation.
---
 python/test/unit/language/test_core.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/python/test/unit/language/test_core.py b/python/test/unit/language/test_core.py
index 4284baa03..dfb7f2535 100644
--- a/python/test/unit/language/test_core.py
+++ b/python/test/unit/language/test_core.py
@@ -234,7 +234,6 @@ def _mod_operation_ill_conditioned(dtype_x, dtype_y) -> bool:
         ('int64', 'float32'),
         ('int64', 'float64'),
         ('uint16', 'bfloat16'),
-        ('uint16', 'float16'),
         ('uint16', 'float32'),
         ('uint32', 'bfloat16'),
         ('uint32', 'float16'),
@@ -258,7 +257,7 @@ def _mod_operation_ill_conditioned(dtype_x, dtype_y) -> bool:
 ])
 def test_bin_op(dtype_x, dtype_y, op, device='cuda'):
     expr = f' x {op} y'
-    if op == '%' and dtype_x in int_dtypes + uint_dtypes and dtype_y in int_dtypes + uint_dtypes:
+    if op == '%' and (dtype_x in dtypes and dtype_y in dtypes):
         # LLVM has 'numpy.fmod', not 'numpy.remainder', semantics on integer remainders.
         numpy_expr = 'np.fmod(x, y)'
     elif op in ('/', '%') and dtype_x in ('int16', 'float16', 'bfloat16') and dtype_y in ('int16', 'float16', 'bfloat16'):