Remove TypeConverter from TritonToTritonGPU conversion
This commit is contained in:
@@ -90,9 +90,8 @@ TritonGPUTypeConverter::TritonGPUTypeConverter(MLIRContext *context,
|
||||
//
|
||||
// TritonGPUConversion
|
||||
//
|
||||
TritonGPUConversionTarget::TritonGPUConversionTarget(
|
||||
MLIRContext &context, TritonGPUTypeConverter &typeConverter)
|
||||
: ConversionTarget(context), typeConverter(typeConverter) {
|
||||
TritonGPUConversionTarget::TritonGPUConversionTarget(MLIRContext &context)
|
||||
: ConversionTarget(context) {
|
||||
// TODO: we should also verify ops of TritonGPUDialect
|
||||
addLegalDialect<triton::gpu::TritonGPUDialect>();
|
||||
|
||||
@@ -104,7 +103,18 @@ TritonGPUConversionTarget::TritonGPUConversionTarget(
|
||||
triton::TritonDialect,
|
||||
StandardOpsDialect,
|
||||
scf::SCFDialect>([&](Operation *op) {
|
||||
if (typeConverter.isLegal(op))
|
||||
auto isLegal = [](Value v) -> bool {
|
||||
Type type = v.getType();
|
||||
if (auto tensorType = type.dyn_cast<RankedTensorType>()) {
|
||||
if (tensorType.getEncoding())
|
||||
return true;
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
};
|
||||
|
||||
if (llvm::all_of(op->getOperands(), isLegal) &&
|
||||
llvm::all_of(op->getResults(), isLegal))
|
||||
return true;
|
||||
return false;
|
||||
});
|
||||
@@ -117,9 +127,6 @@ TritonGPUConversionTarget::TritonGPUConversionTarget(
|
||||
if (aEncoding && aEncoding.isa<triton::gpu::TritonGPUSharedEncodingAttr>() &&
|
||||
bEncoding && bEncoding.isa<triton::gpu::TritonGPUSharedEncodingAttr>())
|
||||
return true;
|
||||
// // TODO: we should delete this
|
||||
// if (this->typeConverter.isLegal(dotOp))
|
||||
// return true;
|
||||
return false;
|
||||
});
|
||||
|
||||
|
Reference in New Issue
Block a user