From 69ff52ea1f98336e89f6cf27694196309e709aa9 Mon Sep 17 00:00:00 2001 From: Philippe Tillet Date: Sat, 5 Feb 2022 21:37:23 -0800 Subject: [PATCH] [CODEGEN] removed buggy (and mostly useless) optimization in peephole pass (#449) --- lib/codegen/transform/peephole.cc | 32 +++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/codegen/transform/peephole.cc b/lib/codegen/transform/peephole.cc index b381d3cb0..e30ab9b35 100644 --- a/lib/codegen/transform/peephole.cc +++ b/lib/codegen/transform/peephole.cc @@ -227,22 +227,22 @@ bool peephole::rewrite_cvt_layout(ir::instruction *value, ir::builder& builder){ ir::instruction* op = dynamic_cast(cvt->get_operand(0)); if(!op) return false; - // convert(elementwise(x, y)) = elementwise(convert(x), convert(y)) - if(op->get_id() == ir::INST_BINOP){ - for(size_t i = 0; i < op->get_num_operands(); i++){ - ir::value* arg_i = op->get_operand(i); - builder.set_insert_point(op); - // create new layout transform - ir::instruction* new_arg_i = cvt->clone(); - layouts_->copy(new_arg_i, op); - builder.insert(new_arg_i); - // set the right args - new_arg_i->replace_uses_of_with(new_arg_i->get_operand(0), arg_i); - op->replace_uses_of_with(arg_i, new_arg_i); - } - cvt->replace_all_uses_with(op); - return true; - } +// // convert(elementwise(x, y)) = elementwise(convert(x), convert(y)) +// if(op->get_id() == ir::INST_BINOP){ +// for(size_t i = 0; i < op->get_num_operands(); i++){ +// ir::value* arg_i = op->get_operand(i); +// builder.set_insert_point(op); +// // create new layout transform +// ir::instruction* new_arg_i = cvt->clone(); +// layouts_->copy(new_arg_i, op); +// builder.insert(new_arg_i); +// // set the right args +// new_arg_i->replace_uses_of_with(new_arg_i->get_operand(0), arg_i); +// op->replace_uses_of_with(arg_i, new_arg_i); +// } +// cvt->replace_all_uses_with(op); +// return true; +// } auto cvt_op = dynamic_cast(op); if(!cvt_op) return false;