[BUILD] Fix Warnings and Enable Warnings as Errors (#794)

include/triton/Analysis/Allocation.h

@@ -142,7 +142,7 @@ private:
     BufferT(BufferKind kind) : BufferT(kind, 0, 0) {}
     BufferT(BufferKind kind, size_t size) : BufferT(kind, size, 0) {}
     BufferT(BufferKind kind, size_t size, size_t offset)
-        : kind(kind), size(size), offset(offset), id(nextId++) {}
+        : kind(kind), id(nextId++), size(size), offset(offset) {}
 
     bool intersects(const BufferT &other) const {
       return Interval<size_t>(offset, offset + size)

include/triton/Analysis/AxisInfo.h

@@ -28,8 +28,8 @@ public:
            DimVectorT knownConstancy)
       : contiguity(knownContiguity), divisibility(knownDivisibility),
         constancy(knownConstancy), rank(contiguity.size()) {
-    assert(knownDivisibility.size() == rank);
-    assert(knownConstancy.size() == rank);
+    assert(knownDivisibility.size() == (size_t)rank);
+    assert(knownConstancy.size() == (size_t)rank);
   }
 
   // Accessors

include/triton/Conversion/TritonGPUToLLVM/PtxAsmFormat.h

@@ -15,9 +15,9 @@ class Location;
 namespace triton {
 using llvm::StringRef;
 
-class PTXInstr;
-class PTXInstrCommon;
-class PTXInstrExecution;
+struct PTXInstr;
+struct PTXInstrCommon;
+struct PTXInstrExecution;
 
 // PTXBuilder helps to manage a PTX asm program consists of one or multiple
 // instructions.
@@ -83,7 +83,7 @@ struct PTXBuilder {
     Operand() = default;
     Operand(const Operation &) = delete;
     Operand(Value value, StringRef constraint)
-        : value(value), constraint(constraint) {}
+        : constraint(constraint), value(value) {}
 
     bool isList() const { return !value && constraint.empty(); }
 
@@ -120,7 +120,7 @@ struct PTXBuilder {
   Operand *newListOperand(unsigned count, mlir::Value val,
                           const std::string &constraint) {
     auto *list = newOperand();
-    for (int i = 0; i < count; ++i) {
+    for (unsigned i = 0; i < count; ++i) {
       list->listAppend(newOperand(val, constraint));
     }
     return list;
@@ -128,7 +128,7 @@ struct PTXBuilder {
 
   Operand *newListOperand(unsigned count, const std::string &constraint) {
     auto *list = newOperand();
-    for (int i = 0; i < count; ++i) {
+    for (unsigned i = 0; i < count; ++i) {
       list->listAppend(newOperand(constraint));
     }
     return list;
@@ -172,8 +172,8 @@ private:
     return argArchive.back().get();
   }
 
-  friend class PTXInstr;
-  friend class PTXInstrCommon;
+  friend struct PTXInstr;
+  friend struct PTXInstrCommon;
 
 protected:
   llvm::SmallVector<std::unique_ptr<Operand>, 6> argArchive;
@@ -209,7 +209,7 @@ protected:
   PTXBuilder *builder{};
   llvm::SmallVector<std::string, 4> instrParts;
 
-  friend class PTXInstrExecution;
+  friend struct PTXInstrExecution;
 };
 
 template <class ConcreteT> struct PTXInstrBase : public PTXInstrCommon {
@@ -309,7 +309,7 @@ struct PTXInstrExecution {
   PTXInstrExecution() = default;
   explicit PTXInstrExecution(PTXInstrCommon *instr,
                              llvm::ArrayRef<Operand *> oprs)
-      : instr(instr), argsInOrder(oprs.begin(), oprs.end()) {}
+      : argsInOrder(oprs.begin(), oprs.end()), instr(instr) {}
 
   // Prefix a predicate to the instruction.
   PTXInstrExecution &predicate(mlir::Value value, StringRef constraint = "b") {

include/triton/Conversion/TritonGPUToLLVM/TritonGPUToLLVM.h

@@ -11,16 +11,12 @@ class ModuleOp;
 template <typename T> class OperationPass;
 
 class TritonLLVMConversionTarget : public ConversionTarget {
-  mlir::LLVMTypeConverter &typeConverter;
-
 public:
   explicit TritonLLVMConversionTarget(MLIRContext &ctx,
                                       mlir::LLVMTypeConverter &typeConverter);
 };
 
 class TritonLLVMFunctionConversionTarget : public ConversionTarget {
-  mlir::LLVMTypeConverter &typeConverter;
-
 public:
   explicit TritonLLVMFunctionConversionTarget(
       MLIRContext &ctx, mlir::LLVMTypeConverter &typeConverter);

include/triton/Dialect/Triton/IR/Dialect.h

@@ -26,11 +26,11 @@ public:
   DialectInferLayoutInterface(Dialect *dialect) : Base(dialect) {}
 
   virtual LogicalResult
-  inferReduceOpEncoding(Attribute operandEncoding, int axis,
+  inferReduceOpEncoding(Attribute operandEncoding, unsigned axis,
                         Attribute &resultEncoding) const = 0;
 
   virtual LogicalResult
-  inferExpandDimsOpEncoding(Attribute operandEncoding, int axis,
+  inferExpandDimsOpEncoding(Attribute operandEncoding, unsigned axis,
                             Attribute &resultEncoding) const = 0;
 };
 

include/triton/Dialect/TritonGPU/Transforms/TritonGPUConversion.h

@@ -21,7 +21,6 @@ private:
 };
 
 class TritonGPUConversionTarget : public ConversionTarget {
-  TritonGPUTypeConverter &typeConverter;
 
 public:
   explicit TritonGPUConversionTarget(MLIRContext &ctx,