gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(error-reporter): Only report uncaught errors (#16526)

Browse Source 
Errors that have status codes do not need reporting. If opbeat is not enabled, do not report
This commit is contained in:
Berkeley Martinez
2018-01-18 21:33:57 -08:00
committed by mrugesh mohapatra
parent 1d7e5535d1
commit 13c9d97262
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
server/middlewares/error-reporter.js
View File

@ -8,7 +8,8 @@ import {
const log = debug('fcc:middlewares:error-reporter'); const log = debug('fcc:middlewares:error-reporter');
export default function errorHandler() { const isOpbeatDisabled = !opbeat.appId;
export default function errrorReporter() {
if (process.env.NODE_ENV !== 'production') { if (process.env.NODE_ENV !== 'production') {
return (err, req, res, next) => { return (err, req, res, next) => {
if (isHandledError(err)) { if (isHandledError(err)) {
@ -22,7 +23,14 @@ export default function errorHandler() {
return (err, req, res, next) => { return (err, req, res, next) => {
// handled errors do not need to be reported // handled errors do not need to be reported
// the report a message and redirect the user // the report a message and redirect the user
if (isHandledError(err)) { if (
isOpbeatDisabled ||
isHandledError(err) ||
// errors with status codes shouldn't be reported
// as they are usually user messages
err.statusCode ||
err.status
) {
return next(err); return next(err);
} }
return opbeat.captureError(err, { request: req }, () => next(err)); return opbeat.captureError(err, { request: req }, () => next(err));