gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor(server/challenge): Make code dry

Browse Source
This commit is contained in:
Berkeley Martinez
2017-09-08 00:16:02 -07:00
parent 6cbdbc2580
commit 56e3d3a986
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/boot/challenge.js
View File

@ -14,8 +14,9 @@ function buildUserUpdate(
completedChallenge,
timezone
) {
const updateData = { $set: {} };
let finalChallenge;
let numOfAttempts = 1;
const updateData = { $set: {} };
const { timezone: userTimezone, challengeMap = {} } = user;
const oldChallenge = challengeMap[challengeId];
@ -23,13 +24,14 @@ function buildUserUpdate(
if (alreadyCompleted) {
// add data from old challenge
const attempts = oldChallenge.numOfAttempts;
const numOfAttempts = attempts ? attempts + 1 : 0;
finalChallenge = {
if (oldChallenge.numOfAttempts) {
numOfAttempts = oldChallenge.numOfAttempts + 1;
}
finalChallenge = {
...completedChallenge,
completedDate: oldChallenge.completedDate,
lastUpdated: completedChallenge.completedDate,
numOfAttempts: numOfAttempts
numOfAttempts
};
} else {
updateData.$push = {
@ -40,7 +42,7 @@ function buildUserUpdate(
};
finalChallenge = {
...completedChallenge,
numOfAttempts: 1
numOfAttempts
};
}