gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Slot Machine false positives

Browse Source 
The 'Add your JavaScript Slot Machine Slots' waypoint would
throw false positives if all slot numbers were the same, effectively
allowing the campers to pass the test without having written any code.
This commit is contained in:
ahstro
2015-09-21 23:10:13 +02:00
parent 64eb830ca7
commit 5f4ecc72e4
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
challenges/basic-javascript.json
View File

@ -1302,7 +1302,7 @@
"<code>}</code>"
],
"tests":[
"assert((function(){var data = runSlots();if(data === null){return true}else{if(data[0] === data[1] && data[1] === data[2]){return true;}else{return false;}}})(), 'If all three of our random numbers are the same we should return that number. Otherwise we should return <code>null</code>.')"
"assert((function(){var data = runSlots();return data === null || data.toString().length === 1;})(), 'If all three of our random numbers are the same we should return that number. Otherwise we should return <code>null</code>.')"
],
"challengeSeed":[
"fccss",
@ -1485,9 +1485,10 @@
" ",
" // Only change code above this line.",
" ",
" if(slotOne !== slotTwo || slotTwo !== slotThree){",
" return null;",
" if(slotOne === slotTwo && slotTwo === slotThree){",
" return slotOne;",
" }",
" return null;",
" ",
" if(slotOne !== undefined && slotTwo !== undefined && slotThree !== undefined){",
" $(\".logger\").html(slotOne);",
@ -1655,9 +1656,10 @@
" ",
" // Only change code above this line.",
" ",
" if(slotOne !== slotTwo || slotTwo !== slotThree){",
" return null;",
" if(slotOne === slotTwo && slotTwo === slotThree){",
" return slotOne;",
" }",
" return null;",
" ",
" if(slotOne !== undefined && slotTwo !== undefined && slotThree !== undefined){",
" $('.logger').html(slotOne);",