gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: update jaws on resize (#43777)

Browse Source 
* fix: update jaws on resize

Use isProjectStep to determine if the jaws need to be updated

* refactor: isProjectStep -> hasEditableRegion

isProjectStep was misleading.  hasEditableRegion correctly describes
that function and leaves isProjectStep to enable features that are
unique to project steps, but nothing to do with the editable region
This commit is contained in:
Oliver Eyton-Williams
2021-10-13 11:40:28 +02:00
committed by GitHub
parent 2d4916cd2c
commit 61d6b02c79
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
client/src/templates/Challenges/classic/editor.tsx
View File

@ -293,7 +293,7 @@ const Editor = (props: EditorProps): JSX.Element => {
editorRef.current = editor;
data.editor = editor;
if (isProjectStep()) {
if (hasEditableRegion()) {
initializeProjectStepFeatures();
addContentChangeListener();
showEditableRegion(editor);
@ -658,7 +658,7 @@ const Editor = (props: EditorProps): JSX.Element => {
// Currently, only practice project parts have editable region markers
// This function is used to enable multiple editor tabs, jaws, etc.
function isProjectStep() {
function hasEditableRegion() {
const editableRegionBoundaries = getEditableRegionFromRedux();
return editableRegionBoundaries.length === 2;
}
@ -961,15 +961,15 @@ const Editor = (props: EditorProps): JSX.Element => {
const { editor } = data;
const hasChangedContents = updateEditorValues();
if (hasChangedContents && isProjectStep()) {
if (hasChangedContents && hasEditableRegion()) {
initializeProjectStepFeatures();
updateDescriptionZone();
updateOutputZone();
}
if (hasChangedContents && !isProjectStep()) editor?.focus();
if (hasChangedContents && !hasEditableRegion()) editor?.focus();
if (isProjectStep() && editor) {
if (hasEditableRegion() && editor) {
if (hasChangedContents) {
editor.focus();
showEditableRegion(editor);
@ -1078,7 +1078,7 @@ const Editor = (props: EditorProps): JSX.Element => {
useEffect(() => {
const editor = data.editor;
editor?.layout();
if (data.startEditDecId) {
if (hasEditableRegion()) {
updateDescriptionZone();
updateOutputZone();
}