gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(frame): Fix fcc-test-frame on firefox

Browse Source 
I used an alternative to display: none; to allow Firefox to properly run
challenge tests

Closes #10749
This commit is contained in:
dhcodes
2017-08-18 15:23:39 -05:00
parent f373eca1aa
commit 6caf034e70
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
client/epics/frame-epic.js
View File

@ -35,7 +35,7 @@ const createHeader = (id = mainId) => `
function createFrame(document, id = mainId) { function createFrame(document, id = mainId) {
const frame = document.createElement('iframe'); const frame = document.createElement('iframe');
frame.id = id; frame.id = id;
frame.setAttribute('style', 'display: none'); frame.className = 'hide-test-frame';
document.body.appendChild(frame); document.body.appendChild(frame);
return frame; return frame;
} }

7
client/less/main.less
View File

@ -126,6 +126,13 @@ h1, h2, h3, h4, h5, h6, p, li {
margin: 2px; margin: 2px;
} }
.hide-test-frame {
position: absolute;
top: -9999px;
left: -9999px;
visibility: hidden;
}
.landing-icon { .landing-icon {
height: 200px; height: 200px;
width: 200px; width: 200px;