gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix(learn): Remove arrows from test name assertion (#40467)

Browse Source 
* fix: Remove arrows from test name assertion

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Add note about time span

Adds a note regarding the expectation of the `span` element to wrap the
entire time string when translated, not just the delimiter symbol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: use correct note syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove note syntax

New line was breaking the build, so changing the `note` comment to be
regular text.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
This commit is contained in:
Nicholas Carrigan (he/him)
2021-01-20 20:57:32 -08:00
committed by GitHub
parent b07394603b
commit 891a64fa3d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md
View File

@ -102,7 +102,7 @@ async (getUserInput) => {
}; };
``` ```
The `/api/translate` route should handle the way time is written in American and British English. For example, ten thirty is written as "10.30" in British English and "10:30" in American English. The `/api/translate` route should handle the way time is written in American and British English. For example, ten thirty is written as "10.30" in British English and "10:30" in American English. The `span` element should wrap the entire time string, i.e. `<span class="highlight">10:30</span>`.
```js ```js
async (getUserInput) => { async (getUserInput) => {
@ -283,7 +283,7 @@ async (getUserInput) => {
const getTests = await $.get(getUserInput('url') + '/_api/get-tests'); const getTests = await $.get(getUserInput('url') + '/_api/get-tests');
assert.isArray(getTests); assert.isArray(getTests);
const unitTests = getTests.filter((test) => { const unitTests = getTests.filter((test) => {
return !!test.context.match(/Unit Tests ->/gi); return !!test.context.match(/Unit Tests/gi);
}); });
assert.isAtLeast(unitTests.length, 24, 'At least 24 tests passed'); assert.isAtLeast(unitTests.length, 24, 'At least 24 tests passed');
unitTests.forEach((test) => { unitTests.forEach((test) => {
@ -308,7 +308,7 @@ async (getUserInput) => {
const getTests = await $.get(getUserInput('url') + '/_api/get-tests'); const getTests = await $.get(getUserInput('url') + '/_api/get-tests');
assert.isArray(getTests); assert.isArray(getTests);
const functTests = getTests.filter((test) => { const functTests = getTests.filter((test) => {
return !!test.context.match(/Functional Tests ->/gi); return !!test.context.match(/Functional Tests/gi);
}); });
assert.isAtLeast(functTests.length, 6, 'At least 6 tests passed'); assert.isAtLeast(functTests.length, 6, 'At least 6 tests passed');
functTests.forEach((test) => { functTests.forEach((test) => {