gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: make github url optional for backend projects (#37936)

Browse Source
This commit is contained in:
Tom
2019-12-20 08:00:33 -06:00
committed by mrugesh
parent 01b37f664f
commit a8a7eeb10d
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
api-server/server/boot/challenge.js
View File

@ -261,11 +261,7 @@ function projectCompleted(req, res, next) {
]); ]);
completedChallenge.completedDate = Date.now(); completedChallenge.completedDate = Date.now();
if ( if (!completedChallenge.solution) {
!completedChallenge.solution ||
// only basejumps require github links
(completedChallenge.challengeType === 4 && !completedChallenge.githubLink)
) {
return res.status(403).json({ return res.status(403).json({
type: 'error', type: 'error',
message: message:

2
client/src/templates/Challenges/projects/ProjectForm.js
View File

@ -18,7 +18,7 @@ const options = {
solution: 'url', solution: 'url',
githubLink: 'url' githubLink: 'url'
}, },
required: ['solution', 'githubLink'] required: ['solution']
}; };
export class ProjectForm extends Component { export class ProjectForm extends Component {