gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: suppress warning for seedless challenges (#41507)

Browse Source 
Both challengeType 11 and challengeType 3 have no seeds, so there's no
need to warn about a lack of seed.

The warning has been updated to better reflect the problem (lack of
seed, not lack of comments)
This commit is contained in:
Oliver Eyton-Williams
2021-03-16 16:22:39 +01:00
committed by GitHub
parent 97e040e0a4
commit cbdf317aae
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
curriculum/getChallenges.js
View File

@ -228,9 +228,10 @@ async function buildChallenges({ path }, curriculum, lang) {
async function parseTranslation(transPath, dict, lang, parse = parseMD) {
const translatedChal = await parse(transPath);
// challengeType 11 is for video challenges, which have no seeds, so we skip
// them.
return translatedChal.challengeType !== 11
const { challengeType } = translatedChal;
// challengeType 11 is for video challenges and 3 is for front-end projects
// neither of which have seeds.
return challengeType !== 11 && challengeType !== 3
? translateCommentsInChallenge(translatedChal, lang, dict)
: translatedChal;
}

2
tools/challenge-parser/translation-parser/index.js
View File

@ -17,7 +17,7 @@ exports.translateComments = (text, lang, dict, codeLang) => {
exports.translateCommentsInChallenge = (challenge, lang, dict) => {
const challClone = cloneDeep(challenge);
if (!challClone.files) {
console.warn(`Challenge ${challClone.title} has no comments to translate`);
console.warn(`Challenge ${challClone.title} has no seed to translate`);
} else {
Object.keys(challClone.files).forEach(key => {
if (challClone.files[key].contents) {