Commit Graph

1724 Commits

Author SHA1 Message Date
gikf
7d9496e52c fix(curriculum): clean-up Project Euler 361-380 (#43002)
* fix: clean-up Project Euler 361-380

* fix: improve wording

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: remove unnecessary paragraph

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-29 12:48:17 -07:00
gikf
1af6e7aa5a fix(curriculum): clean-up Project Euler 321-340 (#42988)
* fix: clean-up Project Euler 321-340

* fix: typo

* fix: corrections from review

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-29 11:59:06 -07:00
gikf
a9c11f7fe2 fix: clean-up Project Euler 421-440 (#43047) 2021-07-29 11:14:09 -07:00
gikf
7bd08ae2ee fix: clean-up Project Euler 401-420 (#43028) 2021-07-29 10:48:24 -07:00
gikf
c18554dd44 fix(curriculum): clean-up Project Euler 341-360 (#42998)
* fix: clean-up Project Euler 341-360

* fix: improve wording

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-29 19:14:22 +02:00
Nicholas Carrigan (he/him)
8535c23b08 fix: address crowdin issues (#43021) 2021-07-26 19:43:15 +01:00
gikf
f93acf28a6 fix(curriculum): clean-up Project Euler 261-280 (#42905)
* fix: clean-up Project Euler 261-280

* fix: typo

* fix: typo

* fix: typo
2021-07-24 09:09:54 +02:00
Luca
970a1c1b56 fix(curriculum): fix incomplete test (#42970) 2021-07-22 16:01:04 -04:00
awu43
24250d278e feat(curriculum): rewrite capture groups description 2021-07-22 17:37:50 +02:00
gikf
47fc3c6761 fix(curriculum): clean-up Project Euler 281-300 (#42922)
* fix: clean-up Project Euler 281-300

* fix: missing image extension

* fix: missing power

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: missing subscript

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-22 12:38:46 +09:00
Nicholas Carrigan (he/him)
8900fe0b8e feat: CSS Cafe Menu (#41797)
* fix: general bugs

- Ensure editable region at end of code-block is followed by a blank
line.
- Remove apparent duplicate step.
- Address spelling issues.

* feat: some tests

* feat: tests 6-20

Add tests for steps 6-20.

* feat: tests 21-30

Add tests for steps 21 through 30.

* feat: tests 31-40

Add tests for steps 31 through 40.

* feat: tests 41-50

Add tests for steps 41 through 50.

* feat: tests 51-60

Add tests for steps 51 through 60.

* feat: tests 61-70

Add tests for steps 61 through 70.

* feat: tests 71-80

Add tests for steps 71 through 80.

* feat: steps 81-92

Add tests for steps 81 through 92.

* feat: align dashed names

Align the dashed names with the titles and file names.

* fix: apply gikf's suggestions

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: manual review suggestions

Apply gikf's other suggestions.

* feat: more thorough testing

When a test asserts that a camper adds a new element relative to
an existing element, also test that the existing element is not
malformed.

* feat: optional semi colons

Make EOL semi-colons optional in the CSS. If they're missing and the
CSS doesn't render correctly, other tests will catch that. If they
are on the last property of the ruleset, they technically aren't
required so we shouldn't require them?

* chore: apply review suggestions

Apply review suggestions from gikf

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* chore: apply suggestions from code review

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* feat: review suggestions

Apply Ahmad's review suggestions.

* chore: additional suggestions

Manual application of Ahmad's review suggestions.

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* feat: add clarification

Add a bit of text clarifying the file switch in the editor.

* chore: replace URLs

Replace the tinyurls with our self-hosted CDN images.

* feat: new CSS tests

Re-write CSS tests with new parser.

* fix: grammar

Apply Shaun's grammar reviews.

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: optional chaining

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply reviews manually

* chore: getStyle update

Replace getStyleDeclaration with getStyle.

* fix: resolve test issue

* chore: remove jQuery :(

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-21 14:03:09 -05:00
gikf
32dbe23f5e fix(curriculum): clean-up Project Euler 301-320 (#42926)
* fix: clean-up Project Euler 301-320

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-21 17:59:56 +02:00
Tom
8e28785913 fix(curriculum): remove outdated video (#42945) 2021-07-20 18:07:14 +02:00
Tom
292482792e update(curriculum): Change advanced bash tutorial title to new title (#42885)
* rename: advanced bash file

* rename: all instances of advanced bash tutorial to new title
2021-07-20 00:17:11 +05:30
alirezaghey
fec8466d4b fix(curriculum): update regex to account for bracket notation (#42881)
* fix: update regex to account for bracket notation

fix minor bug in regex referring to literal dots with a dot
closes #42877

* account for both single and double quotes

Co-authored-by: awu43 <46470763+awu43@users.noreply.github.com>

* fix: make case sensitive

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: awu43 <46470763+awu43@users.noreply.github.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
2021-07-17 18:29:27 +02:00
gikf
7907f62337 fix(curriculum): clean-up Project Euler 121-140 (#42731)
* fix: clean-up Project Euler 121-140

* fix: corrections from review

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: missing backticks

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: missing delimiter

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-16 21:38:37 +02:00
awu43
b84e74ad42 fix(curriculum): improve lazy matching test regex (#42882) 2021-07-16 15:31:19 +01:00
gikf
67de105117 fix(curriculum): clean-up Project Euler 241-260 (#42879)
* fix: clean-up Project Euler 241-260

* fix: typo

* Update curriculum/challenges/english/10-coding-interview-prep/project-euler/problem-255-rounded-square-roots.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-16 12:21:45 +02:00
awu43
4071b72a6c feat(curriculum): add spy helper (#42566)
* Added initial version of spy helper

* add missing backslashes

* update to check for line start

* change __fixtures file extensions to .ts from .tsx

* add to exports and add documentation

* add tests

* update event.preventDefault() test
2021-07-16 09:20:03 +02:00
Shaun Hamilton
ff20199e63 feat(curriculum): add tests to css variables skyline (#42067)
* add(tests): parts 1-2

* refactor for multi-file editor, and add temp css tests

* re-re-rebasing

* add link to subsequent challenges

* add test strings to 007-015

* add final tests 001-016

* fix 005-007, add 017-022 tests and test strings

* add: tests 021-030, and formatting

* add: 031-034 tests

* tests: add 035-046

* fix: test in 021

* tests: add 047-050

* format: 009, 051-118 remove css whitespace

* tests: add 051-078

* tests: add 079-105

* tests: add 104-118

* fix: empty -> isEmpty, and include -> match

* fix: correct editable region

* fix: formatting and spelling

* fix: test logic, and add TODO for whitespace

* fix: add final part solution 🤦‍♂️

* fix typo in part-006

* remove whitespace in prep

* getStyleDeclaration -> getStyle

* remove editable region from solution 🤦‍♂️

* fix: correct tests to fail on initial

* fix: add missing regex

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: correct tests

* remove commas and stuff 🤷‍♂️

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* uppercaserise doctype

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add "the"

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* remove half-colon

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* use more boring form of the word "shoudl"

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add suggestions to tests

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-015.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-022.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-093.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-098.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-101.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-023.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-024.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-026.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-035.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-076.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-070.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-079.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-085.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-086.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-087.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-074.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-078.md

* fix: the few commits I couldn't add on github

* fix: lesson 41

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-15 22:46:40 -05:00
gikf
5a52c229f5 fix(curriculum): clean-up Project Euler 181-200 (#42819)
* fix: clean-up Project Euler 181-200

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: missing delimiter

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-15 15:52:14 +02:00
gikf
a9418a1fe9 fix(curriculum): clean-up Project Euler 221-240 (#42839)
* fix: clean-up Project Euler 221-240

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-15 14:26:34 +02:00
gikf
eef1805fe6 fix(curriculum): clean-up Project Euler 201-220 (#42826)
* fix: clean-up Project Euler 201-220

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-15 09:20:31 +02:00
gikf
bfc21e4c40 fix(curriculum): clean-up Project Euler 141-160 (#42750)
* fix: clean-up Project Euler 141-160

* fix: corrections from review

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: use different notation for consistency

* Update curriculum/challenges/english/10-coding-interview-prep/project-euler/problem-144-investigating-multiple-reflections-of-a-laser-beam.md

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-14 13:05:12 +02:00
tristansoriaga
5e8ac21c26 fix(curriculum): remove example function calls from seed (#42797) 2021-07-13 16:37:38 +01:00
gikf
32fac23a2d fix(curriculum): clean-up Project Euler 161-180 (#42782)
* fix: clean-up Project Euler 161-180

* fix: corrections from review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-12 16:19:03 +02:00
Anirudh Modi
1e26dc1529 fix(curriculum): updates body-parser with explanation for extended config (#42740)
* fix: better explaination for body-parser extened config

* text readability by introducing line break

* grammer fixes

* fix: typo

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2021-07-11 15:06:57 +01:00
Innocent V.I
ac2fe62eef fixed create-decimal-numbers-with-javascript challenge external link (#42801) 2021-07-09 09:02:47 -05:00
Kristofer Koishigawa
b74b32385b fix: update data analysis with python links (#42698) 2021-07-06 10:40:29 +02:00
Lorem Ispum
28efec9e63 fix: recognize background-image as correct (#42738) (#42745)
* fix: recognize background-image as correct (#42738)

The page mentioned in #42738 before would not accept background-image and background, now it should.

* fix: CI build error

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-07-05 12:28:49 +02:00
tristansoriaga
4be8a6f224 fix: Added comments on the function for clarity on coding-interview-prep (#42689) 2021-07-02 18:15:58 +05:30
gikf
dc168cd96d fix(curriculum): clean-up Project Euler 101-120 (#42597)
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2021-06-30 14:25:46 +02:00
Braxton Excell
6631e51113 fix(curriculum): update object keys referenced in instructions to match provided object (#42613)
* Update referenced object keys for clarity

Because each movie object has both `Rated` and `imdbRating` key/value pairs, simply referencing `rating` could be confusing to campers. IMO explicitly referencing the keys by name (`Title` and `imdbRating`) removes ambiguity in the non-important part of this challenge and helps campers focus on learning about `.map()`.

* other references and tests

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/use-the-map-method-to-extract-data-from-an-array.md

* reverse previous changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/use-the-map-method-to-extract-data-from-an-array.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-28 16:25:33 +02:00
gikf
052173e502 fix(curriculum): improve description and tests descriptions (#42546)
* fix: replace html with markdown and MathJax

* fix: replace html with markdown and MathJax

* fix: replace example

* fix: clarify expected input and output

* fix: add another test

* fix: change image in seed code

* fix: grammar

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-06-28 13:16:25 +05:30
Aileen
35f8295d7a quickfix: curriculum test regex now covers new line format (#42638) 2021-06-28 13:13:12 +05:30
alirezaghey
33aa14bc4a fix(curriculum): reference to file in boilerplate project (#42616) 2021-06-24 12:02:51 +01:00
Alan Luo
4ed0befc4e fix(curriculum): link mismatch (#42610) 2021-06-23 17:08:39 +00:00
alirezaghey
7defcaf58e fix(curriculum): fix typo in sudoku-solver description (#42601) 2021-06-22 20:18:44 +01:00
gikf
f06b56f101 fix(curriculum): improve description and tests description (#42465)
* fix: make tests descriptions more explicit

* fix: clarify function input

* fix: clarify output of function, add example
2021-06-21 13:58:11 +05:30
Kealan Parr
6c8df573c3 fix(curriculum): clarify test text for react challenge (#42577)
* Ensure the test only checks the state name variable is present, it doesn't have to be the only word

* Emphasise in the test the wording that the instructions use
2021-06-21 06:29:34 +02:00
awu43
f4b0b0b1b5 fix(curriculum): add test for event.preventDefault (#42522)
* Added note detail and event.preventDefault() test

* Replaced lookbehinds with matches

* Reverted to using \s instead of .

Now only matches if event.preventDefault() call is the only thing in the comment. This avoids matching note comments like "need to call event.preventDefault() here"

* Added optional semicolons for both comment checks

* Added trailing whitespace for line comment check

* Switched to match length checks

This should be equivalent to the two original lookbehinds

* Removed unnecessary .length check

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-18 22:05:05 +01:00
Patrick Lehmann
bc42ad1f27 fix(curriculum): add regex for comma separated const declarations (#42518)
Co-authored-by: Pat Lehmann <patrick.lehmann@homes.com>
2021-06-17 13:35:46 +01:00
lazy-geek
de4e16a676 fix(curriculum): typo in Project Euler Problem (#42539)
* fixed typo

* removed change from translation

* fixed typo only in english language
2021-06-17 08:57:57 +02:00
dogfood654
e5505cbe7b fix(curriculum): minor indentation for readability (#42451)
* Fixed minor indentation for readability

* amended to 2 indentation
2021-06-16 14:35:34 +01:00
Tom
067761f2f6 feat(curriculum): add relational databases cert as upcoming change (#41658) 2021-06-15 16:37:13 +01:00
awu43
ae0d34359a fix(curriculum): stop false positives in test for array hard coding (#42461)
* Fixed test regex to avoid false matches

* Changed regex to only match values in globalArray

* Revert non-English changes
2021-06-15 10:35:35 -05:00
Devesh Rane
dba157e7c0 Add a period at the end of an ul tag (#42483) 2021-06-15 20:44:36 +05:30
gikf
82a834af37 fix(curriculum): rework Project Euler 51 (#42459)
* fix: rework challenge to use argument in function

* fix: add solution
2021-06-15 14:32:34 +09:00
awu43
24d2555633 fix(curriculum): add await before Promise.all() (#42472) 2021-06-14 19:40:47 +01:00
Ilenia
08fc4014c7 fix(curriculum): Removing genitive from inside backticks and backticks from word own (#42466)
* inherit-behaviors-from-a-supertype put genitive outside backticks

* override-inherited-methods genitive outside backticks

* reset-an-inherited-constructor-property genitive outside backticks

* use-prototype-properties-to-reduce-duplicate-code genitive outisde backticks

* use-prototype-properties-to-reduce-duplicate-code own without backticks

* removing genitive by rephrasing

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-14 17:52:28 +02:00