532 Commits

Author SHA1 Message Date
4ff9c2a6fc feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
4cc20172c5 fix: fallback to english challenges (#45635)
* fix: fallback to english challenges

All challenges will use the english version if a translated file is not
available.  SHOW_NEW_CURRICULUM still gates what's shown in the client.

* refactor: use closures to simplify createChallenge

* refactor: remove messy destructure

* refactor: add meta via helper

* fix: fallback to [] for meta.required

* fix: repair challenge.block

* refactor: use CONST_CASE for meta + challenge dirs

* fix: catch empty superblocks immediately

* fix: clean up path.resolves

* fix: invalid syntax in JS project steps

* fix: default to english comments and relax tests

Instead of always throwing errors when a comment is not translated, the
tests now warn while SHOW_UPCOMING_CHANGES is true, so that tests will
pass while we're developing and allow translators time to work.

They still throw when SHOW_UPCOMING_CHANGES is false to catch issues
in production

* test: update createCommentMap test

* refactor: delete stale comment

* refactor: clarify validate with explanatory consts

* feat: throw if audited cert falls back to english

* fix: stop testing upcoming localized curriculum
2022-04-15 09:17:49 -05:00
c92a71e11e fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
a6d2660c7c fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00
b2c05d3c79 fix(curriculum): add removing element to the mutation test (#45581) 2022-04-05 15:59:46 +02:00
405675261d fix(curriculum): clear up confusion of array index (#45576) 2022-03-30 20:45:20 +02:00
0a3690572c fix: failing challenge test because of commented out code (#45492)
id: 587d7b87367417b2b2512b43
title: Use Arrow Functions to Write Concise Anonymous Functions
forumTopicId: 301211
dashedName: use-arrow-functions-to-write-concise-anonymous-functions

User code tests fail when seed code is left and commented out.
2022-03-29 08:36:13 -07:00
4d620dea1a fix(curriculum): allow spaces before brackets (#45494)
* chore(curriculum): update regex in use-braket-notation-* tests

Update regex used in tests, so that tests are more forgiving and spaces tolerant.

* Allow for spaces within brackets
2022-03-22 13:52:13 +01:00
d781c63fdf chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
aa7c58f7e5 fix(curriculum): add missing quotation marks (#45460) 2022-03-18 18:28:42 +01:00
ce5b9b8aba fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
dab600b4b1 chore: refactor the everything be true challenge (#45433) 2022-03-16 08:29:46 -07:00
d3304276ca fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
1c65d5d34a fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
ea416b6dc2 fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
3668422083 fix: add divider to stand in line challenge in basic javascript section (#45180)
* Fix: Update grammar in PR documnetation

* fix: add divider to stand in line challenge in basic javascript section

* Undo change outside of scope
2022-02-21 22:44:27 +05:30
6f628e6133 fix(curriculum): add test case to check country code (#45100)
* Added new test case to argument optional challenge

* Added new test case to telephone num js challenge
2022-02-18 10:09:51 -08:00
9b7d7ba716 fix(curriculum): inconsistancy on const Naming cases (#45149) 2022-02-17 11:35:16 -08:00
92778f1b2f Bugfix in typeof lesson in Javascript debugging (#45118)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Fix bug in typeof lesson in debugging javascript

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/use-typeof-to-check-the-type-of-a-variable.md

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
2022-02-16 20:14:12 +01:00
0a895dad47 fix(curriculum): make example less confusing (#45088)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-11 12:08:46 -08:00
f4077cab7f feat: added new test case to argument optional challenge (#45076) 2022-02-10 17:17:07 -06:00
9ffc7b4711 fix(curriculum): add two edge test cases to the sorted union problem (#44860)
* fix: fixed solution of sorted union

* fix: improved solution of sorted union problem
2022-02-02 19:28:31 +01:00
1c56d4cdda fix: remove double space (#44837)
* fix: typo in javascript-algorithms-and-data-structures > object-oriented-programming > understand-own-properties

* revert all the files with translations

* fix last commit error and remove changes from translated files
2022-01-19 22:19:43 +00:00
8954449625 feat: refactor the refactor challenge (#44770) 2022-01-17 09:57:15 +01:00
b2a251fff0 fix: small lint fix in challenges functions (#44728)
* fix: small lint fix in challenges functions

* Revert "fix: small lint fix in challenges functions"

This reverts commit cde43d4d86.
2022-01-10 15:57:22 -08:00
aa0ae1ae67 fix(curriculum): add a function call to seed contents (#44512) 2022-01-07 16:34:59 +05:30
5ffcd0f284 feat(curriculum): add log with function call to challenge (#44195)
* fix (Curriculum) Added a log statement

Added a log statement to the seed's content, referencing the function countOnline with a sample object as argument.
The user should be able to see the result of the function printed out on the console as soon as it is ran, and it should be easier to understand what is being outputed by the function in this challenge.

* Added examper users object
2022-01-07 14:37:02 +05:30
50b554470d fix(curriculum): wording consistency in counting-cards.md (#44390) 2021-12-08 07:32:56 -08:00
a0d3f22dfc fix(curriculum): correct grammar in description (#44194) 2021-11-18 16:07:12 +00:00
9920b7c83c fix(curriculum): point to all lines requiring change (#44056)
* fix comments for which place to edit

 solution should be placed in this line, previous comments was missleading.
as discussed in https://github.com/freeCodeCamp/freeCodeCamp/issues/44049

* shorter comments

clear of not needed ward Only

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

letter fixes

Co-authored-by: Ilenia <nethleen@gmail.com>

* fix for spelling of Change

only letter change

* fix for italian language

all other languages

* revert

revert of changes that will be done in other place

* revert

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-10-29 12:37:01 +02:00
da9e6ad0c1 fix(curriculum): consts must be initialized 2021-10-27 19:42:45 +05:30
bcc9beff1f feat(curriculum): introduce let and const earlier (#43133)
* fix: move "Explore Differences Between..." to basic JS, update seed and tests

* fix: resequence "Declare String Variables"

* fix: move "Declare a Read-Only Variable..." to basic JS, update seed and tests

* fix: revert changes to non-English "Explore Differences Between..." test text

* fix: revert test strings, solutions, and seeds for non-English challenges

* fix: update "Declare String Variables" description

* fix: sync quotation marks in description and seed

* fix: modify note in "Declare a Read-Only..." challenge

* fix: update operator and compound assignment challenges

* fix: update string challenges

* fix: update array and array method challenges

* fix: update function and scope challenges, resequence slightly

* fix: "Word Blanks" solution

* fix: add spacing to seed

* fix: concatenating += challenge spacing

* fix: appending variables to strings spacing

* fix: find the length of a string spacing

* fix: removed instances of removedFromMyArray = 0

* fix: switch challenges

* fix: function argument and param spacing

* fix: update counting cards, object challenges, and record collection

* fix: finish rest of Basic JS section

* fix: introducing else statements solution

* fix: update spacing and wording

* fix: update wording for const challenge

* fix: update functional programming challenges

* fix: intermediate algorithms and cert challenges

* fix: revert some spacing and remove comments for fp challenge solutions

* feat: add notes with links to moved let and const challenges in first two es6 challenges

* fix: update es6 intro text

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/concatenating-strings-with-the-plus-equals-operator.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/global-scope-and-functions.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/implement-map-on-a-prototype.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: concatenating strings with plus operator seed

* fix: add comments back to Declare a Read-Only Variable... seed

* feat: add es6 to basic javascript redirect tests for let and const challenges

* fix: revert "Concatenating Strings with Plus Operator" seed

* fix: move test file to cypress/integration/learn/redirects, separate redirect tests

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-10-25 17:55:58 +01:00
b36cdbafd1 chore: rename "part" to "step" (#43934)
* chore: rename part to step

* chore: update metas

* chore: more renaming

* chore: update tooling

* chore: update frontmatter

* chore(tools): title testing
2021-10-21 18:07:52 +01:00
b8b86a65b8 fix issue #42850, test for setters adding properties (#43813) 2021-10-14 15:58:13 +02:00
d3708422dd fix(curriculum): add test to check if the original variable is edited (#43791)
* fix: add test to check if variable is edited

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/remove-whitespace-from-start-and-end.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-10-09 19:45:10 +02:00
78e28e2bd3 fix: reset regex.lastIndex when tests use test method (#43695)
* added regex.lastIndex = 0 to tests

* typo
2021-10-06 16:14:50 +09:00
304f245cd2 fix(curriculum): Remove outdated video (#43685)
* Remove outdated video from testing objects for properties challenge

* Remove outdated video from testing objects for properties challenge
2021-10-02 18:51:15 +02:00
e4e74aa4f2 fix(curriculum): strip comments from code when testing (#43597)
* fix: update ES6-Compare Scopes of var and let

Fixes Issue: Adding a comment causes a valid answer to be wrong in ES6 > Compare Scopes of the var and let keywords

Fixes: #43578

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>
2021-09-29 11:13:41 +02:00
8c9ca6a2fa fix: replace JS algorithms and data structures bitly links (#41813) 2021-09-21 16:46:25 +01:00
badeb6e2df fix(curriculum): reworded grammar to do without hyphen (#43487)
Suggesting the removal of "-" on line 29 in the description, as the comma before "such" is sufficient to separate the examples from the rest of the sentence.
2021-09-18 13:13:05 +01:00
6996d54fe7 fix(curriculum): specify array is returned from the function (#43425)
* (fix)Sort an array alphabetically using the sort Method - Array is returned from the function #43417

* (mod)Curriculum - Adding explicit instructions so that function will return a sorted array #43417

* (fix)Curriculum - Correcting grammetic error in instructions #43417

* mod: updated transaltion message #43417

* fix: Curriculum - Updated grammatical error in instructions #43417

Co-authored-by: Vama Mehta <vama.mehta@inqubit.in>
2021-09-13 17:22:55 +02:00
9aea61d0df fix: conflicting info updated (#43394) 2021-09-10 15:40:39 +05:30
Tom
cfbc7e9283 fix(curriculum): console not repsonding properly issue (#43053)
* fix(curriculum): console not repsonding properly issue

* fix: refine instructions

* fix: add a test + reword to remove seed comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: remove comments from dictionary

* fix: remove comments from i18n dictionaries

* Revert "fix: remove comments from dictionary"

This reverts commit 7f76d5a8ec.

* Revert "fix: remove comments from i18n dictionaries"

This reverts commit 54b1c12cfc.

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-08-27 17:57:08 +02:00
5371af7767 fix(learn): removed space from first sentence and added instruction to basic javascript challenges (#43198)
* sheesh

* added markdown formatting to challenge

* added formatting to keep space in concatenating strings with the plus equals operator

* Delete husky.sh

* added back in italian dictionary

* removed code formatting

* updating text formatting for challenges, removed space and added instruction

Co-authored-by: Pat Lehmann <patrick.lehmann@homes.com>
2021-08-24 10:26:45 -07:00
5f57667c7d fix: clarify slice-and-splice (#43170) 2021-08-11 17:00:44 +02:00
0de2cc97db fix: remove code tags from first prototype (#43158) 2021-08-10 14:44:14 +02:00
db1a92611a fix(curriculum): repair of a small logical underdevelopment (#43116)
* repair of a small logical underdevelopment 

a> b is false if a == b

* Apply suggestions (fix small typo )

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-05 14:54:32 +02:00
a34921a5b3 fix(curriculum): add additional test case to fix hard code issue (#43086)
* fix: added additional matrix1 test case for different arguments to fix hard code issue #43050

* fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages

* Revert "fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages"

This reverts commit bbbb1c7cbc.

* fix: only simplify and reduce to 1 test case using zeroArray(4,3), reverted internationalization

* fix: removed unused matrix1 from seed and solution

* update: for better wording of the added test case suggested

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-02 12:37:50 -05:00
24250d278e feat(curriculum): rewrite capture groups description 2021-07-22 17:37:50 +02:00
b84e74ad42 fix(curriculum): improve lazy matching test regex (#42882) 2021-07-16 15:31:19 +01:00