fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge ( #41161 )
...
* fix some code tags, capitalization and punctuation
Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.
* Remove code tags and capitalize first letter
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* capitalize letter and replace slash
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-18 08:45:12 -07:00
2c1280af65
fix(learn): Improve the clarity on a challenge sentence ( #41154 )
...
* Improve the clarity on a challenge sentence
* add string type and remove double quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-18 08:29:31 -07:00
1fe1371b16
add missing inline-code block ( #41153 )
2021-02-17 11:24:53 -08:00
b45406ec9d
fix(learn): Remove repeated definition tag in challenge ( #41151 )
2021-02-17 23:01:42 +05:30
c15c27f474
fix(learn): Added another test to check for invalid characters ( #41144 )
2021-02-17 21:16:07 +05:30
21c7abf584
fix(learn): update challenge for crowdin ( #41089 )
2021-02-16 19:47:40 +05:30
0f8449788c
feat(learn): add tests to use a callback function in the sort method ( #40847 )
2021-02-10 17:05:23 +05:30
51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge ( #40901 )
...
* fix: regex-criminal-in-hunt-challenge
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-08 06:10:59 -08:00
18e821bcd3
fix: remove clunky sentence ( #40751 )
2021-02-01 19:22:39 +05:30
d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter ( #40725 )
...
* fix: clarify test description
* fix: improve wording regarding rest parameters syntax
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: improve with better sounding wording
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-01-24 08:30:13 -08:00
ce3a20e552
fix(learn): change requirements for positive and negative lookaheads ( #40570 )
2021-01-21 15:35:19 -06:00
f2b1d7b147
fix(challenge): Assert arrays contain expected values ( #40693 )
2021-01-21 10:52:52 -08:00
8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md ( #40478 )
...
* Spelling change in count-backwards-with-a-for-loop
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-01-21 08:44:10 -08:00
062b1cd424
fix: replace h tags ( #40750 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-01-21 13:41:46 +05:30
ef394093f7
fix(learn): removing unnecessary test case for regex challenge ( #40581 )
...
Co-authored-by: Alejandro Soto <alejandro.soto@wundermanthompson.com >
2021-01-20 21:53:04 -08:00
3061a5a0eb
Text in Basic Data Structures lesson is better clarified. ( #40492 )
...
* text_changes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-01-20 22:02:37 -07:00
d6e47037de
fix(learn): tests of the for in issue regarding the curly braces ( #40344 )
...
* fix: fix the regex of the test of the challenge
* fix: fix data structure challenge
* fix: fix data structure challenge
* fix:fix the test regex of the challenge
* fix: fix the test regex
2021-01-20 21:50:44 -07:00
8e96fef862
fix(learn): Updated instructions for challenge solution for Reuse Patterns Using Capture Groups ( #40658 )
...
* Grammatically updated the instructions for the challenge
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/reuse-patterns-using-capture-groups.md
Co-authored-by: Eric Leung <eric@erictleung.com >
Co-authored-by: Eric Leung <eric@erictleung.com >
2021-01-20 19:39:23 -08:00
8d8d25e9f2
fix(learn): address escaped backticks ( #40717 )
...
* fix(learn): address escaped backticks
Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash. In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.
This issue came to light due to a bug in the translation flow on
Crowdin.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: EVEN MORE :( :( :(
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: backslash nightmares
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: When you wish upon a *******
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix(curriculum): md error introduced by formatter
* fix(curriculum): remove extra `s
* fix: restore quote symbol
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: Typo
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: apply review changes
Applying review feedback from call with @RandellDawson.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: markdown does weird stuff sometimes
Can't stick backticks together - use code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2021-01-20 19:01:00 -07:00
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese ( #40683 )
...
* feat(tools): add seed/solution restore script
* chore(curriculum): remove empty sections' markers
* chore(curriculum): add seed + solution to Chinese
* chore: remove old formatter
* fix: update getChallenges
parse translated challenges separately, without reference to the source
* chore(curriculum): add dashedName to English
* chore(curriculum): add dashedName to Chinese
* refactor: remove unused challenge property 'name'
* fix: relax dashedName requirement
* fix: stray tag
Remove stray `pre` tag from challenge file.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-12 19:31:00 -07:00
7de8549e02
fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too ( #40465 )
...
* made valid solution dot inside and dot outside quotes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-12-16 08:07:47 -08:00
7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 ( #40409 )
...
* [BUG] #40406 Fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md
Requested Change.
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-12-15 18:07:36 -07:00
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
f294d9cacc
fix(learn): removed use strict from various challenges ( #40321 )
2020-11-25 15:59:04 -08:00
7ce8c58709
Put value into quotes ( #40172 )
...
* Put value into quotes
It can be missunderstanding that "value" is a string!
* fix: remove quotes from inside code tags
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-25 16:32:14 -06:00
49f6875db5
fix(learn): ES6 Getters + Setters tests ( #40238 )
...
* Strengthen tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Improve verbiage
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Add second check to setter test
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 14:22:44 -08:00
df44da9dc2
fix(challenge): correct terminology and inform of correct array copying ( #40045 )
...
* fix(challenge): correct terminology and inform of correct array copying
* fix(challenge): update text with proposed changes
2020-11-25 08:14:33 -08:00
bce3d5b372
fix(learn): remove white space for quick fix ( #40231 )
...
* fix(learn): remove white space for quick fix
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-20 09:21:21 +01:00
e8b6a9e5dd
fix(learn): add example declaration for clarity ( #40207 )
...
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
895e6b8daf
fix(learn): add test to prevent hardcoded pass ( #40179 )
2020-11-06 17:05:20 +00:00
1badd3c3a6
fix(learn): add test case to regex challenge ( #40087 )
...
existing test cases can be satisfied by /^[a-z][a-z]+$|^[a-z][a-z]*\d\d+$/i
2020-11-01 13:24:35 +00:00
fb0812b6d2
fix(learn): added description about a nonallowed method ( #40121 )
2020-10-31 20:01:03 +01:00
8ceae38730
fix(learn): modified usage of words from argument to parameter based on the title ( #40130 )
2020-10-31 19:59:43 +01:00
35c4020f4d
fix(curriculum): test typos ( #39984 )
2020-10-15 14:49:57 -04:00
cc464a6e56
fix(learn): Possible semantic error in explanation comment ( #39813 )
...
* Possible semantic error
"identical" generally means that both variables are linked to exact same array which is not the case:
``` thisArray !== thatArray ```
Maybe "similar" or other word could be used instead
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/copy-an-array-with-the-spread-operator.md
Made the comment more accurate
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-10-14 19:53:49 -06:00
e2ae6303d5
fix(learn): Implement map and filter ( #39621 )
...
* Added changes to implement-filter-method challenge as requested in reviews by Randall D and moT01
* Added changes requested for in code review
2020-10-14 10:33:43 -06:00
a71150074d
fix(learn): preserve whitespace in the tool panel ( #39973 )
2020-10-14 21:40:15 +05:30
10d3126383
fix(learn): correct minor grammar mistake ( #39915 )
2020-10-13 12:14:49 +01:00
a32427c120
fix(learn): make semicolon at end of line optional ( #39821 )
2020-10-08 21:02:59 +01:00
94f0cf0ef8
chore(learn): Remove remaining isHidden keys from frontmatter (English and Chinese challenges) ( #39809 )
...
* fix: remove isHidden key from tool template
* fix: removed isHidden key from English challenges
* fix: remove isHidden key from Chinese challenges
2020-10-08 14:18:47 +02:00
2b9e38a17b
fix: replace .english.md extension with .md
2020-09-29 22:09:04 +02:00
362e8254f8
fix(learn): update test to allow negative arguments ( #39701 )
...
* Updated the regex in test
* Changed regex
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Updated changes in regex
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-09-28 16:03:24 +01:00
104a8068e3
fix(learn): in ES6 spread operator challenge test for arr2 length > 0 ( #39680 )
...
* fix(learn): in ES6 spread operator challenge test for arr2 length > 0 too
Fixes #39662
* Accept correction
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
2020-09-24 16:14:44 -07:00
6ccd0d21a1
fix(learn): Update test text in Profile Lookup ( #39678 )
2020-09-25 00:38:40 +05:30
a86b220eb7
chore: remove isRequired from curriculum files
2020-09-21 20:51:46 +05:30
d8e8da36a0
Fixed tests for JS Basic Algorithms: Slice and Splice challenge as suggested in issue #39560 ( #39610 )
2020-09-18 11:30:56 -07:00
d5000b5d0f
Removed note about promise chaining as suggested in issue #39487 ( #39609 )
2020-09-18 10:30:37 -05:00
a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson ( #39587 )
2020-09-17 13:00:58 -05:00
80438cac3e
feat(client, learn): add helper functions for common validation operations ( #38605 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-09-17 19:38:01 +05:30
30c61b808b
fix: consolidate misc comments ( #39583 )
2020-09-16 13:29:50 -05:00
