1727 Commits

Author SHA1 Message Date
Randell Dawson
1cb6092dd9 fix: performed first conversions 2019-05-07 10:43:43 -07:00
RIHANE ZAKARIA
a40451feaa Define the Head and Body of an HTML Document for challenge solution (#35826)
* Define the Head and Body of an HTML Document for challenge solution

* edit on check the body tag contain h1 and p tags
2019-05-06 16:44:57 +02:00
Oliver Eyton-Williams
cde8035b79 fix: add test for and slight rewrite to hazards of imperative (#35331)
* fix: add test for and slight rewrite to hazards of imperative

* fix: Resolve merge conflict

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: Make the only mistake in seed the use of splice
2019-05-06 07:27:38 -05:00
Randell Dawson
a092c76688 fix: added 22 missing solutions (#35747) 2019-05-03 12:05:26 +02:00
The Coding Aviator
79b5749c57 curriculum: Change pre and code to blockquote in Advanced Node and Express challenges (#35713)
* curriculum: Change pre and code to blockquote in Advanced Node and Express challenge
2019-05-02 12:19:07 +02:00
Manish Giri
b579317e11 fix(curriculum): Add solutions to Bootstrap challenges (#35789)
* fix(curriculum): Add solutions to Bootstrap challenges
2019-05-02 11:24:38 +02:00
Valeriy
5edaee4269 fix(curriculum): throws is not defined 2019-05-02 01:01:00 -07:00
Randell Dawson
f51f262104 fix(curriculum): Increased starting font size to fix a bug on Chrome browser for Sass Apply a Style Until a Condition is Met with @while challenge (#35935)
* fix: increased starting font size for Chrome

* fix: slight verbiage change

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix/remove-extra-space
2019-05-01 09:08:38 -05:00
Randell Dawson
409aa30b0a fix(curriculum): add new test to use calculated space for Use grid-column to Control Spacing challenge (#35893)
* fix: use calculated space for test

* fix: reworded comment

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: changed After Test to Before Test

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-01 14:08:35 +05:30
Randell Dawson
365ce2ddc7 fix(curriculum): Added test and corrected solution for Restrict Possible Usernames challenge (#35847)
* fix: added test and corrected solution

* fix: removed redundant regex

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-30 20:40:38 -05:00
Randell Dawson
3bff4151cf fix: rewrote challenge instructions and tests (#35899) 2019-04-30 20:19:06 -05:00
Randell Dawson
7d7a1127a7 fix: remove comments before tests (#35906) 2019-04-30 19:26:07 -05:00
Randell Dawson
66398a9300 fix(curriculum): Improved the tests for Find the length of a String challenge (#35940)
* fix: split tests into two requests

* fix: removed typeof number check

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove unneeded After Test section
2019-04-30 19:12:22 -05:00
Oliver Eyton-Williams
e3529a8449 fix: Add solutions for Sass challenges (#35777) 2019-04-30 18:55:22 -05:00
RIHANE ZAKARIA
6630b2be7a bug fix / test of Spread Operator javascript challenge / english (#35856)
* bug fix test with the Spread Operator

* test of Spread Operator javascript challenge / english / change test and add a helper function
2019-04-30 18:37:26 -05:00
The Coding Aviator
a2a278e937 fix: Moved instruction to proper place and removed assert text in Font Awesome challenges (#35928)
* fix: Moved instruction to proper place and removed assert text

* Add suggestion about making note strong

Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
2019-04-29 15:51:03 +02:00
Manish Giri
1015f1ec6e fix(curriculum): Add solution to jQuery challenges (#35776) 2019-04-28 12:28:47 -07:00
Huyen Nguyen
5b32e98c4a fix(curriculum): Add solutions to Applied Visual Design challenges (#35815)
* fix: add solutions to Applied Visual Design challenges

* fix: remove extra opening style tag
2019-04-28 13:13:38 -05:00
Tina Wang
bc986a4728 Moved font-awesome challenges to Font Awesome v5.8.1 (#35813)
* update font awesome challenge to font awesome 5

* v5 syntax changed
2019-04-28 15:00:27 +05:30
Randell Dawson
102c2b829a fix: added 15 missing solutions (#35745) 2019-04-28 14:31:14 +05:30
Aly Pilkons
dae22c95c3 Edit Instructions Text To Make Goal Clearer (#35887)
* Edit Instructions Text To Make Goal Clearer

The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.

* Updated commit based on comments
2019-04-26 18:33:04 +05:30
Ian Effendi
cf86246866 fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 (#35809)
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
BSi
f8555c2f8b Added the semicolon in the example provided (#35898) 2019-04-23 19:26:50 -04:00
Manish Giri
722b65d80f fix(curriculum): Add solutions to HTML challenges (#35766)
* fix(curriculum): Add solutions to HTML challenges

* Remove extra anchor element
2019-04-22 11:37:05 +05:30
Fordco
5fb179a6ef fix: missing ! in final test case. Fixes issue #34725 (#35033) 2019-04-22 11:31:17 +05:30
Manish Giri
e736179720 fix(curriculum): Add solutions to CSS challenges (#35873) 2019-04-22 11:27:43 +05:30
Catalina
ffcb092bf1 Fixed CSS Challenge English version (#35849) 2019-04-20 09:49:23 -07:00
Tom
f1bcd5f0de fix/add-full-solutions-to-flexbox (#35760) 2019-04-20 09:45:18 -07:00
ranched
9899035f34 fix(cirriculum): Expand instructions for Chai Assertion challenges (#35724)
* Expand instructions for Chai Assertion challenges

* Seperate instructions/descriptions and remove some quotes

* Add detail to descriptions in truthiness and isOk challenges

* Update formatting in instructions
2019-04-19 18:34:53 +05:30
Randell Dawson
54bc113721 fix(curriculum): Added 9 missing solutions to challenges in the Debugging section (#35750)
* fix: add 9 solutions to challenges

* fix: remove extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-19 00:14:20 +05:30
Astrid
9ee8b4fa57 fix: minor grammar mistake in 'applied visual design' challenge (#35839)
fix: revert changes to package-lock.json
2019-04-15 14:05:30 +05:30
Beau Carnes
63fc21f702 Update videoURL for HTML5 Elements challenge (#35802) 2019-04-14 09:20:36 -07:00
Benjamin Herrchen
20f71fd22e correct usage of Math.random() to give equal 50/50 results (#35840)
* Update render-conditionally-from-props.english.md

* Update render-conditionally-from-props.english.md
2019-04-13 18:06:01 -04:00
Paul Gamble
bddcda5559 added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element (#35516)
* added html solution for testing

* fix: corrected invalid solution
2019-04-12 18:17:12 +02:00
Aditi Joshi
ebdd8632fc Fix/update challenges for responsive-web-design-principles (#35804)
* Fix/update challenges for responsive-web-design-principles

* fix/update fix some minor mistakes

* fix/update remove extra line

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md

Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md

Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
2019-04-10 17:26:56 -04:00
Beau Carnes
7e522dc473 fix: add new scrimbas (#35803) 2019-04-10 09:23:12 -07:00
Ian Effendi
f74d507434 fix(curriculum): replace js with full solution in accessibility challenge (#35810)
* fix(curriculum): add full, working solution for accessibility challenge.

This commit replaces a JavaScript only solution where a full, working
solution should have been written.

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md

Co-Authored-By: rimij405 <effendiian@gmail.com>
2019-04-10 17:55:16 +02:00
Randell Dawson
6a859ee7f9 fix: added 12 missing solutions to Basic Data Structure Challenges (#35744) 2019-04-10 21:03:15 +05:30
Guayo Mena
75293e649d fix(curriculum): Fix test in Javascript challenge (#35795)
Fixes #35793

I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?

Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
2019-04-10 20:55:05 +05:30
lasjorg
394ae3d1ce fix(challenge): check for li and specify elements accepting text (#35193)
* fix(challenge): check for li and specify elements accepting text

* fix(challenge): revert text

* fix(challenge): remove word added by mistake

* fix(challenge): update test, cleanup assertion text
2019-04-10 20:52:37 +05:30
Manish Giri
9b9a96234f fix(curriculum): Add solutions to responsive web design principles (#35761) 2019-04-10 07:57:14 -07:00
Randell Dawson
42bc9fa9b6 fix(curriculum): Made tests not accept invalid HTML (#35774)
* fix: made tests stricter

* fix: simplify text

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-10 19:21:52 +05:30
Randell Dawson
d5798c38de fix: rewrite of word blanks challenge (#35779) 2019-04-10 01:48:01 -04:00
Kyle Scheuerlein
f590fecb34 Update reduce-repetition-using-the-repeat-function.english.md (#35787) 2019-04-08 20:09:26 +05:30
Manish Giri
c27dc72e4d fix(curriculum): Improve Array Sort Challenge (#35756)
* fix(curriculum): Improve Array Sort Challenge

* Update note to include in challenge description

Co-Authored-By: Manish-Giri <manish.giri.me@gmail.com>
2019-04-07 13:42:38 +05:30
lasjorg
f91dea9b5c fix(challenge): update text to give an explanation of wrapping (#34811)
* fix(challenge): update text to give an explanation of wrapping

* fix(challenge): simplify challenge text

* fix(challenge): update challenge text add solution

* fix(challenge): remove line breaks

* fix(challenge): make second instruction more clear
2019-04-04 22:49:21 -04:00
chaomt
216e10e2b7 fix: A testing bug in FCC's React Simple Counter Challenge (#35715) 2019-04-03 22:24:05 -05:00
Roberto Ruccia
91f4865ab4 Fix typo in curriculum/challanges/english/01-responsive-web-design/applied-visual-design/use-the-css-transform-scale-property-to-scale-an-element-on-hover.english.md (#35743) 2019-04-02 21:43:27 -04:00
Kristofer Koishigawa
095188215f fix(challenges): Regex Asterisk Challenge (#34800)
* fix(challenges): Fixes description and adds tests to close #17872.

* fix(challenges): Removed unnecessary string arguments from testString

* fix: improved challenge instr and tests
2019-04-01 19:19:13 +05:30
Илья
a326c2cf9a Make a comparison in the test more accurately (#35500)
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md

* refactor:  fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)

Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
2019-04-01 10:55:43 +02:00