Commit Graph

25156 Commits

Author SHA1 Message Date
9a97d639f5 fix: add dynamic output for legacy challenges
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-19 22:23:57 +05:30
64fcbbb491 fix: output console.logs as user types (JS) 2019-11-19 22:23:57 +05:30
29641986ab fix: output console.logs as user types (DOM)
Any console.logs inside script tags will be written to the fcc console
as the user types.  DOM challenges only.

Also, DRYed out the main and test frame creation.
2019-11-19 22:23:57 +05:30
6acab90cb6 fix: report user code evaluation errors
Errors thrown during evaluation of the user's code will now be reported.

JavaScript challenges will only report to the browser console and only
during testing.

DOM challenges will report to the browser console during testing and as
the user types, but only report to the fcc console during testing
2019-11-19 22:23:57 +05:30
5059d23600 fix: report all build errors to the fcc console
Previously only challenges with previews would inform the user of syntax
errors.  This extends that to all challenges and corrects the output
format so errors are clearer.
2019-11-19 22:23:57 +05:30
890ce894cc fix: correct typos in incidence matrix instruction (#37779) 2019-11-18 16:34:23 -08:00
73943994ff Update add-font-awesome-icons-to-our-buttons.english.md (#37667)
Correct typo in instructions  -- says to add the "fa" class instead of the "fas" class.
2019-11-17 07:55:39 -08:00
fc1a923dd5 Made description of logical operator under "or operator" challenge a little more intuitive. (#37772)
* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md
2019-11-16 21:30:52 -05:00
Tom
5ca2d2467a fix: make help button use subforum topics (#37741)
* fix: make help button use subforum topics

* fix: add test to check that block exists

Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: improve error message

* Update curriculum/test/test-challenges.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
07b74ab70b Improved translate russian language (#37647) 2019-11-15 22:36:52 +05:30
39df6a2b56 fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute (#37699)
* fix: added new test to test href attribute

* fix: changed You to Your

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed a to an

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-15 10:14:54 -06:00
1fb202b742 fix(curriculum) - Add class box in json apis and ajax (#37725)
* Add class box in json apis and ajax

* Remove .box in id & add .box in seed code
2019-11-15 08:56:28 +01:00
687c4fdb98 fix(client): add cache-busting hashes to chunks (#37746)
* fix(client): add cache-busting hashes to chunks

* fix: create cache-busting names for the workers

Prior to this PR the first webpack compilation gave the workers static
names.  This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.

In order for Gatsby to find them, the names are added to the
config directory.
2019-11-15 01:43:44 +05:30
c4dc0b297f Switch statement example updated (#37757)
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00
2d647b1638 fix: reword devops guide (#37759) 2019-11-14 23:58:45 +05:30
c5d4bedda5 feat: add accessibility toggle
Users can now press ctrl/cmd+f1 to toggle the screen reader mode, in
addition to using the accessibility tooltip.  The mode now persists
between challenges.

If screen reader mode is on, the instructions are focused by default so
the user is not required to navigate to them before reading starts.
2019-11-14 22:17:13 +05:30
265e383705 fix: allow username submission after failure
If the server rejects a username submission, the submit button became
stuck as disabled.  This ensures that new (valid) input will unlock the
button.
2019-11-14 22:16:24 +05:30
e1236a0c15 refactor: use validate util in client 2019-11-14 22:16:24 +05:30
e77408827a feat: add server-side username validation 2019-11-14 22:16:24 +05:30
7500c370b6 refactor: create common validation function 2019-11-14 22:16:24 +05:30
55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715)
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-13 14:39:03 -06:00
376b42637a Updated file names required in the challenge (#37737)
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
2019-11-11 22:04:38 -05:00
e169779805 fix: update twitter image URL (#37739) 2019-11-12 02:32:17 +05:30
2c5453e3bd Clarify instructions (#37735)
Closes #37734
2019-11-11 16:48:51 +01:00
385287838e fix(curriculum) - fixed function keyword not misspelled in debugging guide (#37711)
* [ FIXES ] - fixed function keyword not misspelled

* Update client/src/pages/learn/javascript-algorithms-and-data-structures/debugging/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added comment back into example code
2019-11-11 07:37:11 -06:00
Tom
6ff5e52b2d Improve viewport unit readability (#36673)
* Improve viewport unit readability

Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
2019-11-11 10:24:02 +01:00
67e0f33a89 feat: Add Solution to handle click event - English (#37069) 2019-11-11 09:19:28 +01:00
f3ee4f85ae Changes to "access-array-data-with-indexes.english" challenge description (#37730)
* edited description to be a little more clear on how to access elements in an array through indeces

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
84d683940a docs: improving spanish translations (#37593) 2019-11-10 10:42:27 -08:00
fb551cb23c Improve Korean translation and change wording (#36973)
* Fix typo in CONTRIBUTING.md

Remove spacebar and enable markdown

* Retranslate CONTRIBUTING.md in Korean

- Retranslate CONTRIBUTING.md (updated version) in Korean
- Correct an error in translation
- Make expressions more clear and friendly

* Change wording to more friendly one
2019-11-10 04:34:58 -08:00
5296d5c731 fix: removed trailing spaces, fixed a typo (#37572)
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00
7639306a20 doc: improved readability and added port validation (#37614)
Provided updates for better overall readability.  Added a section for validating whether port 3000 is already in use on Windows and MacOS.
2019-11-10 04:29:30 -08:00
c5098e9fc9 docs: fix a few typos in French guidelines (#37628)
* Fix a few typos

One missing s for a plural word and a few missing spaces.

* Fix one typo
2019-11-10 04:27:33 -08:00
26e857b6ab fix: update JavaScript capitalization (#37466) 2019-11-10 04:24:34 -08:00
e1a1ed5c12 fix(client): use JSON.stringify replacer function for NaN (#37684) 2019-11-10 04:17:18 -08:00
32954923e1 fix: Read-Search-Ask link on Frontend-Libraries projects (#37710) 2019-11-10 04:16:18 -08:00
9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726)
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
2019-11-09 18:13:10 -05:00
8107106915 fix(donate): quick patch for auth 2019-11-09 11:39:29 -08:00
139f8fcb1b chore: remove poweredByStripe asset 2019-11-09 11:39:29 -08:00
4cd5542489 feat(donate): two col layout checkout page 2019-11-09 11:39:29 -08:00
7a4e84d163 chore(donate): remove donate page tests
Removed the donate page tests, which seemed weirdly depending on
the rendered tree. Unreliable at the best.

We sould be adding comprehensive tests to the components instead.
2019-11-09 11:39:29 -08:00
83ac3c5f95 chore(donate): remove unused donate modal wiring
This commit removed the donate modal and related wiring,
although some of the state mapping is still around.

The remaining state mapping can either be removed, or kept
for now, because it will be replaced as is for the newer
motivation based donation prompts
2019-11-09 11:39:29 -08:00
a36e0d8351 [ImgBot] Optimize images (#37723)
*Total -- 50.98kb -> 38.49kb (24.51%)

/client/src/assets/images/square_puck.png -- 25.51kb -> 13.31kb (47.81%)
/client/src/assets/images/freeCodeCamp-404.svg -- 25.47kb -> 25.17kb (1.17%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2019-11-09 01:33:48 -08:00
ccd135f268 feat: update logo (#37716)
* feat: update logo

* fix: adjust logo height
2019-11-09 01:31:49 -08:00
bdae7343bb escaped backslash character on line 22 (#37721)
Previously only showed empty parentheses.
2019-11-08 23:25:48 -05:00
00914be3e8 Removed text about prior knowledge (#37722)
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
2019-11-08 22:03:44 -05:00
94532f98db refactor(tests): enzyme => react-testing-library (#37712)
* refactor: 💡 rewrite enzyme tests in react-testing-library

* fix: 🐛 remove enzyme imports from frame-runner.js

* chore: 🤖 install and add enzyme imports to frame-runner.js back
2019-11-08 16:50:25 +05:30
5ae8470bd5 fix: changed container to container2 (#37483) 2019-11-07 21:15:38 -05:00
2287d73b4f fix missing closing brace and bracket for promise (#37474)
There was a missing closing brace, bracket and semi-colon for the constructor new Promise in its definition
2019-11-07 19:24:54 +01:00
647945f4ac fix: duplicated 'use' in set-up-passport.english.md (#37134) 2019-11-07 18:42:34 +01:00