Commit Graph

2762 Commits

Author SHA1 Message Date
camperbot
0654bd92b0 chore(i18n,curriculum): update translations (#43881) 2021-10-18 08:17:43 -07:00
Renovate Bot
9ddb30b92d chore(deps): update dependency mocha to v9.1.3 2021-10-15 09:31:57 +00:00
Shaun Hamilton
4a605c5cd2 feat(curriculum): add registration form practice project (#42876)
* feat(curriculum): add registration-form practice project

* add parts 001-006

* add parts 007-009

* add parts 010-013

* add parts 014-024, fix 013

* add parts 025-043

* add parts 043-046

* add parts 0047-057 without tests

* fix tests and adjust index.md file I do not understand

* add css tests to parts 037-040

* add tests parts 040-057

* remove space around ERM

* add true assertion until document iframe is fixed

* add critical review suggestions

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* use clear, Tom-like language for 038

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* change order to match author's age

* apply suggestions with personal pazzaz

* add that thing Nich forgets

* use innerText

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-10-14 15:33:13 -07:00
Eric Cheng
de422fe365 fix: change phrasing in challenges to make it easier to read (#43732)
* refactor: made instructions incurriculum\challenges\english\01-responsive-web-design\applied-visual-design\use-the-strong-tag-to-make-text-bold.md a little more clear to user

* refactor: changed phrasing in instructions in curriculum\challenges\english\01-responsive-web-design\applied-visual-design\use-the-s-tag-to-strikethrough-text.md to make it slightly easier to read and less verbose

* refactor: fix phrasing in curriculum/challenges/english/01-responsive-web-design/applied-visual-design/use-the-s-tag-to-strikethrough-text.md

* fix: streamline phrasing according to requested changes

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: change phrasing according to requested changes

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2021-10-14 15:54:39 -05:00
Krzysztof
07eb99e57c fix: remove pretest for full-output (#43655) 2021-10-14 12:23:45 -07:00
GabeNedden
f3e1c59c92 fix(curriculum): Add Privacy Consideration note (#43779)
* Add Privacy Consideration note to Stock Price Checker challenge

* remove link to external GDPR site

* Improve wording

* Update curriculum/challenges/english/09-information-security/information-security-projects/stock-price-checker.md

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2021-10-14 14:28:03 +00:00
Jeremy L Thompson
b8b86a65b8 fix issue #42850, test for setters adding properties (#43813) 2021-10-14 15:58:13 +02:00
camperbot
7dc9af5ce5 chore(i18n,curriculum): update translations (#43846) 2021-10-13 08:28:11 -07:00
Oliver Eyton-Williams
22afdd1aad fix: stop modal appearing in steps (#43728)
* fix: stop showing completion modal on steps

* feat: submit steps with ctrl+enter

* fix: handle ctrl+enter when not focussing editor

* fix: reset tests when user types

* refactor: pass showCompletionModal as an option

Otherwise we have to write executeChallenge(true) which does not mean
what you might reasonably expect.

* fix: always executeChallenge when not on step

* fix: update frontend project show

* fix: handle missing payload

* refactor: isProjectStep -> hasEditableRegion

* refactor: more renaming

* fix: make meta.json control multifile editor use

* fix: update the challengeSchema correctly

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: remove logging

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-10-13 14:47:59 +03:00
camperbot
4d8784291e chore(i18n,curriculum): update translations (#43812) 2021-10-12 17:20:30 +02:00
Pranav Joglekar
d947d8c975 fix: add test to ensure the innerText of labels doesn't change (#43803)
For the check-radio-buttons-and-checkboxes-by-default exercise,
campers are able to pass the exercise if the checked attribute is
written in an incorrect syntax. This PR checks the innerText of the
elements which are being added the 'checked' attribute and ensures that
their value doesn't change.
Fixes #43750
2021-10-11 21:21:30 +02:00
camperbot
bdd33a5fe7 chore(i18n,curriculum): update translations (#43795) 2021-10-10 22:18:16 +02:00
Prathamesh Gawas
d3708422dd fix(curriculum): add test to check if the original variable is edited (#43791)
* fix: add test to check if variable is edited

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/remove-whitespace-from-start-and-end.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-10-09 19:45:10 +02:00
camperbot
dfe45bcc8e chore(i18n,curriculum): update translations (#43776) 2021-10-08 14:51:42 +01:00
camperbot
ff58255b26 chore(i18n,curriculum): processed translations (#43760) 2021-10-07 21:38:50 +05:30
Renovate Bot
536eef3be9 chore(deps): update babel monorepo to v7.15.8 2021-10-06 23:33:34 +00:00
camperbot
e6b3c90983 chore(i18n,curriculum): update translations (#43746) 2021-10-06 17:36:48 +02:00
Oliver Eyton-Williams
c8d7f0a782 feat(tools): remove eslint-plugin-prettier for prettier (#42438)
* feat: remove eslint-plugin-prettier for prettier

This removes the annoying lint warnings when all that needs to change is
formatting

* fix: use .js lint-staged config to ignore properly

* fix: lint everything if a lot of files are changed

It's faster than making lots of individual linter calls

* chore: apply prettier

* fix: ignore code in curriculum-file-structure
2021-10-06 21:02:21 +05:30
Ilenia
78e28e2bd3 fix: reset regex.lastIndex when tests use test method (#43695)
* added regex.lastIndex = 0 to tests

* typo
2021-10-06 16:14:50 +09:00
Ngoako Ramokgopa
ce249f9625 fix: link to react documentation (#43704)
* Update set-state-with-this.setstate.md

revert the base url back to https://facebook.github.io/react/docs/state-and-lifecycle.html

* Update use-proptypes-to-define-the-props-you-expect.md

Linked to the exact place for the types of propTypes you can use. The original link was to the documentation, which states that it has been moved, So I thought it would be intuitive to link the exact place React wants you to go.

* Update curriculum/challenges/english/03-front-end-development-libraries/react/use-proptypes-to-define-the-props-you-expect.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/03-front-end-development-libraries/react/set-state-with-this.setstate.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-10-04 18:51:29 -05:00
camperbot
aae7b7bca0 chore(i18n,curriculum): processed translations (#43713) 2021-10-04 16:27:38 +02:00
Eric Cheng
2ba536d559 refactor: enforce consistent camelCase in const names, add comments, condense multiple single-line comments into one multi-line comment (#43699) 2021-10-04 19:15:44 +05:30
camperbot
504ed3a917 chore(i18n,curriculum): update translations (#43661) 2021-10-03 20:24:27 +01:00
Riadh Laabidi
304f245cd2 fix(curriculum): Remove outdated video (#43685)
* Remove outdated video from testing objects for properties challenge

* Remove outdated video from testing objects for properties challenge
2021-10-02 18:51:15 +02:00
Oliver Eyton-Williams
e4ba0e23ea feat: enable reset in multifile editor (#43617)
* feat: dispatch resetChallenge action

* fix: copy challengeFiles instead of in-place sort

* fix: handle null updateFile payloads in redux

* refactor: reorganise region initialization

* refactor: pull code into editorDidMount

Then we can rely on the presence of the editor and monaco and don't have
litter the code with null checks.

* refactor: use better name for editable region init

* refactor: remove unused decoration

* refactor: rename forbidden region init functions

* fix: keep all challengeFiles when resetting

* refactor: remove unused decoration class

* fix: reinitialize editor on reset

* fix: stop adding multiple scroll listeners

Since the challengeFile update on each keystroke extra (unnecessary)
adding of listeners slowed the editor to a crawl.

* fix: only scroll to editor on mount

Rather than on any edit.

* refactor: remove logs and comments

* fix: rename toSortedArray and fix broken test

* fix: check for null not falsy in updateFile

* fix: only update project features when project

* fix: only reset if editor contents have changed

* feat: focus on editor after reset
2021-10-01 10:36:20 +02:00
Hankai Xia
cf88dfd3ce fix(curriculum): Fix a typo in "Problem 141: Investigating progressive numbers, n, which are also square" (#43647) 2021-10-01 08:02:13 +02:00
miyaliu666
3ea2fe4f77 feat(i18n,curriculum): add Bilibili ids for Chinese (#43564)
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-10-01 09:54:12 +05:30
Dharmin K Shah
f9e35a0e6c fix(curriculum): Remove videoUrl using old image srcs (#43631)
* fix: replace responsive web dev bitly links

* Revert "fix: replace responsive web dev bitly links"

This reverts commit 3d2bcbef4b.

* fix: remove video url from html challenges using old image srcs
2021-09-30 19:13:43 +04:00
camperbot
b38ddc0fd6 chore(i18n,curriculum): update translations (#43633) 2021-09-30 16:29:50 +02:00
bkelley361
b153745362 fix(links): Fixed 4 files with broken links (#43618) 2021-09-29 23:07:45 +01:00
camperbot
c1faed1635 chore(i18n,curriculum): update translations (#43615) 2021-09-29 15:15:14 +00:00
prashantaghoshal
e4e74aa4f2 fix(curriculum): strip comments from code when testing (#43597)
* fix: update ES6-Compare Scopes of var and let

Fixes Issue: Adding a comment causes a valid answer to be wrong in ES6 > Compare Scopes of the var and let keywords

Fixes: #43578

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>
2021-09-29 11:13:41 +02:00
Shaun Hamilton
2deb73c8d1 feat(curriculum): add accessibility-quiz practice project (#43244)
* feat(curriculum): add accessibility-quiz practice project

* add parts 002-006

* add parts 7-8, tentative on logo aspect-ratio

* add parts 008-013

* add parts 013-016

* add parts 017-026

* add parts 026-027

* add parts 027-029

* add parts 029-044

* add parts 044-067 - all parts done

* add tests 001-009

* add tests 010 - 033

* add tests 034 - 039

* update tests 008~033, add tests 040-050

* add all tests

* fix some stuff, remove final.md

* take reasonable suggestions from Nich, ignore rest

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* replace svg link with actual CDN

* remove getAttribute in potentially bad places

* add method to form

* fix silly querySelectors

* adjust selectors for 028

* fix selectors, and add color transformations

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

* fix: typos, and make one test lenient

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-09-28 15:38:44 -05:00
camperbot
26c6300743 chore(i18n,curriculum): update translations (#43595) 2021-09-28 17:22:14 +02:00
camperbot
eac0a395a1 chore(i18n,curriculum): update translations (#43583) 2021-09-27 18:10:31 +01:00
Oliver Eyton-Williams
2b6bef08ae feat: localize videos (#42869)
* refactor: separate out VideoPlayer component

* feat: support bilibili videos

* feat(client): allow localized videos to be shown

* fix: remove add subtitles CTA

* feat: add locale ids for Why Program?
2021-09-27 12:26:38 +03:00
Ilenia
00a81067a3 chore(curriculum): changed external links to news articles in 4 challenges (#43373)
* changed 4 links

* fix wording

* change link as suggested by @gikf
2021-09-27 09:12:53 +01:00
Ikko Ashimine
6d19fec884 fix(curriculum): typo in word-frequency.md (#43571)
occurences -> occurrences
2021-09-26 17:11:25 +02:00
camperbot
1f842f04ee chore(i18n,curriculum): update translations (#43569) 2021-09-25 18:15:05 +01:00
Renovate Bot
acba4f7b00 chore(deps): update dependency mocha to v9.1.2 2021-09-25 12:07:51 +00:00
Tom
160931cd6a fix: update rbdms urls to new repos (#43477)
* fix: update rbdms urls to new repos

* revert: github-tutorial-urls-to-moT01-repo
2021-09-25 12:54:00 +02:00
camperbot
9f2595ec0b chore(i18n,curriculum): update translations (#43556) 2021-09-24 06:31:25 -07:00
Alan Luo
42e88ac281 fix(curriculum): Fix a typo (#43554) 2021-09-24 15:48:31 +09:00
James Geer
77b8405a31 fix(curriculum): allow optional final css semi-colon (#43545)
* fix for issue: #43536, final css property optional semi-colon

* accidentally left a "y" at the end of the sentence

* replaced regex with CSSHelp

* removed trailing white-space
2021-09-23 19:25:50 +01:00
Shaun Hamilton
5ddccecd46 fix(curriculum): adjust implementation-of-social-auth tests (#43162)
* fix(curriculum): adjust implementation-of-social-auth tests

* use deepInclude with much optional chaining
2021-09-23 11:37:22 -05:00
camperbot
fd544c02a5 chore(i18n,curriculum): processed translations (#43546) 2021-09-23 16:38:58 +01:00
camperbot
2012ad3035 chore(i18n,curriculum): update translations (#43534) 2021-09-22 16:34:59 +01:00
James Geer
3207ea04e7 fix(curriculum): Css fix for issue #43517: Example css code does not demonstrate hover animation (#43524)
* fix question example code for id: 587d78a7367417b2b2512ae0

* Revert "fix question example code for id: 587d78a7367417b2b2512ae0"

This reverts commit c99edf8609.

* modifying only the english version of button hover example

* change to keep css looking consistent
2021-09-22 16:22:11 +02:00
Alan Luo
492ddcf6bd fix(curriculum): move word 'example' to correct position (#43528) 2021-09-22 13:55:59 +01:00
Renovate Bot
cf98d8b964 chore(deps): update dependency puppeteer to v10.4.0 2021-09-21 19:43:38 +00:00