Commit Graph

590 Commits

Author SHA1 Message Date
Alan Nguy
1957b1f636 fix: added test case and working solution for empty li elements in the 'Create an ordered list' challenge. (#35177)
* fix: added test case for empty li elements

* fix: added error message in test case of empty li elements.

* fix: corrected error in test case.

* fix: added valid working solution

* fix: migrated test case to challenge: create-an-ordered-list (working solution included)

* fix: adjusted condition for empty li elements and fixed typo.
2019-03-01 23:50:09 +05:30
Shashank Bairy R
a0b79252d3 fix:removed bug in front end lib random quote project (#35477) 2019-03-01 11:09:00 -06:00
hilliarj
6cd3466f0b fix(curriculum): Find Characters with Lazy Matching (#35454)
* fix(curriculum): Find Characters with Lazy Matching

* Update PR

Note is moved in the Description section and not the Instructions section
2019-02-28 13:33:07 -08:00
Ruchika Sharma
25f45ffc60 fix: Rename section in Modify array challenge (#35430) 2019-02-27 19:04:49 -05:00
Greg Smith
1779971cff Fix typos in MongoDB lessons and clarify some language (#35020)
* docs: typos and change some language for clarity

* fix: typo regression

* fix: added the word is
2019-02-27 13:41:19 -06:00
egxn
9a597e84db Add a missing preposition (#24445)
A little fix with, add a preposition like in the localeTitle
2019-02-27 19:27:19 +01:00
Jorge Molina
0aefc16599 Añadiendo algunos ajustes en español (#24424) 2019-02-27 19:25:54 +01:00
Dranthos
488feb050f Improved translation (#23652) 2019-02-27 19:23:57 +01:00
Niraj Nandish
769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
riodajs
2a61d4327c Update some words to commons spanish words (#23340) 2019-02-26 16:39:10 +01:00
Pete
41ffe5a7e4 Adding-missing-challenge-solution (#35025)
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
2019-02-26 03:44:33 -05:00
kevindelsh
e40909b055 Corrected minor spelling error (#34750)
Changed "areas template" => "area's template".
2019-02-25 23:38:40 -05:00
Randell Dawson
ab456a9a94 fix: changed js to html in solution section (#35414) 2019-02-25 22:50:58 -05:00
Aditya
665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
Paul Gamble
0c652e3ace feat: curriculum-basic-html-form-element-solution (#34956) 2019-02-25 22:23:08 -05:00
The Coding Aviator
cbd1ebd4f5 Remove extra empty line from Applied Visual Design Challenge (#35241)
* Remove extra empty line

* fix(client): Removed extra line
2019-02-25 22:00:00 -05:00
Dana Ottaviani
30fd0aa78e fix: add solution for accessibility challenge (#35366) 2019-02-25 21:58:35 -05:00
Héctor Estéllez
fd1a19d956 Add indentation spaces to example code (#35047) 2019-02-25 18:49:42 -06:00
Bannon Tanner
fe07433d0e fixed typo with instructions and preview (#26088)
* fixed typo with instructions and preview

Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes #18034

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md

suggested change by @thecodingaviator

Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>

* possible fix for solution

* apply my suggestioned changes
2019-02-25 15:50:00 -08:00
Alex
06311a56f6 Fixed the code formatting for readability (#25831)
I fixed the code formatting for readability. Made the spacing easier to see so updates and changes could be made more easily.
2019-02-25 21:03:32 +01:00
lolabarri
0a228ab8e8 Update build-a-tribute-page.spanish.md (#23321)
Modified user history number 7, so it has the same format as the others. Also modified last line, which was too informal compared with the rest of the article
2019-02-25 20:37:02 +01:00
riodajs
ca24e4bca2 Update traduction from some words (#23314) 2019-02-25 20:34:56 +01:00
Nellie
ff23e94e25 Update add-elements-within-your-bootstrap-wells.russian.md (#28969)
Fixed Russian translation in add-elements-within-your-bootstrap-wells.english.md.
2019-02-25 21:58:59 +04:00
geeseyj
f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Gökhan Gurbetoğlu
2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson
9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
NITIN BISHT
f224bbc62f fix: seed code doesn't match description [arabic] (#35382) 2019-02-24 16:29:51 -06:00
Adam
36d0d5d70f Added description to help understand challenge (#34674)
* Added description to help understand challenge

I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

Looks good!

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

True, that makes sense..

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
2019-02-24 12:27:12 -07:00
Ahmed Elbessfy
61a5707ba7 Edit Description (#34329)
* Edit Description

Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md

Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
NITIN BISHT
a9e4e88cbe fix: seed code doesn't match description [russian] (#35384) 2019-02-24 09:59:49 -06:00
NITIN BISHT
1fd4177354 Fix/seed code does not match description chinese (#35381)
* fix: seed code doesn't match description [english]

* fix: seed code doesn't match description [chinese]
2019-02-24 09:08:10 -06:00
NITIN BISHT
b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
lasjorg
0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
NITIN BISHT
815cb03f2b fix: seed code doesn't match description [portuguese] (#35383) 2019-02-24 08:26:33 -06:00
riodajs
d341c16aae Add some words (#23297)
like "uncomment" to "borrando etiquetas de comentarios"
2019-02-24 14:26:49 +01:00
riodajs
83ff4a53e7 Change some words conjugations. (#23261) 2019-02-24 13:46:29 +01:00
riodajs
a5e5e1de50 Changet text "Usted especifique" to "tú especificas" (#23226) 2019-02-24 13:46:04 +01:00
Edwin J. Munguia
803836db66 Translated remaining English text into Spanish (#23132) 2019-02-24 12:54:56 +01:00
Santiago
4f1f4238c2 Small Consisteny Fixes (#34107)
Consistency with the 'tu' way of refering to you.
Translated the html code part to spanish
2019-02-24 12:53:46 +01:00
Diego Arias García
f1efc85ccb Fixed Translation Errors (#22754) 2019-02-24 12:07:59 +01:00
Diego Arias García
1ee9f6223c Grammar Errors fixed (#22749) 2019-02-24 12:00:56 +01:00
NITIN BISHT
c9628f0296 fix: seed code doesn't match description [spanish] (#35385) 2019-02-24 13:47:08 +05:30
Chris Del
10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson
b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Carlos Pulido
e7718db53e Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.spanish.md (#31200) 2019-02-23 23:49:23 +01:00
Chad
a288e1d71a Correct footer and header order description (#34473)
* Correct test text

Header & footer swapped to refer to top and bottom respectively

* line 24 "footer and header" to "header and footer"
2019-02-22 11:30:33 -08:00
Randell Dawson
bc99876f9e [Fix] allow line breaks between method calls for several Data Visualization challenges (#35093)
* fix: allow spaces between lines breaks a function arguments

* fix: allow line breaks between method calls
2019-02-22 12:18:10 -07:00
Octabond
603585e39e Update tests and challenge seeds (#25588)
Update tests and challenge seeds with spanish instructions
2019-02-22 20:05:09 +01:00
Lewis Horwood
9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
Beau Carnes
2bb171ef30 fix: update color hex values and description of orange (#35316)
* fix: update color hex values and description of orange

* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md

Co-Authored-By: beaucarnes <beaucarnes@gmail.com>

* fix: add test that no color names are used
2019-02-22 10:37:57 -08:00