Commit Graph
30 Commits
Author SHA1 Message Date
Lasse JørgensenandGitHub df44da9dc2 fix(challenge): correct terminology and inform of correct array copying (#40045)
* fix(challenge): correct terminology and inform of correct array copying

* fix(challenge): update text with proposed changes
2020-11-25 08:14:33 -08:00
Lasse JørgensenandGitHub 45520cd7c5 fix(editor): disable suggestion actions squiggly-hint (#39596) 2020-09-17 16:18:04 +05:30
Lasse JørgensenandGitHub 2743ac2e84 fix(challenge): update variable names, assign empty array, update solution code, remove "use strict" (#39525)
* fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"

* fix(challenge): update solution code

* fix:(challenge) update instructions and variable name

* fix:(challenge) update instructions
2020-09-09 19:58:27 -05:00
f3a82fe2f1 fix: Add information about local development for RWD projects (#38670)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-04 20:26:26 +05:30
c6c1a22487 chore: update dependencies (#39475)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-08-27 20:15:18 +05:30
Lasse JørgensenandGitHub 198c051d0e fix(doc): Correct link for "making changes and syncing" (#38956)
Fixing localhost link.
2020-05-31 08:06:00 -05:00
Lasse JørgensenandGitHub 9e01ead291 fix(editor): Add quickSuggestions false to editor options (#38899) 2020-05-26 19:10:45 +05:30
9a5ae756ac fix(challenge): check inline style for color (#38211)
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-02-18 23:38:16 +05:30
lasjorgandOliver Eyton-Williams 8cca639450 fix(challenge): check inline styles on elements, add solution (#37756) 2019-12-16 16:18:29 +01:00
lasjorgandRandell Dawson 63b9be8faf fix(challenge): account for browser zoom, add note to challenge (for width challenge) (#37688)
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for width assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code

* updated regex, add check for maxWidth
2019-12-13 07:05:23 -08:00
lasjorgandRandell Dawson ba927090fe fix(challenge): account for browser zoom, add note to challenge (for height challenge) (#37687)
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for height assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code
2019-11-25 19:40:21 -08:00
lasjorgandmrugesh e1a1ed5c12 fix(client): use JSON.stringify replacer function for NaN (#37684) 2019-11-10 04:17:18 -08:00
lasjorgandRandell Dawson 316d56ba11 fix(challenge): use offsetHeight to get height value (#36995) 2019-10-27 19:02:53 -04:00
lasjorgandmrugesh 4a478b550f chore: update monaco-editor, react-monaco-editor (#37445) 2019-10-22 01:09:21 +05:30
lasjorgandTom 881be7121e fix(challenge): remove type coercion check for true and false return (#36519)
* fix(challenge): remove type coercion check for true and false return

* fix(challenge): use Chai methods for false/true check
2019-07-30 08:33:37 -05:00
lasjorgandOliver Eyton-Williams f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
lasjorgandRandell Dawson c852dc7d1d fix(guide): correct regex for intermediate solution code (#35784) 2019-05-24 23:45:26 -07:00
lasjorgandTom 7573252fa0 feat(guide): add guide for HTML value attribute challenge (#35783) 2019-05-03 10:16:50 -05:00
lasjorgandThe Coding Aviator 394ae3d1ce fix(challenge): check for li and specify elements accepting text (#35193)
* fix(challenge): check for li and specify elements accepting text

* fix(challenge): revert text

* fix(challenge): remove word added by mistake

* fix(challenge): update test, cleanup assertion text
2019-04-10 20:52:37 +05:30
lasjorgandManish Giri f91dea9b5c fix(challenge): update text to give an explanation of wrapping (#34811)
* fix(challenge): update text to give an explanation of wrapping

* fix(challenge): simplify challenge text

* fix(challenge): update challenge text add solution

* fix(challenge): remove line breaks

* fix(challenge): make second instruction more clear
2019-04-04 22:49:21 -04:00
lasjorgandRandell Dawson be687977cf fix(challenge): add .english to file name (#35687) 2019-03-27 06:38:25 -07:00
lasjorgandThe Coding Aviator d9213b38cd fix(challenge): remove child selector from name attribute test (#35423) 2019-03-27 11:33:41 +05:30
lasjorgandRandell Dawson 69d9d522a2 fix(challenge): fix broken regex (#35632)
* fix(challenge): fix broken regex

* fix(challenge): update solution
2019-03-26 21:48:52 -07:00
lasjorgandRandell Dawson a1e853337b fix(challenge): simplify and cleanup tests (#35535) 2019-03-26 21:35:38 -07:00
lasjorgandTom 98e68d04be feat(curriculum): Add challenge on using the value attribute (#35301)
* feat(curriculum): Add challenge on using the value attribute

fix(challenge): update file name and add comma

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Apply suggestions from code review

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

* fix(challenge): update tests
2019-03-24 18:43:05 -05:00
lasjorgandRandell Dawson 88a5d46ccb fix(challenge): add support for IIFE arrow function (#35573)
* fix(challenge): add support for IIFE arrow function

* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
lasjorgandRandell Dawson 494687f75e fix: correct inconsistency in formatting (#34721)
* fix: correct inconsistency in formatting

* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
lasjorgandTom 25ea44edf5 fix(challenge): allow new line in linear-gradient formatting (#35435)
* fix(challenge): allow new line in linear-gradient formatting

* fix(challenge): update test with suggested changes

* fix(challenge): update test to use computed style
2019-03-03 19:32:41 -06:00
lasjorgandTom 0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
lasjorgandManish Giri 9341aadb5b Fix/remove property references and update tests (#35109)
* fix(challenges): Update challenge text and assertion test

* fix(challenges): update assert test regex

* fix(challenges): update regex, fix inline comment in code example

* fix: corrected regex
2019-02-09 00:47:53 -05:00