Commit Graph
40 Commits
Author SHA1 Message Date
8e62a243bb fix(learn): Update demo links (#40575)
* fix(learn): Replace demo projects

Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(learn): Use correct endpoint

Corrects the API endpoint for the image search
project.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: user stories to align with project + backticks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-21 11:09:35 -06:00
Nicholas Carrigan (he/him)andGitHub 7fef673f93 docs: Remove chinese files from sidebar (#40068) 2021-01-21 13:46:10 +05:30
062b1cd424 fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Nicholas Carrigan (he/him)andGitHub 69b181ee97 fix: disable automatic PR creation (#40753)
Temporarily disables the automatic PR creation on Crowdin Download while
we determine the best approach for this. PRs created by the action
itself cannot trigger workflows, which prevents our CI from running. As
such, this is currently not a viable approach.


Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-21 11:30:16 +05:30
891a64fa3d fix(learn): Remove arrows from test name assertion (#40467)
* fix: Remove arrows from test name assertion

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Add note about time span

Adds a note regarding the expectation of the `span` element to wrap the
entire time string when translated, not just the delimiter symbol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: use correct note syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove note syntax

New line was breaking the build, so changing the `note` comment to be
regular text.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-20 21:57:32 -07:00
b07394603b feat(learn): Move metric imperial converter tests (#40358)
* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Modify test verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add missing tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Correct inaccurate test text - thx @ShaunSHamilton

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove arrow from test name

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 21:51:57 -07:00
8d8d25e9f2 fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
3c042c627e docs: Translation Flow (#40737)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 09:14:14 +05:30
Nicholas Carrigan (he/him)andGitHub bab54ad619 fix(learn): no capital code block (#40688)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-16 12:54:38 -07:00
Nicholas Carrigan (he/him)andGitHub f159ad873c fix(tools): adjust comment message (#40711)
* fix: adjust comment message

Changes the message this action uses for a PR comment to remove the
reference to the translation page pending announcement.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: expand comment

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-15 16:12:02 -07:00
94190f51fc feat(tools): add action to check for translations (#40692)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-13 23:00:52 +05:30
Nicholas Carrigan (he/him)andGitHub 179b4823fd feat(docs): Update moderator handbook (#40601) 2021-01-01 12:39:39 +05:30
26c9b3c16b feat(docs): Update Contributing Instructions for New Template (#40329)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-12-29 13:53:23 +05:30
Nicholas Carrigan (he/him)andGitHub ea02c7db7f docs: Update reply templates (#40574) 2020-12-29 13:52:50 +05:30
Nicholas Carrigan (he/him)andGitHub 7317b8057a fix(docs): Replace Travis with GH Actions (#40580)
Replaces the references to the old Travis CI
flow with updated information for the GitHub
actions flow, and handles a couple of typo fixes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-29 11:15:12 +05:30
Nicholas Carrigan (he/him)andGitHub 994598900a fix(dashboard): Use CDN for favicon (#40522)
* fix: Use CDN for favicon

Replaces the local favicon (which was not
rendering correctly on production) with the
version served by the CDN. Also adds our other
meta tags used for PWAs and OpenGraph Protocol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove local manifest

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-22 17:07:21 -07:00
Nicholas Carrigan (he/him)andGitHub 0ff001eaed docs: One remaining chat link (#40519)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-22 11:56:53 -07:00
Nicholas Carrigan (he/him)andGitHub 2d0bba3097 docs: Replace Gitter/Discord links (#40514) 2020-12-22 12:00:00 +05:30
Nicholas Carrigan (he/him)andGitHub 582d3ab93f fix(learn): Headless Browser Tests have incorrect values (#40330)
* Restructure files

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Realign forum topic ids

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Missed query string numbers

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Test all previous tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Fix the semi-colon

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* change test name to match boilerplate change

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-15 19:17:25 -06:00
Nicholas Carrigan (he/him)andGitHub 81a49ec94b fix(learn): Disable prettier formatting on challenge files (#40370)
* Ignore challenge files

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-03 18:10:15 +01:00
Nicholas Carrigan (he/him)andGitHub 49f6875db5 fix(learn): ES6 Getters + Setters tests (#40238)
* Strengthen tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Improve verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Add second check to setter test

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:22:44 -08:00
Nicholas Carrigan (he/him)andGitHub ec8b2dc016 feat(learn): Message Board User Stories (#40219)
* Update verbiage, add instructions

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Remove unit test mention

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Move test descriptions to learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* target blank on gh link

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:11:38 -08:00
49f2055b98 Move tests to /learn (#40263)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-25 13:27:22 -08:00
Nicholas Carrigan (he/him)andGitHub 62713f0e10 feat(learn): Move American British Translator tests (#40265)
* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Replace quotes with code

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 12:10:52 -08:00
Nicholas Carrigan (he/him)andGitHub c0b9ad6bf2 Move tests to /learn (#40264)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 12:06:42 -08:00
b5d5ec5a90 feat(learn): Stock Price Checker user stories (#40218)
* Adjust user stories, add instructions

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply review suggestion

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-25 11:55:03 -06:00
9cfd9ad887 feat: Add tests for Sudoku Solver (#39816)
* Add tests

* Apply Tom's requests

* Verbiage change

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:03:43 -06:00
cf35d24311 feat(learn): Add Stock Price Checker tests (#39640)
* Add some tests

* More tests

* remove extraneous declaration

* Remove unneeded test string

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-11-04 09:37:27 -08:00
d8be4d24a5 feat(learn): Some tests for Anonymous Message Board (#39652)
* Clean up text, partial test completion

* remove extraneous declaration

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Use non-breaking space after colon

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:26:10 -06:00
7857dc53f4 docs: Update Moderator Handbook (#40110)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-28 03:18:51 +05:30
Nicholas Carrigan (he/him)andGitHub fa2d5c687c Fix broken Discord link (#40035)
* Fix broken Discord link

* Change links across translations
2020-10-20 00:11:08 +05:30
Nicholas CarriganandGitHub 6ccd0d21a1 fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
d33f5f82a7 fix(learn): Consistent Styling in Set up a Template Engine (#39657)
* Replace bold with code

* Typo

* Apply suggested verbiage change.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* remove code tags from render

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 07:10:29 -07:00
Nicholas CarriganandGitHub f132f5157c feat(learn): Add test for file metadata project (#39625)
* Add tests

* Switch from local file to CDN

* remove extraneous declaration

* Apply review suggestions
2020-09-23 20:21:09 -07:00
Nicholas CarriganandGitHub 3969f651b8 Remove helmet test instructions (#39613) 2020-09-22 14:42:25 -05:00
Nicholas CarriganandGitHub 763ff1ae83 docs: remove beta statement (#39497) 2020-09-03 14:47:33 +05:30
Nicholas CarriganandGitHub 4858c2eb0a Remove extra / from link (#39419) 2020-08-16 18:25:55 -07:00
Nicholas CarriganandGitHub 1e0e54446f chore: replace forum links (#39139) 2020-06-30 14:21:26 +05:30
25cabc0a18 fix(learn): change forum link in help modal (#39143)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2020-06-30 14:15:42 +05:30
2aee480c46 Remove example code from challenge seed (#39083)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-06-22 16:13:21 +05:30