Commit Graph

25164 Commits

Author SHA1 Message Date
63b9be8faf fix(challenge): account for browser zoom, add note to challenge (for width challenge) (#37688)
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for width assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code

* updated regex, add check for maxWidth
2019-12-13 07:05:23 -08:00
33cec6b6f2 fix: updated instructions for install-and-set-up-mongoose (#37908)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Kevin Matsuo <kmatsuo@ARDs-MacBook-Pro-2.local>
2019-12-13 16:23:11 +05:30
38160d6dd7 fix(donate): update message on the success (#37917) 2019-12-13 16:05:59 +05:30
fdb17223ec revert : Added displayUsername and username update functionality
removes implemenation from #35699
This reverts commit e154f38118.
2019-12-13 01:07:05 +05:30
0efaa4c3d7 fix: provide Travis dummy environment variables 2019-12-13 01:05:38 +05:30
e3b77a62cc feat: simplify development setup
Warns if .env is missing.  Combines the three docker installation
commands into one, updating the docs accordingly.

Also removes the libcimp patch as npm already has it.
2019-12-13 01:05:38 +05:30
647e25aa7c fix(donate): update mesage on the modal 2019-12-12 20:18:32 +05:30
d7b7f0bfde fix: replace donate page 2019-12-12 20:18:32 +05:30
00f18dc21c chore: address review comments
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-12-12 20:18:32 +05:30
053dbfbba4 feat: add donation form to certificate 2019-12-12 20:18:32 +05:30
01d1315835 feat: add minimal form to modal 2019-12-12 20:18:32 +05:30
85d3587e59 fix:remove additional certification from certs (#37910) 2019-12-12 11:16:10 +01:00
44ff327a38 fix(curriculum): make test more flexible for (#37902)
* make test more robust

* fix: changed test to ignore extra spaces in html

* Revert "make test more robust"

This reverts commit 89718eb5e5.
2019-12-11 23:20:19 -05:00
d6c53eb914 fix(client): report cross origin errors (#37793)
* fix(client): report cross origin errors

This reports errors generated in cross origin scripts to the dev console
and lets the user know via the fcc console.

* refactor: clean up script error checks

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-11 17:59:19 +05:30
e154f38118 Added displayUsername and username update functionality (#35699)
* Added displayUsername and username update functionality

* fix: move username assignment to safe place

moved the username assignment down a statement so that it doesn't cause exception 

* fix: handle missing username or displayUsername

* refactor: remove redundant code
2019-12-11 12:43:06 +01:00
0f5b9f8764 fix(client): temporary redirect for donation settings 2019-12-10 17:55:57 +01:00
c40680b81e fix(client): remove donate settings page 2019-12-10 17:55:57 +01:00
6a91f7c5b2 fix(client): add missing bootstrap container (#37905) 2019-12-10 17:38:16 +05:30
3f075f91d8 feat: activate progress based donation modal (#37882) 2019-12-09 22:00:24 +05:30
f1ddec3f9b fix(donate): hide legacy tiers (#37853) 2019-12-09 11:38:20 +05:30
cb3524ee31 fix: simplify challenge testString (#37826) 2019-12-07 15:47:08 -05:00
623c08cbfa fix: removed semi-colon from regex (#37881) 2019-12-07 15:02:42 -05:00
ccbc9cc6b6 forum link fixed (#37260) 2019-12-07 06:47:48 -08:00
d40be9cbf2 fix: use util.inspect for more reliable logging (#37880)
The tests are probably overkill, but this way we will know if
util.inspect changes dramatically.
2019-12-06 08:37:10 -08:00
450ac77e6a docs: Docker Toolbox for Windows 10 Home (#37873) 2019-12-06 19:05:13 +05:30
daf3a53e55 fix: optimize donation for mobile (#37803) 2019-12-06 10:30:53 +03:00
d7c4fd7fea fix: remove donation prevention (#37867) 2019-12-06 08:43:23 +03:00
7deecf8245 docs: add faq about guide articles (#37874) 2019-12-05 22:15:19 +05:30
dc5c0c7f82 Fix minor grammar issue in override-styles-in-subsequent-css.english.md (#37871) 2019-12-04 14:32:55 -08:00
8af54eb272 fix(curriculum): Technical language correction (#37812)
Technically, the prototype is not cloned; it is merely referenced.
2019-12-04 21:01:49 +00:00
68d0a15dbd Update jump-straight-to-the-content-using-the-main-element.spanish.md (#37253)
Fixed to communicate the intended instructions correctly in Spanish.
2019-12-03 00:46:03 -08:00
71b5918b01 Minor Spanish grammar fixes (#36862) 2019-12-03 00:37:38 -08:00
bda0259c36 Made grammatical changes (#36948)
Grammar changes have been made to make proper use of "tu", as it was mixed with the formal person "Usted"
2019-12-03 00:34:10 -08:00
975e59cd03 Fix grammar errors (#37119) 2019-12-03 00:32:22 -08:00
984a530905 fix(curriculum): added extra mongoose options to prevent log warnings (#37693)
* fix: added extra mongoose options to prevent log warnings
2019-12-03 13:12:27 +09:00
dd2fb28ee0 fix: make tests more robust (#37830) 2019-12-02 18:42:32 -05:00
a68e3ef39d fix: change rating to ratings (#37863) 2019-12-02 17:25:11 -05:00
7454719334 fix(curriculum): Improved Use Recursion to Create a Countdown challenge (#37548)
* fix: improved recursive challenge

* fix: rewording of two challenges

* fix: add code tags

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-12-02 17:58:07 +01:00
a6766127cc fix(curriculum): corrected test and added solution for Create a Hash table challenge (#37582)
* fix: corrected test and added solution

* fix: redefine hash

* fix: use defined hash

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-12-02 17:23:56 +01:00
d39dd970b6 fix(curriculum): use regex to avoid differences in how browsers calculate style property values for Decrease Opacity of an Element challenge (#37838)
* fix: use regex to avoid diff in browsers

* fix: improve regex
2019-12-02 20:50:34 +05:30
a24ae88b2e fix: fix modal close contrast (#37848)
* fix: more fix
2019-12-03 00:08:43 +09:00
a9bbcda211 feat(donate):add donation modal and certification message (#37822)
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-12-02 15:48:53 +03:00
Tom
9866d2f241 fix: grid column and grid row tests (#37736)
* fix: grid column and grid row tests

* fix: test text verbiage

* fix: add solution to pass build error

* fix: make test more readable
2019-12-01 10:02:24 +05:30
aac1c58374 fix(curriculum): make last test more robust for Uncomment HTML challenge (#37843)
* fix: correct last test

* fix: remove forgotten console.log

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-30 23:09:48 -05:00
58ca8ddf2a fix: correct function name in test text (#37839) 2019-11-30 18:30:10 -05:00
Tom
da99033b77 fix: sum all primes description (#37750)
* fix: sum all primes description

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-30 16:33:37 -06:00
cabfd25b40 MODIFIED convert-json-data-to-html to warn about XSS attacks (english) (#37036)
*  MODIFIED convert-json-data-to-html to warn about XSS attacks (english)

* Forgotten newline in convert-json-data-to-html

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: suggested changes

* fix: added commas
2019-11-30 12:52:59 -06:00
c33fdb2515 docs: Capitalization fix in CONTRIBUTING.md (#37854) 2019-11-30 13:20:57 +05:30
c660b389a8 fix(donate): handle missing stripe keys (#37847)
* fix: gracefully handle missing stripe keys

* fix: remove state updates from render (donate)
2019-11-30 01:41:31 +05:30
81bb677def fix(donate): show message for legacy donors (#37844) 2019-11-30 01:39:45 +05:30