Commit Graph

708 Commits

Author SHA1 Message Date
Kiara Barias
c4dc0b297f Switch statement example updated (#37757)
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00
Randell Dawson
55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715)
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-13 14:39:03 -06:00
Rohit Ambre
376b42637a Updated file names required in the challenge (#37737)
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
2019-11-11 22:04:38 -05:00
Quincy Larson
e169779805 fix: update twitter image URL (#37739) 2019-11-12 02:32:17 +05:30
allison-strandberg
2c5453e3bd Clarify instructions (#37735)
Closes #37734
2019-11-11 16:48:51 +01:00
Tom
6ff5e52b2d Improve viewport unit readability (#36673)
* Improve viewport unit readability

Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
2019-11-11 10:24:02 +01:00
Matheus Genteluci
67e0f33a89 feat: Add Solution to handle click event - English (#37069) 2019-11-11 09:19:28 +01:00
Marco Valero
f3ee4f85ae Changes to "access-array-data-with-indexes.english" challenge description (#37730)
* edited description to be a little more clear on how to access elements in an array through indeces

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
Tristan Michael Lawrence
5296d5c731 fix: removed trailing spaces, fixed a typo (#37572)
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00
Daniel Veazey
9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726)
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
2019-11-09 18:13:10 -05:00
David Carlson
bdae7343bb escaped backslash character on line 22 (#37721)
Previously only showed empty parentheses.
2019-11-08 23:25:48 -05:00
David Carlson
00914be3e8 Removed text about prior knowledge (#37722)
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
2019-11-08 22:03:44 -05:00
Randell Dawson
5ae8470bd5 fix: changed container to container2 (#37483) 2019-11-07 21:15:38 -05:00
Louisa
2287d73b4f fix missing closing brace and bracket for promise (#37474)
There was a missing closing brace, bracket and semi-colon for the constructor new Promise in its definition
2019-11-07 19:24:54 +01:00
Alex Parra
647945f4ac fix: duplicated 'use' in set-up-passport.english.md (#37134) 2019-11-07 18:42:34 +01:00
Daniel Veazey
7f4531aed0 replace the word "dashes" with "hyphens" (#37705) 2019-11-07 01:19:39 -05:00
Kiara Barias
3119da3ec5 Changes to "Iterate with JavaScript While Loops - English" challenge description (#37683)
* Update iterate-with-javascript-while-loops.english.md

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-while-loops.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 13:26:44 -05:00
PartyLich
a52b5b4ebb feat: rewrite Iterate with JavaScript While Loops challenge (#37697)
* feat: rewrite Iterate with JavaScript While Loops challenge

Previous example in the challenge description was the exact code
that challenge instructions say to implement. Change the challenge to
differentiate from the example.

resolve freeCodeCamp/freeCodeCamp#37694

* fix: update iterate with javascript while loops solution

* refactor: improve iterate with js while loops challenge wording

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 12:51:59 -05:00
Ananda Umamil
734b794714 fix: update react proptypes lesson description (#37477) 2019-11-05 00:42:07 -05:00
Roberto Ruccia
36de803902 Fix link in use-proptypes-to-define-the-props-you-expect.english.md (#37665)
* Fix link in use-proptypes-to-define-the-props-you-expect.english.md

* Add a blank line before Note line
2019-11-01 20:22:19 -05:00
Beau Carnes
28575e9877 Add updated Scrimba link to Word Blank challenge (#37630) 2019-10-31 11:37:26 -05:00
lasjorg
316d56ba11 fix(challenge): use offsetHeight to get height value (#36995) 2019-10-27 19:02:53 -04:00
SomeDer
bfa5c26288 fix: use dfn instead of code tag (#36640)
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
2019-10-27 12:45:37 -04:00
Rajat Hans
0551a6a57f Word change in responsive design principles English (#37559)
* Word change in responsive design principles

* Word change in responsive design principles
2019-10-26 16:57:20 -04:00
Ahmad Shahzad
9db88a0d7c Fixed a typo in Specify How Fonts Degrade lesson. (#37567)
* Fixed a typo in Specify How Fonts Degrade.

'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.

Instead of "'-->!'.", it should be "'-->'."

* Made text wording consistent for the test instructions.

* Changed "To begin with," to "To begin," and fixed a minor typo.

If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.

Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
2019-10-26 16:55:10 -04:00
Omar Dabour
b59f72961f Fix Typo (#37557) 2019-10-26 16:48:06 -04:00
csteacher1
1a019f952b Added hyphen to "coopted" on Line 17 (#37468)
* Added hyphen to "coopted" on Line 17

Added a hyphen to the word"coopted" to correct it to "co-opted" on Line 17.

* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-10-25 13:47:05 -05:00
burrowsdt
dd8168133f Added escape characters to the javascript comment curriculum (#37518) 2019-10-25 13:41:42 -05:00
gmal1
94635dcc0b Fix incorrect spelling of BCrypt (#37247)
* Fix incorrect spelling of BCrypt

* Fixed spelling of BCrypt in the Chinese, Portuguese, and Spanish versions of the challenge
2019-10-24 17:39:53 +09:00
Ambar Mutha
bcef08424c add comment explaining back-end challenges don't need a solution (#37111)
* add solution to a challenge

add solution to the challenge: add-a-description-to-your-package-json

* add comment to all backend challenges
The comment expllains that these challenges don't need a solution.
2019-10-24 13:38:13 +09:00
mrugesh
9612c5ba74 fix: HSTS test in Infosec curriculum (#37469)
Co-authored-by: Wocanilo <daniel.sese@wuolah.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-10-23 21:35:34 +05:30
Randell Dawson
76b9525a54 fix: added forumTopicId to recently added Rosetta Code challen… (#37479) 2019-10-23 21:34:34 +05:30
Chayanon Tonsai
8b082995b5 Change test method from string.test(regex) to regex.test(string) (#37458) 2019-10-23 09:32:17 -05:00
Bhanu Pratap Singh Rathore
ca63f90070 feat(interview-prep): Converting and transfering Rosetta problems (#35770)
* feat(interview-prep): Converting and transfering Rosetta problems
2019-10-23 23:23:50 +09:00
Tom
69d4d4fe2f fix: recursion test (#37419)
* fix(challenge): recursion test

* fix(challenge): replace regex s flag with g
2019-10-23 00:18:40 +05:30
shrobbins
a13bb1b96f fix: missing semi-colon (#37454) 2019-10-21 20:50:51 -04:00
jasonranney
f0c1d3a759 change "therefor" to "therefore" to be grammatically correct (#37297) 2019-10-16 11:41:11 -04:00
Kris Koishigawa
26eacf6f47 fix: Change project URL to a working fCC example project 2019-10-15 00:45:50 +09:00
Ambar Mutha
5dce06fccb add comment explaining no need for solutions (#37227) 2019-10-14 11:30:42 -04:00
Kristofer Koishigawa
71fbf2b658 fix(challenges): Update stock price checker sample project URL and add proxy info (#36801)
* fix(challenges): Updated sample project URL, added information about a proxy for stock price information, and tweaked the English test text slightly
2019-10-15 00:04:32 +09:00
Johnny Zabala
e9bbcc55cd test rendered output instead of state in react write a simple counter challenge (#36791) 2019-10-09 09:52:41 -05:00
Kris Koishigawa
74778c1af8 fix: Updated all Glitch URLs used to import/remix a GitHub repo 2019-10-08 11:04:30 -07:00
nemogoc
23a3287d8f update test wording for undefined fn returns (#36804)
* update test wording for undefined fn returns, bring code out of after test section and check that the function does what it says it does (rather than just checking the result), update seed, example, and solution
2019-10-08 19:16:36 +09:00
Randell Dawson
8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Tom
52bd3a65de fix: balanced-brackets-tests (#36807) 2019-09-25 11:39:11 +02:00
SomeDer
5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler
d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Oliver Eyton-Williams
3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
sybiljasmine
5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00
Kaitlin
76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00