Commit Graph

25185 Commits

Author SHA1 Message Date
Tom
a8a7eeb10d fix: make github url optional for backend projects (#37936) 2019-12-20 19:30:33 +05:30
01b37f664f fix: stop user code after 100ms of execution (#37841)
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2019-12-20 19:28:17 +05:30
Tom
f5360e9393 fix: timeline not showing when set to public (#37937) 2019-12-20 19:19:02 +05:30
2e3a5d4b1f fix: adjust default theme for StripeCardForm 2019-12-20 19:10:42 +05:30
e4590fed5c fix(donate): implement donate page 2019-12-20 19:10:42 +05:30
5609a1303e fix: corrected tests for 3 challenges (#37948) 2019-12-19 11:26:50 +01:00
6ef9345f92 fix: add close modal to keyboard navigation 2019-12-18 21:04:55 +05:30
1289d35435 fix: show default theme for donation related pages (#37956)
* fix: show default theme for donation related pages

* feat: add default theme to stripForm
2019-12-18 17:40:48 +03:00
8db0f89634 fix(donate): remove isDontating check from year-end 2019-12-18 12:59:18 +03:00
663f726c4e fix(donate): allow unauthenticated donations for year-end 2019-12-18 04:21:57 +05:30
fc25c281e4 fix: adjust cert logo and grid 2019-12-18 03:08:58 +05:30
81de7dfaf7 fix: make nav logo link to /learn 2019-12-18 03:07:46 +05:30
4221e7c45b fix(donate): make api flexible for custom amounts
The commit needs to be removed or the logic updated later.
2019-12-18 02:48:03 +05:30
1cead2f086 feat(donate): add year end gift page 2019-12-18 02:48:03 +05:30
8cca639450 fix(challenge): check inline styles on elements, add solution (#37756) 2019-12-16 16:18:29 +01:00
203c9823e8 Fixed minor grammar issue in escape-sequences-in-strings.english.md (#37940)
* Update escape-sequences-in-strings.english.md

Fixed minor grammar issue in list item 1 of the description section.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-16 06:16:16 -08:00
9ad5a95197 fix: re-order and update sign in CTA styles on completion modal (#37884) 2019-12-16 17:10:55 +05:30
616d96f612 refactor: update trivial regex capture group find and replace challenge (#37768)
* refactor: replace trivial regex capture group challenge

Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.

resolves #17645

* test: validate at least 3 capture groups were used

Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex)
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* refactor: more meaningful variable name

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* test: add parenthesized substring test

* test: ensure 3 uses of substring replacement

* refactor: reword instructions

* fix: minor grammar fix

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* refactor: elaborate wording in test
2019-12-14 16:41:47 -05:00
Tom
2dfd850de8 Fix: bad link on donate page (#37935)
* fix: donate page link

* fix: remove unneeded curly brackets
2019-12-14 22:19:38 +05:30
c935d21f84 Fixed bad capture group in regex (#37575) 2019-12-13 22:16:30 -06:00
85e7fe45d5 fix(curriculum): use object.assign to prevent overwriting prototypes if user uses class instead of function (#37648)
* fix: use object.assign to prevent overwriting when using class

* fix: remove non-used isBinarySearchTree method
2019-12-13 15:04:05 -06:00
63b9be8faf fix(challenge): account for browser zoom, add note to challenge (for width challenge) (#37688)
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for width assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code

* updated regex, add check for maxWidth
2019-12-13 07:05:23 -08:00
33cec6b6f2 fix: updated instructions for install-and-set-up-mongoose (#37908)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Kevin Matsuo <kmatsuo@ARDs-MacBook-Pro-2.local>
2019-12-13 16:23:11 +05:30
38160d6dd7 fix(donate): update message on the success (#37917) 2019-12-13 16:05:59 +05:30
fdb17223ec revert : Added displayUsername and username update functionality
removes implemenation from #35699
This reverts commit e154f38118.
2019-12-13 01:07:05 +05:30
0efaa4c3d7 fix: provide Travis dummy environment variables 2019-12-13 01:05:38 +05:30
e3b77a62cc feat: simplify development setup
Warns if .env is missing.  Combines the three docker installation
commands into one, updating the docs accordingly.

Also removes the libcimp patch as npm already has it.
2019-12-13 01:05:38 +05:30
647e25aa7c fix(donate): update mesage on the modal 2019-12-12 20:18:32 +05:30
d7b7f0bfde fix: replace donate page 2019-12-12 20:18:32 +05:30
00f18dc21c chore: address review comments
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-12-12 20:18:32 +05:30
053dbfbba4 feat: add donation form to certificate 2019-12-12 20:18:32 +05:30
01d1315835 feat: add minimal form to modal 2019-12-12 20:18:32 +05:30
85d3587e59 fix:remove additional certification from certs (#37910) 2019-12-12 11:16:10 +01:00
44ff327a38 fix(curriculum): make test more flexible for (#37902)
* make test more robust

* fix: changed test to ignore extra spaces in html

* Revert "make test more robust"

This reverts commit 89718eb5e5.
2019-12-11 23:20:19 -05:00
d6c53eb914 fix(client): report cross origin errors (#37793)
* fix(client): report cross origin errors

This reports errors generated in cross origin scripts to the dev console
and lets the user know via the fcc console.

* refactor: clean up script error checks

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-11 17:59:19 +05:30
e154f38118 Added displayUsername and username update functionality (#35699)
* Added displayUsername and username update functionality

* fix: move username assignment to safe place

moved the username assignment down a statement so that it doesn't cause exception 

* fix: handle missing username or displayUsername

* refactor: remove redundant code
2019-12-11 12:43:06 +01:00
0f5b9f8764 fix(client): temporary redirect for donation settings 2019-12-10 17:55:57 +01:00
c40680b81e fix(client): remove donate settings page 2019-12-10 17:55:57 +01:00
6a91f7c5b2 fix(client): add missing bootstrap container (#37905) 2019-12-10 17:38:16 +05:30
3f075f91d8 feat: activate progress based donation modal (#37882) 2019-12-09 22:00:24 +05:30
f1ddec3f9b fix(donate): hide legacy tiers (#37853) 2019-12-09 11:38:20 +05:30
cb3524ee31 fix: simplify challenge testString (#37826) 2019-12-07 15:47:08 -05:00
623c08cbfa fix: removed semi-colon from regex (#37881) 2019-12-07 15:02:42 -05:00
ccbc9cc6b6 forum link fixed (#37260) 2019-12-07 06:47:48 -08:00
d40be9cbf2 fix: use util.inspect for more reliable logging (#37880)
The tests are probably overkill, but this way we will know if
util.inspect changes dramatically.
2019-12-06 08:37:10 -08:00
450ac77e6a docs: Docker Toolbox for Windows 10 Home (#37873) 2019-12-06 19:05:13 +05:30
daf3a53e55 fix: optimize donation for mobile (#37803) 2019-12-06 10:30:53 +03:00
d7c4fd7fea fix: remove donation prevention (#37867) 2019-12-06 08:43:23 +03:00
7deecf8245 docs: add faq about guide articles (#37874) 2019-12-05 22:15:19 +05:30
dc5c0c7f82 Fix minor grammar issue in override-styles-in-subsequent-css.english.md (#37871) 2019-12-04 14:32:55 -08:00