Commit Graph

1399 Commits

Author SHA1 Message Date
ae93726939 Fix Assert messages missing prepended message: 2015-12-02 10:11:06 -08:00
a1e18d381b Merge pull request #4899 from DDaems/Fix/bonfire-where-art-thou
Fix: bonfire-where-are-thou
2015-12-02 08:29:57 -08:00
1147e0f4ea Capatilize 'Q' in jquery (step 13)
#4906
2015-12-02 08:45:57 +01:00
0660d87241 Add a additional test, to make it a bit more difficult to use string comparison to pass the tests.
At the moment the provided code will pass the test:

collection.map(function(obj){
      if(JSON.stringify(obj).includes(JSON.stringify(source).replace(/[{}]/g, ''))) arr.push(obj)
})
2015-12-02 06:20:31 +01:00
2639251cb2 Merge pull request #4861 from justinian336/Add/ES-translation-of-basejumps
Add ES translation of basejumps
2015-12-02 07:49:40 +04:00
80d564b504 Merge pull request #4880 from ltegman/fix/construct-javascript-objects-seed
Fix Construct Javascript Objects Seed
2015-12-01 19:32:58 -08:00
7b88d29c0d Add ES translation of basejumps 2015-12-02 02:20:51 +00:00
260a47531f Merge pull request #4783 from justinian336/Add/ES-translation-of-testing-and-debugging
Add ES translation of Testing and Debugging
2015-12-01 17:05:52 -08:00
53af246867 Fix Construct Javascript Objects Seed 2015-12-01 15:44:09 -08:00
c384fcdffa Merge pull request #4770 from justinian336/Add/ES-translation-of-bootstrap-waypoints
Add ES translation of Bootstrap Waypoints
2015-12-01 15:15:03 -08:00
649a324bf5 Merge pull request #4649 from Oxyrus/patch-1
Add Spanish translation
2015-12-01 15:14:04 -08:00
76edb825d0 Merge pull request #4617 from vtamara/add/ES-basic-javascript
Translation to spanish of basic-javascript.
2015-12-01 15:13:28 -08:00
0d22255e23 Add closing parenthesis to second test code
Fixes #4858
2015-12-01 22:22:06 +00:00
a4edfb2318 Fix WP Manipulate Arrays with Shift Example Code 2015-12-01 10:30:07 -08:00
8ee44021e2 Merge pull request #4818 from ltegman/fix/wp-typeof-tests
Fix Waypoint Typeof Tests
2015-12-01 21:18:20 +04:00
d8fabeabe0 Merge pull request #4846 from gasperno/fix/test-waypoint-image-link
Improve test case for waypoint:Turn an Image into a Link
2015-12-01 21:11:32 +04:00
21165d464c Fix a test and add periods 2015-12-01 15:49:14 +04:00
1b35056150 Improve test case for waypoint:Turn an Image into a Link 2015-12-01 02:06:12 -05:00
f2a2ae5be4 Fix Waypoint Typeof Tests 2015-11-30 12:59:34 -08:00
ad1d4e303c Merge pull request #4815 from erictleung/fix/space-consistency
Add space after `while` statement for consistency
2015-11-30 11:11:02 -08:00
5cedb1833a Add space after while statement for consistency 2015-11-30 11:07:21 -08:00
0fc53e430d Add code tags to the word 'size' in Chunky Monkey 2015-11-30 11:00:26 -08:00
b8955403dc Add ES translation of testing and debugging. Thanks to @JS-Taiyou and @vtamara for the corrections 2015-11-30 14:22:57 +00:00
e92d6f32b8 Removing sentence, Fixes #4791 2015-11-30 19:36:49 +07:00
9d1f942d2a Fix Misleading BF Test Messages 2015-11-29 19:46:44 -08:00
c47adfc37b Keywords are not function calls 2015-11-29 16:28:32 -08:00
9bc504e412 added that this does not work in safari.
added that this does not work in safari in description

added period.
2015-11-29 14:58:35 -05:00
9a6fba7a9c Add ES translation of bootstrap waypoints. Thanks to @vtamara for the revision 2015-11-29 15:26:21 +00:00
7eeae3925f Translation of basic-javascript. Closes #4542. Thanks for corrections to @justinian336 and for checking to @Oxyrus 2015-11-29 08:35:55 -05:00
04f4c87308 Fix Waypoint Add Font Awesome Icons Tests
Closes #4769
2015-11-28 22:57:18 -08:00
a0b724ce26 Merge pull request #4738 from AryanJ-NYC/fix/truncate-a-string-description
Corrected description of Truncate a String bonfire.
2015-11-28 09:42:01 -08:00
bf7c420799 Corrected description of Truncate a String bonfire.
Close #4706
2015-11-28 12:23:23 -05:00
acc797167f Add Spanish translation 2015-11-28 10:33:12 -05:00
444921574d Added a test case to Where do I belong with return value 0
On the chat today I have seen several solutions that cannot return 0 (usually return arr.length instead), and they still pass, as there is no such test case. Here is one, `where([3, 10, 5], 3) === 0`.
2015-11-28 14:37:25 +01:00
4f3ac61778 added alt-text in waypoint seeds after it is taught 2015-11-28 16:07:57 +10:00
8f28e24b59 Fix display of Roman numeral tests 2015-11-27 21:22:54 -08:00
09a59d5b96 Merge pull request #4749 from erictleung/fix/random-number-test-check
Random Whole Numbers - Add test to check for editing of first line of code
2015-11-27 19:24:29 -08:00
3e264eb419 Add test to check for editing of first line of code 2015-11-27 18:29:13 -08:00
6fc5fe0152 Fixes description on bonfire Check for Palindromes
Closes  #4734
2015-11-27 21:03:00 -04:30
7b69f5f648 Fix example code on filter method to avoid confusion 2015-11-26 18:02:37 -08:00
a24e76675a Fixes Math.random() description in waypoint
Fixes the description of Math.random() in Javascript waypoint.

Math.random() generates a random decimal number between 0 and 1.

Closes #4728
2015-11-26 06:03:11 -08:00
764a052624 Merge pull request #4704 from erictleung/fix/decimal-and-hexadecimal-description
Fix description explaining hexadecimal numbers
2015-11-26 01:06:26 -08:00
4683a9cc00 Merge pull request #4726 from erictleung/fix/change-potential-confusion-on-conditionals
Fix example if-else statements with clearer example
2015-11-26 00:09:56 -08:00
23768acc7f Fix example if-else statements with clearer example 2015-11-26 00:04:10 -08:00
73c8ccb633 Add note about how jQuery is zero-indexed for clarification 2015-11-25 20:39:02 -08:00
9b4cd3549d Merge pull request #4724 from SaintPeter/fix/jquery-comments-to-clarify
Fixes "Use Comments to Clarify Code" Ambiguity
2015-11-25 17:31:05 -08:00
a5d26d1716 Fixes comments top of code ambiguity 2015-11-25 17:26:22 -08:00
24822250a7 Merge pull request #4723 from dcsmith926/staging
use of ".map()" should be ".forEach()"
2015-11-25 17:11:18 -08:00
06e406c68c use of ".map()" should be ".forEach()"
In "seed/challenges/json-apis-and-ajax.json", the use of ".map()" in the 5th and 6th challenges doesn't make sense -- we're not creating a new array by modifying each element of the response, and in challenge 4, the learner was told to use ".forEach()". Seeing ".map()" instead for no apparent reason would likely be a source of confusion.
2015-11-25 18:38:19 -05:00
fe83cccdfc Rewrote test goal description for waypoint: Remove an Element using jQuery
Close #4517
2015-11-25 10:57:48 -05:00