26043 Commits

Author SHA1 Message Date
skaparate
f97c847e29
fix(learn): formatting bug preventing tests to pass (#39045)
* implemented object validation

* fix: formatting bug preventing tests to pass

* implemented object validation

* fix: formatting bug preventing tests to pass

* integrated changes again

* added suggested changes

* fix: refine instructions

* fix: revert some bad instructions and change album to albumTitle

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 12:34:12 +01:00
Nicholas Carrigan
763ff1ae83
docs: remove beta statement (#39497) 2020-09-03 14:47:33 +05:30
Aadhar Agarwal
81479ffd40
fix: add tests for metric-imperial-converter (infosec) (#37891)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <2397860h@student.gla.ac.uk>
2020-09-03 14:39:01 +05:30
Shaun Hamilton
223c2dc205
fix: convert async tests to synchronous (#39478)
* fix: convert async tests to sync

* fix: correct formatting changed by prettier
2020-09-02 19:24:22 -05:00
Anonyma
8edca2efc5
fix(curriculum): add instructions to clarify use of model.createMany (#38026)
* Update create-many-records-with-model.create.english.md

The previous instructions were causing confusion:
https://www.freecodecamp.org/forum/t/mongodb-and-mongoose-create-many-records-with-model-create/208546
https://github.com/freeCodeCamp/freeCodeCamp/issues/36447

* Added clearer instructions

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-many-records-with-model.create.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-many-records-with-model.create.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-many-records-with-model.create.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-03 00:01:48 +01:00
Ty Mick
57c7003119
fix(curriculum): fix typography in "Set a Domain and a Range on a Scale" (#39259)
* Change spaced hyphen to em dash

* Update curriculum/challenges/english/04-data-visualization/data-visualization-with-d3/set-a-domain-and-a-range-on-a-scale.english.md

* Update curriculum/challenges/english/04-data-visualization/data-visualization-with-d3/set-a-domain-and-a-range-on-a-scale.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-02 19:33:17 +01:00
g4rry420
9a4ab36fa4
Changed Regex of 3rd textString (#38944)
* changes the regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString 

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Chamged the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* fix: regex tests and instructions

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/import-a-google-font.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: add suggested change

* revert non-english changes

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <2397860h@student.gla.ac.uk>
2020-09-02 11:21:52 -07:00
bhagerty
046137891e
fix(learn): clarify how object names are associated with destructured fields (#39485)
* Clarify how object names are associated with destructured fields

* fix: make description more concise

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-pass-an-object-as-a-functions-parameters.english.md

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-09-02 19:06:27 +01:00
bhagerty
db15a44160
fix(learn): clarify instructions to remove confusion (#39479)
* Clarify instructions to remove confusion

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-02 18:41:59 +01:00
Tom
e48664af2a
fix(learn): font size multiple headings exercise (#39511)
* fix: use regex to capture font-size of h6 element, as minimum font-size of browsers may influence outcome

* fix: add suggested changes

Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>
2020-09-02 18:11:23 +01:00
Tom
9cd4b93601
fix(learn): getter setter instructions (#39512)
* Update use-getters-and-setters-to-control-access-to-an-object.english.md

* fix: revert changes, keep example

Co-authored-by: Daniel Sing <danielsingsong@gmail.com>
2020-09-02 18:07:17 +01:00
Shaun Hamilton
9ed2a554a7
fix(curriculum): changed test to use regex (#38770)
* changed test to use regex

* added width has to be spelt correctly

* added second width assertion

* add case insensitive flag

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: allow compilable CSS to pass

* add allowance of final property without semicolon

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-02 11:59:16 -05:00
Ashlee Crusco
3836ce08e3
fix(learn): add for and id attributes to label and input (#39019)
* add value and id attributes

* revert prettier format changes

* fix whitespace changes

* Revert "fix whitespace changes"

This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.

* fix typo

* fix: conflict I forgot to resolve

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-02 15:19:47 +01:00
Ahmad Abdolsaheb
ce777e43d2
fix: align completion modal buttons (#39509) 2020-09-02 10:38:14 +02:00
Joshua Pelealu
a050de56bb
Fix: Running Test with a comment fails test on Understand The immediately invoked function expression iife (#39347)
* Update Regex to test if it's an IIFE instead of checking for a parenthases at the end.

* Second Test will now pass the test

* Escape One Parenthese

* Update Regex to be more structured

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Missing regex ending literal

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-01 18:48:32 -05:00
Mayank Chauhan
e7718e5c3f
fix(learn): improved tests for validating incrementer function (#39385)
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* fix typo in avoid-mutations-and-side-effects-using-functional-programming.english.md
2020-09-01 08:44:24 -07:00
swyx
705cba67bc
fix: typo "alumini" (#39502)
fix typo "alumini"
2020-09-01 18:49:00 +05:30
Oliver Eyton-Williams
40acb604d2 fix: remove migration seed and unused import 2020-09-01 11:35:44 +05:30
Oliver Eyton-Williams
1ad5f756e0 fix(api): remove redirects from api
They should be handled either by nginx or by the client. Turned out a
lot of code, including the path migration, existed to support them.
Hence the large number of removals
2020-09-01 11:35:44 +05:30
Oliver Eyton-Williams
4a45b5ac1c fix: redirect /challenges/* to /learn/* 2020-09-01 11:35:44 +05:30
Oliver Eyton-Williams
e0407bf020
chore: downgrade husky so it works with guis (#39495) 2020-09-01 11:21:52 +05:30
Ahmad Abdolsaheb
434cf15ad3
fix: update meta (#39500) 2020-08-31 20:41:13 -05:00
Ashraf Nazar
70f1ebd2fc
fix(curriculum): regex to target html elements using jQuery to captur… (#38649)
* fix(curriculum): regex to target html elements using jQuery to capture white spaces

* replace whitespace before test

* fix linting issue with single quotes

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-31 20:24:43 -05:00
CheongJY
a294021d53
fix: remove whitespace before testing (#39420)
* Proposed change to remove whitespace for issue #39370

Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace in between tags(or literally all whitespaces) before comparing it with the no whitespace example

* Update render-state-in-the-user-interface.english.md

* Updated proposed change to remove whitespace 

An update to previously proposed change due to failed test of 'unexpected token \'<\'' was thrown'

* Update curriculum/challenges/english/03-front-end-libraries/react/render-state-in-the-user-interface.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: linting issue

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-01 01:15:22 +01:00
Hassaan Pasha
b0f85de311
fix (curriculum): Adding regex to disregard any whitespaces in the basic-css challenge (#38330)
* fix (curriculum): Adding regex to account for any whitespace that may be added to the code

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-attribute-selectors-to-style-elements.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 15:16:24 -07:00
Pyi Theim Kyaw
faf426bb40
PR ready fix(learn) (#39208) 2020-08-31 15:31:30 -05:00
Beau Carnes
f334734e98
feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
Kristofer Koishigawa
8e3f740127
fix: update take home project links (#39444)
* fix: update take home project links and update mentions of Glitch with Repl.it

* fix: clean up text, fix typos, and remove deploy to Heroku text

* fix: update nightlife coordination app description text

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: update GH link text based on suggestion

* fix: update links to the fCC forum

* fix: update nightlife coordination app url

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: change http to https

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 10:32:22 -07:00
Yasmin Yazdi
cf82a2b33e
fix global flag fail in Regex by resetting last Index (#39457)
* fixing global flag fail by resetting last index. Issue #37890

* fixed syntax error

* making requested changes
2020-08-31 16:59:42 +05:30
Ashraf Nazar
71051fef50
fix(Curriculum): make sure the nested input element in the form is th… (#38480)
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: use backticks to avoid linting error

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-30 22:50:46 -07:00
Ty Mick
474ae28d72
Fix number of noun (#38833)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-08-30 22:15:58 -07:00
Quinn
29ab6c32ec
minor <code> tag fixes (#39046) 2020-08-30 23:12:04 -05:00
Shaun Hamilton
fe3f0b2ac4
fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
Carlos Diaz
e0a062a3e7
Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
tomki1
9c3de2df24
added test to assert h1 is before h2 (#39040) 2020-08-30 22:13:30 -05:00
law27
b88c8ab351
Update use-the-s-tag-to-strikethrough-text.english.md (#38515)
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
2020-08-30 22:08:51 -05:00
Charles Ross
3db5bd7067
Update import-a-google-font.english.md (#38839)
Changed optional plural to possessive.
2020-08-30 22:07:46 -05:00
Ieahleen
ed6246b91a
update description of "Nest an anchor element in a paragraph" as discussed in #38507 (#38524)
* remove parenthesis from description

As discussed in #38507 , I'm removing the phrase in parenthesis

* more succint description

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-30 22:01:40 -05:00
Mrugesh Mohapatra
7e36059d9a
docs: update working on servers 2020-08-30 12:31:24 +05:30
Kristofer Koishigawa
b73156373f
fix: tests for use a retina image challenge (#39133) 2020-08-29 22:09:43 -05:00
Lasse Jørgensen
c6c1a22487
chore: update dependencies (#39475)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-08-27 20:15:18 +05:30
Karuppiah Natarajan
efa4e09efa
fix typo in 'integer' word (#39339)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-26 07:38:43 -07:00
Oliver Eyton-Williams
5e5842871c
docs: add description of new template (#39473) 2020-08-26 17:55:51 +05:30
imgbot[bot]
52cfe54e94
chore: [ImgBot] Optimize images (#39460)
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-08-26 16:25:21 +05:30
Samuel S. Hernandez
e71cf1da10
fixed spelling errors on .spanish.md (#39030)
fixed spelling errors to improve instruction readability
2020-08-25 19:55:38 -07:00
Samuel S. Hernandez
8ae1902c79
Spelling error on 'motores de busqueda' (#39029)
I fixed a spelling error.
2020-08-25 19:53:37 -07:00
Shaun Hamilton
83c6de0144
fix: add backslash to path test for windows paths (#39454)
* fix: add backslash to path test for windows paths

* fix: add posix seperator to path tester

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-25 13:22:03 -07:00
Oliver Eyton-Williams
46e3d75c76
fix(client): select only required props (Login) (#39461) 2020-08-25 22:59:39 +05:30
Oliver Eyton-Williams
6579b502fd
fix(e2e): wait for editor before running tests (#39465) 2020-08-25 22:58:27 +05:30
Aviel212
fb77d48d13
curriculum: add test in React challenge to detect constructor call (#39304)
* fix: resolve #39301

Add a test to check the "MyComponent" constructor's parameters (params) and to check that the super function exists in the constructor.

* docs: describe the test better

* Update curriculum/challenges/english/03-front-end-libraries/react/write-a-react-component-from-scratch.english.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-25 08:41:35 -07:00