Commit Graph

8640 Commits

Author SHA1 Message Date
Kirushna
fdf9f77eb7 Fix for night mode not persisting in pages other than challenges
jq fix

Fix for night mode not persisting in pages other than challenges

Fix for night mode - chat
2016-06-22 16:29:11 +05:30
Stuart Taylor
a24e07105c Merge pull request #9229 from erictleung/fix/improve-escape-character-sequence
Clarify Escape Sequences in Strings challenge
2016-06-19 23:25:13 +01:00
Eric Leung
1c54ab471a Clarify Escape Sequences in Strings challenge
- Add code tags into table
- Rewrite instructions for more applicable coding test
- Add more tests to be more specific on what you need to pass
2016-06-19 14:56:54 -07:00
Jonathan
6b4b470227 Merge pull request #9151 from heldersepu/feature/Animate-#testSuite-to-focus-user-on-errors
Animate #testSuite to focus user on errors
2016-06-18 21:23:15 +01:00
Helder
ce46d1906b Animate #testSuite to focus user on errors
- As soon as the user clicks the button we hide('slow') the div #testSuite
- Then on displayTestResults we show it.

Use fadeOut/fadeIn instead of hide/show

Scroll the div #scroll-locker to the bottom
- Fix for some challenges with long contents on div #scroll-locker

Fix Err: Strings must use singlequote quotes
2016-06-18 16:04:36 -04:00
Jonathan
222077114a Merge pull request #9096 from LindsayBrown81/fix/disambiguate-property-meaning
fix/disambiguate-property-meaning, make JSON valid in basic-javascript.json
2016-06-18 19:28:53 +01:00
LindsayBrown81
3fa86377f8 fix/disambiguate-property-meaning, make JSON valid in basic-javascript.json #9096
Lines 4322-4323: made links HTML tags instead of markdown in the definitions I added for JSON and property.
Line 4324: added booleans and numbers back into the Data Structures and overall reduced number of words used in explanations.
Lines 4338 and 4343: removed quotes from integer value and boolean value because the JSON is valid without them.
Line 4502: specified what part of property the ID number is to reinforce that a property consists of a key (or name) and a value.
Lines 4505-4508: reworded the conditions to be more consistent and comprehensible, changed their order.
Line 4510: retitled Note to Hints and added two more hints.
Line 4543: changed from my first PR's suggestion of var collectionCopy = JSON.stringify(collection) back to var collectionCopy = JSON.parse(JSON.stringify(collection)).
2016-06-18 14:08:14 -04:00
Jonathan
3fe5e79e52 Merge pull request #9217 from arun1595/fix/nest-a-inside-p-tests
Fix test for nest anchor within a paragraph
2016-06-18 15:01:04 +01:00
Arun
e056fcd442 Fix test for nest anchor within a paragraph 2016-06-18 18:00:20 +05:30
Jonathan
b5b3bd5588 Merge pull request #9208 from taylorbryant/patch-1
Improve consistency
2016-06-18 10:06:29 +01:00
Jonathan
ddef92d3f0 Merge pull request #9207 from QuincyLarson/fix/update-about-page-numbers
update campsites challenge copy, amount of nonprofit work done, camper count
2016-06-18 10:06:00 +01:00
Eric Leung
efae92b12c Merge pull request #9212 from arun1595/fix/font-size-challenge
Add tests for change font-size challenge
2016-06-18 00:00:21 -07:00
Arun
d643982585 Add tests for change font-size challenge 2016-06-18 09:29:00 +05:30
Stuart Taylor
1fd9242b87 Merge pull request #9008 from erictleung/fix/remove-unnecessary-authentication
Remove unused authentication methods
2016-06-18 00:32:31 +01:00
Stuart Taylor
22a52b6bdc Merge pull request #9203 from sahilkhurana19/fix/jQuery-challenge-ux
Edited the test cases code to make sure the entire test cases are vis…
2016-06-17 23:59:25 +01:00
Taylor Bryant
981e9b31fc Improve consistency 2016-06-17 16:00:39 -05:00
Quincy Larson
e1dc82e5ee update campsites challenge copy, amount of nonprofit work done, camper count 2016-06-17 14:00:14 -07:00
sahilkhurana02
62b4e28bb9 Edited the test cases code to make sure the entire test cases are visible. 2016-06-18 00:56:41 +05:30
Jonathan
f2ca20d006 Merge pull request #9183 from sahilkhurana19/fix/array-challenge-description
Modified the description to make it a bit more clear.
2016-06-17 19:51:49 +01:00
sahilkhurana02
f347c5fbaf Fixed challenge description.
Modified the description to make it a bit more clear.

Fixed challenge description and moved the example code to its own independent line.
2016-06-17 23:53:00 +05:30
Arun Kumar
25e6d4293b Fix pop arrays challenge tests (#8959)
* Fix tests for pop arrays challenge
* Fix the first test
2016-06-17 17:30:57 +01:00
Stuart Taylor
0a21880b86 Merge pull request #9144 from DealPete/fix/JSON
remove references to JSON.
2016-06-17 16:58:30 +01:00
Jonathan
c1466989c0 Merge pull request #8884 from WillySchu/fix
Clarify description of change text inside an element using jquery
2016-06-17 16:11:11 +01:00
Mrugesh Mohapatra
63eaecf86e Merge pull request #9201 from AryanJ-NYC/fix/file-metadata-demo
Provide working demo for File Metadata Microservice bonfire challenge
2016-06-17 14:46:58 +00:00
Aryan Jabbari
486f8a9dac Provide working demo for File Metadata Microservice API Project 2016-06-17 14:39:32 +00:00
DealPete
2a07c52e78 remove references to JSON.
change 'allows' to 'allow'
2016-06-17 11:03:26 -02:30
Stuart Taylor
396c4b5372 Merge pull request #9098 from DealPete/fix/incorrectOutputChallenge
Fixed 'Write Reusable JavaScript with Functions' head and tail
2016-06-17 13:20:55 +01:00
Jonathan
57bb224aa6 Merge pull request #9174 from sahilkhurana19/fix/golf-code-description
Edited the basic challenge description in order to make the challenge easier t…
2016-06-16 18:21:56 +01:00
Jonathan
b3214f4954 Merge pull request #9179 from luongthomas/fix/adding-palindrome-test
Add Test Case for Check for Palindromes
2016-06-16 18:20:12 +01:00
Jonathan
ad701a8e49 Merge pull request #9076 from robjloranger/fix__using-array-indices
fix for access array data with indices
2016-06-16 17:10:36 +01:00
luongthomas
ac676f1e19 Added Palindrome test for _eye returning true. 2016-06-16 09:03:53 -07:00
sahilkhurana02
c7c2690848 Edited the basic challenge description to make the challenge easier to understand. 2016-06-16 18:06:33 +05:30
Berkeley Martinez
6fdf5c61a7 Merge pull request #9167 from FreeCodeCamp/revert-8894-FIX/Comment-your-JavaScript-Code
Revert "FIX Unfinished Function Declaration in Comments"
2016-06-15 18:54:24 -07:00
Berkeley Martinez
effd86e79f Revert "FIX Unfinished Function Declaration in Comments" 2016-06-15 18:54:10 -07:00
Berkeley Martinez
8737348f90 Merge pull request #9166 from FreeCodeCamp/revert-9084-Fix/Change-the-Font-Size-of-an-Element
Revert "Fix/Change the Font Size of an Element"
2016-06-15 18:53:37 -07:00
Berkeley Martinez
cc6d71cd5a Revert "Fix/Change the Font Size of an Element" 2016-06-15 18:53:25 -07:00
Berkeley Martinez
07930a4cac Merge pull request #9165 from FreeCodeCamp/revert-9086-Fix/Prefilter-JSON
Revert "Fix/Prefilter JSON"
2016-06-15 18:53:12 -07:00
Stuart Taylor
e5f42c39c7 Revert "Fix/Prefilter JSON" 2016-06-16 00:00:37 +01:00
Stuart Taylor
8fd06ec7fb Merge pull request #9086 from Bouncey/Fix/Prefilter-JSON
Fix/Prefilter JSON
2016-06-15 22:42:40 +01:00
Stuart Taylor
ef1581d042 Merge pull request #9084 from Bouncey/Fix/Change-the-Font-Size-of-an-Element
Fix/Change the Font Size of an Element
2016-06-15 22:40:18 +01:00
Stuart Taylor
e0b100a861 Merge pull request #8894 from Bouncey/FIX/Comment-your-JavaScript-Code
FIX/Unfinished Function Declaration in Comments
2016-06-15 22:31:05 +01:00
Jonathan
de1a436558 Merge pull request #9143 from robjloranger/fix/missing-test-basic-js
fix for Appending variables to strings
2016-06-15 20:43:27 +01:00
robjloranger
6df576df6b adjusted test 2016-06-14 16:41:55 -07:00
Eric Leung
cd4bcbb5da Merge pull request #8900 from b2m9/fix/exclude-seven-digit-US-phone-numbers
Fix: exclude 7 digit numbers from US phone challenge
2016-06-14 08:22:19 -07:00
Bob Massarczyk
034a65642c Fix: exclude 7 digit numbers from US phone challenge
- Add assert for 555-5555, expecting false
- Add assert for 5555555, expecting false
- Change RegEx solution to make area code mandatory
- Simplify RegEx matching
- Add test case to catch random, invalid chars
2016-06-14 12:55:06 +00:00
Eric Leung
3d43a1f533 Merge pull request #9077 from alayek/fix/palindrome-language
Update Palindrome instructions
2016-06-13 22:34:28 -07:00
Jonathan
83868f9f59 Merge pull request #8922 from tianz/fix/mdn-links
Fix MDN links
2016-06-13 19:28:52 +01:00
Jonathan
8f8e066866 Merge pull request #9119 from flipsyde606/fix/url-capitalized
Capitalized abbr. URL instead of url
2016-06-13 12:55:25 +01:00
Kirushna
ca8f3ea824 Fixed typo for URL 2016-06-13 15:49:27 +05:30
Eric Leung
fc3cfa50f2 Merge pull request #9075 from atjonathan/fix/buttons
Removed duplicate help button
2016-06-12 16:55:07 -07:00