gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[refactor] Remove unnecessary declarations in command pattern.

Browse Source
This commit is contained in:
ruslanpa 2015-02-10 09:23:59 +02:00
parent 6da9686a50
commit 0fbb4f4003
4 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
command/src/main/java/com/iluwatar/Goblin.java
View File

@ -3,8 +3,8 @@ package com.iluwatar;
public class Goblin extends Target { public class Goblin extends Target {
public Goblin() { public Goblin() {
this.setSize(Size.NORMAL); setSize(Size.NORMAL);
this.setVisibility(Visibility.VISIBLE); setVisibility(Visibility.VISIBLE);
} }
@Override @Override

4
command/src/main/java/com/iluwatar/InvisibilitySpell.java
View File

@ -4,10 +4,6 @@ public class InvisibilitySpell extends Command {
private Target target; private Target target;
public InvisibilitySpell() {
target = null;
}
@Override @Override
public void execute(Target target) { public void execute(Target target) {
target.setVisibility(Visibility.INVISIBLE); target.setVisibility(Visibility.INVISIBLE);

6
command/src/main/java/com/iluwatar/ShrinkSpell.java
View File

@ -3,14 +3,8 @@ package com.iluwatar;
public class ShrinkSpell extends Command { public class ShrinkSpell extends Command {
private Size oldSize; private Size oldSize;
private Target target; private Target target;
public ShrinkSpell() {
oldSize = null;
target = null;
}
@Override @Override
public void execute(Target target) { public void execute(Target target) {
oldSize = target.getSize(); oldSize = target.getSize();

5
command/src/main/java/com/iluwatar/Wizard.java
View File

@ -5,9 +5,8 @@ public class Wizard extends Target {
private Command previousSpell; private Command previousSpell;
public Wizard() { public Wizard() {
this.setSize(Size.NORMAL); setSize(Size.NORMAL);
this.setVisibility(Visibility.VISIBLE); setVisibility(Visibility.VISIBLE);
previousSpell = null;
} }
public void castSpell(Command command, Target target) { public void castSpell(Command command, Target target) {