Reformat rest of the design patterns - Issue #224
This commit is contained in:
@@ -11,9 +11,9 @@ import com.iluwatar.singleton.App;
|
||||
*/
|
||||
public class AppTest {
|
||||
|
||||
@Test
|
||||
public void test() {
|
||||
String[] args = {};
|
||||
App.main(args);
|
||||
}
|
||||
@Test
|
||||
public void test() {
|
||||
String[] args = {};
|
||||
App.main(args);
|
||||
}
|
||||
}
|
||||
|
@@ -12,68 +12,73 @@ import static org.junit.Assert.assertEquals;
|
||||
/**
|
||||
* This class provides several test case that test singleton construction.
|
||||
*
|
||||
* The first proves that multiple calls to the singleton getInstance object are the same when called in the SAME thread.
|
||||
* The second proves that multiple calls to the singleton getInstance object are the same when called in the DIFFERENT thread.
|
||||
* The first proves that multiple calls to the singleton getInstance object are the same when called
|
||||
* in the SAME thread. The second proves that multiple calls to the singleton getInstance object are
|
||||
* the same when called in the DIFFERENT thread.
|
||||
*
|
||||
*/
|
||||
public class LazyLoadedSingletonThreadSafetyTest {
|
||||
|
||||
private static final int NUM_THREADS = 5;
|
||||
private List<ThreadSafeLazyLoadedIvoryTower> threadObjects = Collections.synchronizedList(new ArrayList<>());
|
||||
private static final int NUM_THREADS = 5;
|
||||
private List<ThreadSafeLazyLoadedIvoryTower> threadObjects = Collections
|
||||
.synchronizedList(new ArrayList<>());
|
||||
|
||||
//NullObject class so Callable has to return something
|
||||
private class NullObject{private NullObject(){}}
|
||||
// NullObject class so Callable has to return something
|
||||
private class NullObject {
|
||||
private NullObject() {}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void test_MultipleCallsReturnTheSameObjectInSameThread() {
|
||||
//Create several instances in the same calling thread
|
||||
ThreadSafeLazyLoadedIvoryTower instance1 = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
ThreadSafeLazyLoadedIvoryTower instance2 = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
ThreadSafeLazyLoadedIvoryTower instance3 = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
//now check they are equal
|
||||
assertEquals(instance1, instance1);
|
||||
assertEquals(instance1, instance2);
|
||||
assertEquals(instance2, instance3);
|
||||
assertEquals(instance1, instance3);
|
||||
@Test
|
||||
public void test_MultipleCallsReturnTheSameObjectInSameThread() {
|
||||
// Create several instances in the same calling thread
|
||||
ThreadSafeLazyLoadedIvoryTower instance1 = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
ThreadSafeLazyLoadedIvoryTower instance2 = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
ThreadSafeLazyLoadedIvoryTower instance3 = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
// now check they are equal
|
||||
assertEquals(instance1, instance1);
|
||||
assertEquals(instance1, instance2);
|
||||
assertEquals(instance2, instance3);
|
||||
assertEquals(instance1, instance3);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void test_MultipleCallsReturnTheSameObjectInDifferentThreads()
|
||||
throws InterruptedException, ExecutionException {
|
||||
{// create several threads and inside each callable instantiate the singleton class
|
||||
ExecutorService executorService = Executors.newSingleThreadExecutor();
|
||||
|
||||
List<Callable<NullObject>> threadList = new ArrayList<>();
|
||||
for (int i = 0; i < NUM_THREADS; i++) {
|
||||
threadList.add(new SingletonCreatingThread());
|
||||
}
|
||||
|
||||
ExecutorService service = Executors.newCachedThreadPool();
|
||||
List<Future<NullObject>> results = service.invokeAll(threadList);
|
||||
|
||||
// wait for all of the threads to complete
|
||||
for (Future res : results) {
|
||||
res.get();
|
||||
}
|
||||
|
||||
// tidy up the executor
|
||||
executorService.shutdown();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void test_MultipleCallsReturnTheSameObjectInDifferentThreads() throws InterruptedException, ExecutionException {
|
||||
{//create several threads and inside each callable instantiate the singleton class
|
||||
ExecutorService executorService = Executors.newSingleThreadExecutor();
|
||||
|
||||
List<Callable<NullObject>> threadList = new ArrayList<>();
|
||||
for (int i = 0; i < NUM_THREADS; i++) {
|
||||
threadList.add(new SingletonCreatingThread());
|
||||
}
|
||||
|
||||
ExecutorService service = Executors.newCachedThreadPool();
|
||||
List<Future<NullObject>> results = service.invokeAll(threadList);
|
||||
|
||||
//wait for all of the threads to complete
|
||||
for (Future res : results) {
|
||||
res.get();
|
||||
}
|
||||
|
||||
//tidy up the executor
|
||||
executorService.shutdown();
|
||||
}
|
||||
{//now check the contents that were added to threadObjects by each thread
|
||||
assertEquals(NUM_THREADS, threadObjects.size());
|
||||
assertEquals(threadObjects.get(0), threadObjects.get(1));
|
||||
assertEquals(threadObjects.get(1), threadObjects.get(2));
|
||||
assertEquals(threadObjects.get(2), threadObjects.get(3));
|
||||
assertEquals(threadObjects.get(3), threadObjects.get(4));
|
||||
}
|
||||
{// now check the contents that were added to threadObjects by each thread
|
||||
assertEquals(NUM_THREADS, threadObjects.size());
|
||||
assertEquals(threadObjects.get(0), threadObjects.get(1));
|
||||
assertEquals(threadObjects.get(1), threadObjects.get(2));
|
||||
assertEquals(threadObjects.get(2), threadObjects.get(3));
|
||||
assertEquals(threadObjects.get(3), threadObjects.get(4));
|
||||
}
|
||||
}
|
||||
|
||||
private class SingletonCreatingThread implements Callable<NullObject> {
|
||||
@Override
|
||||
public NullObject call() {
|
||||
//instantiate the thread safety class and add to list to test afterwards
|
||||
ThreadSafeLazyLoadedIvoryTower instance = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
threadObjects.add(instance);
|
||||
return new NullObject();//return null object (cannot return Void)
|
||||
}
|
||||
private class SingletonCreatingThread implements Callable<NullObject> {
|
||||
@Override
|
||||
public NullObject call() {
|
||||
// instantiate the thread safety class and add to list to test afterwards
|
||||
ThreadSafeLazyLoadedIvoryTower instance = ThreadSafeLazyLoadedIvoryTower.getInstance();
|
||||
threadObjects.add(instance);
|
||||
return new NullObject();// return null object (cannot return Void)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user