gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix PMD violations #327

Browse Source
This commit is contained in:
Ilkka Seppala 2015-12-27 21:21:57 +02:00
parent df911baf36
commit 5f033be54f
94 changed files with 92 additions and 319 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
adapter/src/test/java/com/iluwatar/adapter/AdapterPatternTest.java
View File

@ -1,18 +1,13 @@
package com.iluwatar.adapter;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import java.util.HashMap;
import java.util.Map;
import org.junit.Before;
import org.junit.Test;
import com.iluwatar.adapter.BattleFishingBoat;
import com.iluwatar.adapter.BattleShip;
import com.iluwatar.adapter.Captain;
import com.iluwatar.adapter.FishingBoat;
import java.util.HashMap;
import java.util.Map;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
/**
* Test class

2
async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutor.java
View File

@ -102,7 +102,7 @@ public class ThreadAsyncExecutor implements AsyncExecutor {
@Override
public boolean isCompleted() {
return (state > RUNNING);
return state > RUNNING;
}
@Override

14
async-method-invocation/src/test/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutorTest.java
View File

@ -8,19 +8,9 @@ import java.util.Optional;
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutionException;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.junit.Assert.*;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
import static org.mockito.internal.verification.VerificationModeFactory.times;
/**

2
bridge/src/test/java/com/iluwatar/bridge/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.bridge;
import org.junit.Test;
import com.iluwatar.bridge.App;
/**
*
* Application test

2
builder/src/test/java/com/iluwatar/builder/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.builder;
import org.junit.Test;
import com.iluwatar.builder.App;
/**
*
* Application test

2
callback/src/main/java/com/iluwatar/callback/Callback.java
View File

@ -7,5 +7,5 @@ package com.iluwatar.callback;
*/
public interface Callback {
public void call();
void call();
}

2
chain/src/test/java/com/iluwatar/chain/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.chain;
import org.junit.Test;
import com.iluwatar.chain.App;
/**
*
* Application test

2
composite/src/test/java/com/iluwatar/composite/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.composite;
import org.junit.Test;
import com.iluwatar.composite.App;
/**
*
* Application test

2
dao/src/main/java/com/iluwatar/dao/Customer.java
View File

@ -55,7 +55,7 @@ public class Customer {
boolean isEqual = false;
if (this == o) {
isEqual = true;
} else if (o != null && (getClass() == o.getClass())) {
} else if (o != null && getClass() == o.getClass()) {
final Customer customer = (Customer) o;
if (getId() == customer.getId()) {
isEqual = true;

2
decorator/src/test/java/com/iluwatar/decorator/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.decorator;
import org.junit.Test;
import com.iluwatar.decorator.App;
/**
*
* Application test

4
decorator/src/test/java/com/iluwatar/decorator/SmartTrollTest.java
View File

@ -3,9 +3,7 @@ package com.iluwatar.decorator;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.*;
import static org.mockito.internal.verification.VerificationModeFactory.times;
/**

6
decorator/src/test/java/com/iluwatar/decorator/TrollTest.java
View File

@ -4,15 +4,11 @@ import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import java.io.FileDescriptor;
import java.io.FileOutputStream;
import java.io.PrintStream;
import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.*;
import static org.mockito.internal.verification.VerificationModeFactory.times;
/**

2
dependency-injection/src/test/java/com/iluwatar/dependency/injection/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.dependency.injection;
import org.junit.Test;
import com.iluwatar.dependency.injection.App;
/**
*
* Application test

9
dependency-injection/src/test/java/com/iluwatar/dependency/injection/SimpleWizardTest.java
View File

@ -1,15 +1,8 @@
package com.iluwatar.dependency.injection;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import java.io.PrintStream;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/10/15 - 8:26 PM

3
double-checked-locking/src/main/java/com/iluwatar/doublechecked/locking/Item.java
View File

@ -6,7 +6,4 @@ package com.iluwatar.doublechecked.locking;
*
*/
public class Item {
private String name;
private int level;
}

2
double-checked-locking/src/test/java/com/iluwatar/doublechecked/locking/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.doublechecked.locking;
import org.junit.Test;
import com.iluwatar.doublechecked.locking.App;
/**
*
* Application test

5
double-checked-locking/src/test/java/com/iluwatar/doublechecked/locking/InventoryTest.java
View File

@ -14,10 +14,7 @@ import java.util.concurrent.TimeUnit;
import static junit.framework.Assert.assertTrue;
import static junit.framework.TestCase.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/10/15 - 9:34 PM

2
double-dispatch/src/test/java/com/iluwatar/doubledispatch/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.doubledispatch;
import org.junit.Test;
import com.iluwatar.doubledispatch.App;
/**
*
* Application test

5
double-dispatch/src/test/java/com/iluwatar/doubledispatch/CollisionTest.java
View File

@ -7,10 +7,7 @@ import java.io.PrintStream;
import java.util.Objects;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/10/15 - 8:37 PM

2
event-aggregator/src/test/java/com/iluwatar/event/aggregator/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.event.aggregator;
import org.junit.Test;
import com.iluwatar.event.aggregator.App;
/**
*
* Application test

6
event-aggregator/src/test/java/com/iluwatar/event/aggregator/EventEmitterTest.java
View File

@ -7,11 +7,7 @@ import java.util.function.Function;
import java.util.function.Supplier;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 10:58 PM

6
event-aggregator/src/test/java/com/iluwatar/event/aggregator/KingJoffreyTest.java
View File

@ -6,11 +6,7 @@ import org.junit.Test;
import java.io.PrintStream;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 3:04 PM

6
event-aggregator/src/test/java/com/iluwatar/event/aggregator/KingsHandTest.java
View File

@ -3,11 +3,7 @@ package com.iluwatar.event.aggregator;
import org.junit.Test;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 10:57 AM

6
execute-around/src/test/java/com/iluwatar/execute/around/AppTest.java
View File

@ -1,13 +1,11 @@
package com.iluwatar.execute.around;
import java.io.File;
import java.io.IOException;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import com.iluwatar.execute.around.App;
import java.io.File;
import java.io.IOException;
/**
*

1
execute-around/src/test/java/com/iluwatar/execute/around/SimpleFileWriterTest.java
View File

@ -10,7 +10,6 @@ import java.io.IOException;
import java.nio.file.Files;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
/**

2
facade/src/test/java/com/iluwatar/facade/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.facade;
import org.junit.Test;
import com.iluwatar.facade.App;
/**
*
* Application test

4
facade/src/test/java/com/iluwatar/facade/DwarvenGoldmineFacadeTest.java
View File

@ -7,9 +7,7 @@ import org.junit.Test;
import java.io.PrintStream;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.*;
import static org.mockito.internal.verification.VerificationModeFactory.times;
/**

12
fluentinterface/src/main/java/com/iluwatar/fluentinterface/app/App.java
View File

@ -65,7 +65,7 @@ public class App {
List<String> lastTwoOfFirstFourStringMapped =
LazyFluentIterable.from(integerList).filter(positives()).first(4).last(2)
.map(number -> "String[" + String.valueOf(number) + "]").asList();
.map(number -> "String[" + valueOf(number) + "]").asList();
prettyPrint(
"The lazy list contains the last two of the first four positive numbers mapped to Strings: ",
lastTwoOfFirstFourStringMapped);
@ -85,19 +85,19 @@ public class App {
}
private static Predicate<? super Integer> negatives() {
return integer -> (integer < 0);
return integer -> integer < 0;
}
private static Predicate<? super Integer> positives() {
return integer -> (integer > 0);
return integer -> integer > 0;
}
private static <TYPE> void prettyPrint(String prefix, Iterable<TYPE> iterable) {
prettyPrint(", ", prefix, ".", iterable);
prettyPrint(", ", prefix, iterable);
}
private static <TYPE> void prettyPrint(String delimiter, String prefix, String suffix,
Iterable<TYPE> iterable) {
private static <TYPE> void prettyPrint(String delimiter, String prefix,
Iterable<TYPE> iterable) {
StringJoiner joiner = new StringJoiner(delimiter, prefix, ".");
Iterator<TYPE> iterator = iterable.iterator();
while (iterator.hasNext()) {

20
fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java
View File

@ -53,10 +53,9 @@ public class LazyFluentIterable<TYPE> implements FluentIterable<TYPE> {
public TYPE computeNext() {
while (fromIterator.hasNext()) {
TYPE candidate = fromIterator.next();
if (!predicate.test(candidate)) {
continue;
if (predicate.test(candidate)) {
return candidate;
}
return candidate;
}
return null;
@ -94,12 +93,10 @@ public class LazyFluentIterable<TYPE> implements FluentIterable<TYPE> {
@Override
public TYPE computeNext() {
if (currentIndex < count) {
if (fromIterator.hasNext()) {
TYPE candidate = fromIterator.next();
currentIndex++;
return candidate;
}
if (currentIndex < count && fromIterator.hasNext()) {
TYPE candidate = fromIterator.next();
currentIndex++;
return candidate;
}
return null;
}
@ -188,11 +185,12 @@ public class LazyFluentIterable<TYPE> implements FluentIterable<TYPE> {
@Override
public NEW_TYPE computeNext() {
while (oldTypeIterator.hasNext()) {
if (oldTypeIterator.hasNext()) {
TYPE candidate = oldTypeIterator.next();
return function.apply(candidate);
} else {
return null;
}
return null;
}
};
}

2
fluentinterface/src/test/java/com/iluwatar/fluentinterface/app/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.fluentinterface.app;
import org.junit.Test;
import com.iluwatar.fluentinterface.app.App;
public class AppTest {
@Test

16
fluentinterface/src/test/java/com/iluwatar/fluentinterface/fluentiterable/FluentIterableTest.java
View File

@ -2,21 +2,11 @@ package com.iluwatar.fluentinterface.fluentiterable;
import org.junit.Test;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
import java.util.Spliterator;
import java.util.*;
import java.util.function.Consumer;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.junit.Assert.*;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 7:00 PM

4
flux/src/main/java/com/iluwatar/flux/view/View.java
View File

@ -9,7 +9,7 @@ import com.iluwatar.flux.store.Store;
*/
public interface View {
public void storeChanged(Store store);
void storeChanged(Store store);
public void render();
void render();
}

2
flux/src/test/java/com/iluwatar/flux/app/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.flux.app;
import org.junit.Test;
import com.iluwatar.flux.app.App;
/**
*
* Application test

17
flux/src/test/java/com/iluwatar/flux/dispatcher/DispatcherTest.java
View File

@ -1,13 +1,7 @@
package com.iluwatar.flux.dispatcher;
import com.iluwatar.flux.action.Action;
import com.iluwatar.flux.action.ActionType;
import com.iluwatar.flux.action.Content;
import com.iluwatar.flux.action.ContentAction;
import com.iluwatar.flux.action.MenuAction;
import com.iluwatar.flux.action.MenuItem;
import com.iluwatar.flux.action.*;
import com.iluwatar.flux.store.Store;
import org.junit.Before;
import org.junit.Test;
import org.mockito.ArgumentCaptor;
@ -17,13 +11,8 @@ import java.lang.reflect.Field;
import java.util.List;
import java.util.stream.Collectors;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertSame;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.junit.Assert.*;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 8:22 PM

7
flux/src/test/java/com/iluwatar/flux/store/ContentStoreTest.java
View File

@ -5,16 +5,11 @@ import com.iluwatar.flux.action.ContentAction;
import com.iluwatar.flux.action.MenuAction;
import com.iluwatar.flux.action.MenuItem;
import com.iluwatar.flux.view.View;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 10:18 PM

7
flux/src/test/java/com/iluwatar/flux/store/MenuStoreTest.java
View File

@ -5,16 +5,11 @@ import com.iluwatar.flux.action.ContentAction;
import com.iluwatar.flux.action.MenuAction;
import com.iluwatar.flux.action.MenuItem;
import com.iluwatar.flux.view.View;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 10:18 PM

7
flux/src/test/java/com/iluwatar/flux/view/ContentViewTest.java
View File

@ -2,14 +2,9 @@ package com.iluwatar.flux.view;
import com.iluwatar.flux.action.Content;
import com.iluwatar.flux.store.ContentStore;
import org.junit.Test;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 10:31 PM

7
flux/src/test/java/com/iluwatar/flux/view/MenuViewTest.java
View File

@ -5,15 +5,10 @@ import com.iluwatar.flux.action.MenuItem;
import com.iluwatar.flux.dispatcher.Dispatcher;
import com.iluwatar.flux.store.MenuStore;
import com.iluwatar.flux.store.Store;
import org.junit.Test;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 10:31 PM

2
flyweight/src/test/java/com/iluwatar/flyweight/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.flyweight;
import org.junit.Test;
import com.iluwatar.flyweight.App;
/**
*
* Application test

2
front-controller/src/test/java/com/iluwatar/front/controller/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.front.controller;
import org.junit.Test;
import com.iluwatar.front.controller.App;
/**
*
* Application test

9
half-sync-half-async/src/test/java/com/iluwatar/halfsynchalfasync/AsynchronousServiceTest.java
View File

@ -7,14 +7,7 @@ import java.io.IOException;
import java.util.concurrent.LinkedBlockingQueue;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.doThrow;
import static org.mockito.Mockito.inOrder;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/12/15 - 11:15 PM

2
intercepting-filter/src/main/java/com/iluwatar/intercepting/filter/App.java
View File

@ -34,7 +34,7 @@ public class App {
* @param args command line args
*/
public static void main(String[] args) {
FilterManager filterManager = new FilterManager(new Target());
FilterManager filterManager = new FilterManager();
filterManager.addFilter(new NameFilter());
filterManager.addFilter(new ContactFilter());
filterManager.addFilter(new AddressFilter());

5
intercepting-filter/src/main/java/com/iluwatar/intercepting/filter/FilterChain.java
View File

@ -10,13 +10,10 @@ public class FilterChain {
private Filter chain;
private final Target target;
/**
* Constructor
*/
public FilterChain(Target target) {
this.target = target;
public FilterChain() {
}
/**

4
intercepting-filter/src/main/java/com/iluwatar/intercepting/filter/FilterManager.java
View File

@ -10,8 +10,8 @@ public class FilterManager {
private FilterChain filterChain;
public FilterManager(Target target) {
filterChain = new FilterChain(target);
public FilterManager() {
filterChain = new FilterChain();
}
public void addFilter(Filter filter) {

2
intercepting-filter/src/test/java/com/iluwatar/intercepting/filter/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.intercepting.filter;
import org.junit.Test;
import com.iluwatar.intercepting.filter.App;
/**
*
* Application test.

10
intercepting-filter/src/test/java/com/iluwatar/intercepting/filter/FilterManagerTest.java
View File

@ -4,11 +4,7 @@ import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/13/15 - 3:01 PM
@ -20,7 +16,7 @@ public class FilterManagerTest {
@Test
public void testFilterRequest() throws Exception {
final Target target = mock(Target.class);
final FilterManager filterManager = new FilterManager(target);
final FilterManager filterManager = new FilterManager();
assertEquals("RUNNING...", filterManager.filterRequest(mock(Order.class)));
verifyZeroInteractions(target);
}
@ -28,7 +24,7 @@ public class FilterManagerTest {
@Test
public void testAddFilter() throws Exception {
final Target target = mock(Target.class);
final FilterManager filterManager = new FilterManager(target);
final FilterManager filterManager = new FilterManager();
verifyZeroInteractions(target);

2
interpreter/src/test/java/com/iluwatar/interpreter/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.interpreter;
import org.junit.Test;
import com.iluwatar.interpreter.App;
/**
*
* Application test

2
iterator/src/test/java/com/iluwatar/iterator/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.iterator;
import org.junit.Test;
import com.iluwatar.iterator.App;
/**
*
* Application test

2
layers/src/test/java/com/iluwatar/layers/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.layers;
import org.junit.Test;
import com.iluwatar.layers.App;
/**
*
* Application test

6
layers/src/test/java/com/iluwatar/layers/CakeViewImplTest.java
View File

@ -5,11 +5,7 @@ import org.junit.Test;
import java.util.ArrayList;
import java.util.List;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/15/15 - 10:04 PM

2
lazy-loading/src/test/java/com/iluwatar/lazy/loading/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.lazy.loading;
import org.junit.Test;
import com.iluwatar.lazy.loading.App;
/**
*
* Application test

2
mediator/src/test/java/com/iluwatar/mediator/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.mediator;
import org.junit.Test;
import com.iluwatar.mediator.App;
/**
*
* Application test

5
mediator/src/test/java/com/iluwatar/mediator/PartyMemberTest.java
View File

@ -12,10 +12,7 @@ import java.util.Collection;
import java.util.function.Supplier;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.*;
/**
* Date: 12/19/15 - 10:13 PM

2
memento/src/test/java/com/iluwatar/memento/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.memento;
import org.junit.Test;
import com.iluwatar.memento.App;
/**
*
* Application test

2
model-view-controller/src/test/java/com/iluwatar/model/view/controller/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.model.view.controller;
import org.junit.Test;
import com.iluwatar.model.view.controller.App;
/**
*
* Application test

18
model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileSelectorView.java
View File

@ -9,53 +9,53 @@ public interface FileSelectorView {
/**
* Opens the view.
*/
public void open();
void open();
/**
* Closes the view.
*/
public void close();
void close();
/**
* @return True, if the view is opened, false otherwise.
*/
public boolean isOpened();
boolean isOpened();
/**
* Sets the presenter component, to the one given as parameter.
*
* @param presenter The new presenter component.
*/
public void setPresenter(FileSelectorPresenter presenter);
void setPresenter(FileSelectorPresenter presenter);
/**
* @return The presenter Component.
*/
public FileSelectorPresenter getPresenter();
FileSelectorPresenter getPresenter();
/**
* Sets the file's name, to the value given as parameter.
*
* @param name The new name of the file.
*/
public void setFileName(String name);
void setFileName(String name);
/**
* @return The name of the file.
*/
public String getFileName();
String getFileName();
/**
* Displays a message to the users.
*
* @param message The message to be displayed.
*/
public void showMessage(String message);
void showMessage(String message);
/**
* Displays the data to the view.
*
* @param data The data to be written.
*/
public void displayData(String data);
void displayData(String data);
}

5
model-view-presenter/src/test/java/com/iluwatar/model/view/presenter/FileLoaderTest.java
View File

@ -2,10 +2,7 @@ package com.iluwatar.model.view.presenter;
import org.junit.Test;
import java.io.FileNotFoundException;
import java.io.IOException;
import static org.junit.Assert.*;
import static org.junit.Assert.assertNull;
/**
* Date: 12/21/15 - 12:12 PM

1
monostate/src/test/java/com/iluwatar/monostate/AppTest.java
View File

@ -1,6 +1,5 @@
package com.iluwatar.monostate;
import org.junit.Assert;
import org.junit.Test;
public class AppTest {

8
monostate/src/test/java/com/iluwatar/monostate/LoadBalancerTest.java
View File

@ -4,13 +4,7 @@ import org.junit.Assert;
import org.junit.Test;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/21/15 - 12:26 PM

2
multiton/src/test/java/com/iluwatar/multiton/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.multiton;
import org.junit.Test;
import com.iluwatar.multiton.App;
/**
*
* Application test

2
null-object/src/test/java/com/iluwatar/nullobject/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.nullobject;
import org.junit.Test;
import com.iluwatar.nullobject.App;
/**
*
* Application test

2
object-pool/src/test/java/com/iluwatar/object/pool/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.object.pool;
import org.junit.Test;
import com.iluwatar.object.pool.App;
/**
*
* Application test

2
observer/src/test/java/com/iluwatar/observer/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.observer;
import org.junit.Test;
import com.iluwatar.observer.App;
/**
*
* Application test

12
poison-pill/src/main/java/com/iluwatar/poison/pill/Message.java
View File

@ -8,7 +8,7 @@ import java.util.Map;
*/
public interface Message {
public static final Message POISON_PILL = new Message() {
Message POISON_PILL = new Message() {
@Override
public void addHeader(Headers header, String value) {
@ -45,13 +45,13 @@ public interface Message {
DATE, SENDER
}
public void addHeader(Headers header, String value);
void addHeader(Headers header, String value);
public String getHeader(Headers header);
String getHeader(Headers header);
public Map<Headers, String> getHeaders();
Map<Headers, String> getHeaders();
public void setBody(String body);
void setBody(String body);
public String getBody();
String getBody();
}

2
poison-pill/src/main/java/com/iluwatar/poison/pill/MqPublishPoint.java
View File

@ -5,5 +5,5 @@ package com.iluwatar.poison.pill;
*/
public interface MqPublishPoint {
public void put(Message msg) throws InterruptedException;
void put(Message msg) throws InterruptedException;
}

2
poison-pill/src/main/java/com/iluwatar/poison/pill/MqSubscribePoint.java
View File

@ -5,5 +5,5 @@ package com.iluwatar.poison.pill;
*/
public interface MqSubscribePoint {
public Message take() throws InterruptedException;
Message take() throws InterruptedException;
}

2
poison-pill/src/test/java/com/iluwatar/poison/pill/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.poison.pill;
import org.junit.Test;
import com.iluwatar.poison.pill.App;
/**
*
* Application test

2
private-class-data/src/test/java/com/iluwatar/privateclassdata/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.privateclassdata;
import org.junit.Test;
import com.iluwatar.privateclassdata.App;
/**
*
* Application test

2
producer-consumer/src/test/java/com/iluwatar/producer/consumer/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.producer.consumer;
import org.junit.Test;
import com.iluwatar.producer.consumer.App;
/**
*
* Application test

8
property/src/main/java/com/iluwatar/property/Prototype.java
View File

@ -5,11 +5,11 @@ package com.iluwatar.property;
*/
public interface Prototype {
public Integer get(Stats stat);
Integer get(Stats stat);
public boolean has(Stats stat);
boolean has(Stats stat);
public void set(Stats stat, Integer val);
void set(Stats stat, Integer val);
public void remove(Stats stat);
void remove(Stats stat);
}

2
property/src/test/java/com/iluwatar/property/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.property;
import org.junit.Test;
import com.iluwatar.property.App;
/**
*
* Application test

4
prototype/src/main/java/com/iluwatar/prototype/ElfBeast.java
View File

@ -9,11 +9,9 @@ public class ElfBeast extends Beast {
public ElfBeast() {}
public ElfBeast(ElfBeast beast) {}
@Override
public Beast clone() throws CloneNotSupportedException {
return new ElfBeast(this);
return new ElfBeast();
}
@Override

4
prototype/src/main/java/com/iluwatar/prototype/ElfMage.java
View File

@ -9,11 +9,9 @@ public class ElfMage extends Mage {
public ElfMage() {}
public ElfMage(ElfMage mage) {}
@Override
public Mage clone() throws CloneNotSupportedException {
return new ElfMage(this);
return new ElfMage();
}
@Override

4
prototype/src/main/java/com/iluwatar/prototype/ElfWarlord.java
View File

@ -9,11 +9,9 @@ public class ElfWarlord extends Warlord {
public ElfWarlord() {}
public ElfWarlord(ElfWarlord warlord) {}
@Override
public Warlord clone() throws CloneNotSupportedException {
return new ElfWarlord(this);
return new ElfWarlord();
}
@Override

4
prototype/src/main/java/com/iluwatar/prototype/OrcBeast.java
View File

@ -9,11 +9,9 @@ public class OrcBeast extends Beast {
public OrcBeast() {}
public OrcBeast(OrcBeast beast) {}
@Override
public Beast clone() throws CloneNotSupportedException {
return new OrcBeast(this);
return new OrcBeast();
}
@Override

4
prototype/src/main/java/com/iluwatar/prototype/OrcMage.java
View File

@ -9,11 +9,9 @@ public class OrcMage extends Mage {
public OrcMage() {}
public OrcMage(OrcMage mage) {}
@Override
public Mage clone() throws CloneNotSupportedException {
return new OrcMage(this);
return new OrcMage();
}
@Override

4
prototype/src/main/java/com/iluwatar/prototype/OrcWarlord.java
View File

@ -9,11 +9,9 @@ public class OrcWarlord extends Warlord {
public OrcWarlord() {}
public OrcWarlord(OrcWarlord warlord) {}
@Override
public Warlord clone() throws CloneNotSupportedException {
return new OrcWarlord(this);
return new OrcWarlord();
}
@Override

2
prototype/src/test/java/com/iluwatar/prototype/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.prototype;
import org.junit.Test;
import com.iluwatar.prototype.App;
/**
*
* Application test

2
proxy/src/test/java/com/iluwatar/proxy/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.proxy;
import org.junit.Test;
import com.iluwatar.proxy.App;
/**
*
* Application test

2
repository/src/main/java/com/iluwatar/repository/PersonRepository.java
View File

@ -13,5 +13,5 @@ import org.springframework.stereotype.Repository;
public interface PersonRepository
extends CrudRepository<Person, Long>, JpaSpecificationExecutor<Person> {
public Person findByName(String name);
Person findByName(String name);
}

2
resource-acquisition-is-initialization/src/test/java/com/iluwatar/resource/acquisition/is/initialization/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.resource.acquisition.is.initialization;
import org.junit.Test;
import com.iluwatar.resource.acquisition.is.initialization.App;
/**
*
* Application test

2
servant/src/main/java/com/iluwatar/servant/Queen.java
View File

@ -29,7 +29,7 @@ public class Queen implements Royalty {
@Override
public void changeMood() {
if (complimentReceived && isFlirty && isDrunk) {
if (complimentReceived && isFlirty && isDrunk && !isHungry) {
isHappy = true;
}
}

2
servant/src/test/java/com/iluwatar/servant/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.servant;
import org.junit.Test;
import com.iluwatar.servant.App;
/**
*
* Application test

2
service-layer/src/test/java/com/iluwatar/servicelayer/app/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.servicelayer.app;
import org.junit.Test;
import com.iluwatar.servicelayer.app.App;
/**
*
* Application test

2
service-locator/src/test/java/com/iluwatar/servicelocator/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.servicelocator;
import org.junit.Test;
import com.iluwatar.servicelocator.App;
/**
*
* Application test

2
singleton/src/test/java/com/iluwatar/singleton/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.singleton;
import org.junit.Test;
import com.iluwatar.singleton.App;
/**
*
* Application test

2
specification/src/test/java/com/iluwatar/specification/app/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.specification.app;
import org.junit.Test;
import com.iluwatar.specification.app.App;
/**
*
* Application test

2
state/src/test/java/com/iluwatar/state/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.state;
import org.junit.Test;
import com.iluwatar.state.App;
/**
*
* Application test

2
strategy/src/test/java/com/iluwatar/strategy/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.strategy;
import org.junit.Test;
import com.iluwatar.strategy.App;
/**
*
* Application test

2
template-method/src/test/java/com/iluwatar/templatemethod/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.templatemethod;
import org.junit.Test;
import com.iluwatar.templatemethod.App;
/**
*
* Application test

1
thread-pool/src/main/java/com/iluwatar/threadpool/App.java
View File

@ -65,6 +65,7 @@ public class App {
// All tasks were executed, now shutdown
executor.shutdown();
while (!executor.isTerminated()) {
Thread.yield();
}
System.out.println("Program finished");
}

2
thread-pool/src/test/java/com/iluwatar/threadpool/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.threadpool;
import org.junit.Test;
import com.iluwatar.threadpool.App;
/**
* Application test
*

6
tolerant-reader/src/test/java/com/iluwatar/tolerantreader/AppTest.java
View File

@ -1,13 +1,11 @@
package com.iluwatar.tolerantreader;
import java.io.File;
import java.io.IOException;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import com.iluwatar.tolerantreader.App;
import java.io.File;
import java.io.IOException;
/**
*

2
visitor/src/test/java/com/iluwatar/visitor/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.visitor;
import org.junit.Test;
import com.iluwatar.visitor.App;
/**
*
* Application test