gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix PMD violations #327

Browse Source
This commit is contained in:
Ilkka Seppala
2015-12-27 21:21:57 +02:00
parent df911baf36
commit 5f033be54f
94 changed files with 92 additions and 319 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
intercepting-filter/src/main/java/com/iluwatar/intercepting/filter/App.java
View File

@ -34,7 +34,7 @@ public class App {
* @param args command line args
*/
public static void main(String[] args) {
FilterManager filterManager = new FilterManager(new Target());
FilterManager filterManager = new FilterManager();
filterManager.addFilter(new NameFilter());
filterManager.addFilter(new ContactFilter());
filterManager.addFilter(new AddressFilter());

5
intercepting-filter/src/main/java/com/iluwatar/intercepting/filter/FilterChain.java
View File

@ -10,13 +10,10 @@ public class FilterChain {
private Filter chain;
private final Target target;
/**
* Constructor
*/
public FilterChain(Target target) {
this.target = target;
public FilterChain() {
}
/**

4
intercepting-filter/src/main/java/com/iluwatar/intercepting/filter/FilterManager.java
View File

@ -10,8 +10,8 @@ public class FilterManager {
private FilterChain filterChain;
public FilterManager(Target target) {
filterChain = new FilterChain(target);
public FilterManager() {
filterChain = new FilterChain();
}
public void addFilter(Filter filter) {

2
intercepting-filter/src/test/java/com/iluwatar/intercepting/filter/AppTest.java
View File

@ -2,8 +2,6 @@ package com.iluwatar.intercepting.filter;
import org.junit.Test;
import com.iluwatar.intercepting.filter.App;
/**
*
* Application test.

10
intercepting-filter/src/test/java/com/iluwatar/intercepting/filter/FilterManagerTest.java
View File

@ -4,11 +4,7 @@ import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.*;
/**
* Date: 12/13/15 - 3:01 PM
@ -20,7 +16,7 @@ public class FilterManagerTest {
@Test
public void testFilterRequest() throws Exception {
final Target target = mock(Target.class);
final FilterManager filterManager = new FilterManager(target);
final FilterManager filterManager = new FilterManager();
assertEquals("RUNNING...", filterManager.filterRequest(mock(Order.class)));
verifyZeroInteractions(target);
}
@ -28,7 +24,7 @@ public class FilterManagerTest {
@Test
public void testAddFilter() throws Exception {
final Target target = mock(Target.class);
final FilterManager filterManager = new FilterManager(target);
final FilterManager filterManager = new FilterManager();
verifyZeroInteractions(target);