gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#970 single logging framework should be enforced (#982)

Browse Source 
* #496 Add pipeline module to parent pom ✨

* #496: Add main application class and test for pipeline

* #496: Checkstyle format and add log messages on pipeline stages 🎨

* #496: Fill readme sections of pipeline ✨

* #496: Javadocs and checkstyle formatting 🎨

* #496: Follow PMD checks and add more explanation as block comment on App.java

* #496: Apply requested PR changes by iluwatar 🎨

* #970: Replace log4j usage on commander pattern to Slf4j API 🎨

* #970: Replace log4j usage on dao pattern to Slf4j API 🎨

* #970: Replace log4j usage on data mapper pattern to Slf4j API 🎨

* #970: Remove log4j dependency on data transfer object pom 🔥

* #970: Replace log4j usage on module pattern to Slf4j API 🎨

* #970: Replace log4j usage on serverless pattern to Slf4j API 🎨

This also removes the aws log4j dependency

* #970: Remove unnecessary gitignore line for log4j.xml 🔥

* #970: Remove remaining remnants of log4j 🔥

* #970: Replace System.out logging with appropriate logging methods 🎨

* #970: Replace System.out method references to Logger::info 🎨
This commit is contained in:
Joshua Jimenez
2019-10-14 04:41:11 +08:00
committed by Ilkka Seppälä
parent 72b174619f
commit cfdfedbd2e
50 changed files with 163 additions and 410 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pipeline/src/main/java/com.iluwatar.pipeline/ConvertToCharArrayHandler.java
View File

@@ -32,12 +32,12 @@ import java.util.Arrays;
*/
class ConvertToCharArrayHandler implements Handler<String, char[]> {
private final Logger logger = LoggerFactory.getLogger(ConvertToCharArrayHandler.class);
private static final Logger LOGGER = LoggerFactory.getLogger(ConvertToCharArrayHandler.class);
@Override
public char[] process(String input) {
char[] characters = input.toCharArray();
logger.info(String.format("Current handler: %s, input is %s of type %s, output is %s, of type %s",
LOGGER.info(String.format("Current handler: %s, input is %s of type %s, output is %s, of type %s",
ConvertToCharArrayHandler.class, input, String.class, Arrays.toString(characters), Character[].class));
return characters;

4
pipeline/src/main/java/com.iluwatar.pipeline/RemoveAlphabetsHandler.java
View File

@@ -30,7 +30,7 @@ import org.slf4j.LoggerFactory;
*/
class RemoveAlphabetsHandler implements Handler<String, String> {
private final Logger logger = LoggerFactory.getLogger(RemoveAlphabetsHandler.class);
private static final Logger LOGGER = LoggerFactory.getLogger(RemoveAlphabetsHandler.class);
@Override
public String process(String input) {
@@ -46,7 +46,7 @@ class RemoveAlphabetsHandler implements Handler<String, String> {
}
String inputWithoutAlphabetsStr = inputWithoutAlphabets.toString();
logger.info(String.format("Current handler: %s, input is %s of type %s, output is %s, of type %s",
LOGGER.info(String.format("Current handler: %s, input is %s of type %s, output is %s, of type %s",
RemoveAlphabetsHandler.class, input, String.class, inputWithoutAlphabetsStr, String.class));
return inputWithoutAlphabetsStr;

4
pipeline/src/main/java/com.iluwatar.pipeline/RemoveDigitsHandler.java
View File

@@ -30,7 +30,7 @@ import org.slf4j.LoggerFactory;
*/
class RemoveDigitsHandler implements Handler<String, String> {
private final Logger logger = LoggerFactory.getLogger(RemoveDigitsHandler.class);
private static final Logger LOGGER = LoggerFactory.getLogger(RemoveDigitsHandler.class);
@Override
public String process(String input) {
@@ -46,7 +46,7 @@ class RemoveDigitsHandler implements Handler<String, String> {
}
String inputWithoutDigitsStr = inputWithoutDigits.toString();
logger.info(String.format("Current handler: %s, input is %s of type %s, output is %s, of type %s",
LOGGER.info(String.format("Current handler: %s, input is %s of type %s, output is %s, of type %s",
RemoveDigitsHandler.class, input, String.class, inputWithoutDigitsStr, String.class));
return inputWithoutDigitsStr;