Simran Keshri
5a644f1092
refactoring: Critical Sonar Issues ( #1833 )
...
* Resolve Sonar Code Smell: Define a constant instead of duplicating this literal 'Space rocket <' 4 times.
* Resolve Sonar Critical Code Smell: Define a constant instead of duplicating this literal 'Error connecting to MongoDB' 4 times.
* Fix checkstyle violation.
* Resolve Sonar Critical Code Smell: Define a constant instead of duplicating this literal 'LITERAL 0' 4 times.
Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
2021-10-13 13:15:22 +05:30
Nagaraj Tantri
be25c0b433
bug-fix: Use Junit5 in the serverless module tests ( #1794 )
...
* #1667 : Fixing the serverless tests to use Junit5 and also modifying other classes to remove the deprecated initMock() method
* #1667 : Fixing the sonar code smells
Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
2021-09-29 00:09:19 +05:30
Ilkka Seppälä
7e91322a43
Add explanation to Async Method Invocation pattern ( #1680 )
...
* #590 make the example more interesting and add an explanation
* #590 fix checkstyle
Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
2021-03-18 11:07:34 +05:30
va1m
5cf2fe009b
📍 Use lombok, reformat, and optimize the code ( #1560 )
...
* Use lombok, reformat, and optimize the code
* Fix merge conflicts and some sonar issues
Co-authored-by: va1m <va1m@email.com>
2021-03-13 14:19:21 +02:00
Subhrodip Mohanta
7891c2b117
update inception year to 2021 ( #1653 )
2021-02-14 11:57:57 +02:00
Toxic Dreamz
31471acb69
Fixed most reported issues by SonarCloud.
2020-08-15 21:47:39 +04:00
Ilkka Seppälä
417f21ed3d
Code cleanup ( #1461 )
...
* Code cleanup
* Fix flux tests
* Fix checkstyle errors
* Fix compile error
2020-07-30 20:28:47 +03:00
Anurag Agarwal
c4418311c6
Java 11 migration: ambassador async-method-invocation balking bridge builder ( #1076 )
...
* Moves ambassador pattern to java 11
* Moves async-method-invocation pattern to java 11
* Moves balking pattern to java 11
* Moves bridge pattern to java 11
* Moves builder pattern to java 11
2019-11-11 21:47:09 +02:00
Anurag Agarwal
6d1c0b1563
Resolves checkstyle errors for ambassador, async-method-invocation, balking, bridge, builder ( #1058 )
...
* Decreases checkstyle errors for ambassador pattern
* Reduces checkstyle errors in async-method-invocation
* Reduces checkstyle errors in balking
* Reduces checkstyle errors in bridge
* Reduces checkstyle errors in builder
2019-11-09 21:03:22 +02:00
Alexander Ivanov
4904d7eea0
#1021 : Fix checkstyle warnings by changing the license header template ( #1027 )
...
* Add custom license header style in order to comply with Google's Checkstyle format
* Update license headers to comply with Google's Checkstyle format
2019-10-22 08:15:35 +03:00
Ilkka Seppälä
9ebbc421dd
Update license headers
2019-10-12 20:05:54 +03:00
Artur Mogozov
6694d742a3
Migrate to JUnit5
2017-12-31 16:29:48 +09:00
mahendran.mookkiah
2a7feba427
#587 SonarQube reports bugs
...
As recommended in
https://sonarcloud.io/organizations/default/rules#rule_key=squid%3AS2274
Used while insteadof if - for waiting upon a condition.
2017-08-18 14:18:43 -04:00
Mudit Porwal
09585c3874
Removed AvoidStarImport Rule
...
Added JavaDocType Rule
2017-03-22 01:16:02 +08:00
Ilkka Seppälä
faa29f8025
Update license headers
2016-11-27 14:34:20 +02:00
daniel-bryla
0a427710bb
Merge branch 'master' of https://github.com/iluwatar/java-design-patterns
...
* 'master' of https://github.com/iluwatar/java-design-patterns: (27 commits)
Remove use of coveralls-maven-plugin (sonarqube.com covers this)
Add SonarQube.com badge
Fix environment variable
Add Travis instructions for SonarQube.com analysis
Adds more criticism to Singleton pattern.
Event Based Asynchronous pattern: Add missing license header and puml diagram
Changed config to non-interactive
Moved config into a separate dir
Unused import removed.
End process logic clause has been corrected.
Caching pattern: Documentation and diagram
Fixes #437 . Adds criticism to Singleton pattern.
Alter JUnit tests to run in lesser time.
Updated version snapshot to 1.14.0
Changes based on review feedback.
Closes #436 . Adds criticism to service locator pattern.
Caching pattern: Implementation of Cache-Aside pattern
Caching pattern: Style fix for null check
Caching pattern: Refactor LRU cache to avoid NPE and unnecessary cache lookup
Caching pattern: Refactor shutdown hook to use method reference
...
2016-11-04 11:51:45 +01:00
daniel-bryla
0438811489
#502 Replaced usages of System.out with logger.
2016-10-23 19:59:03 +02:00
dzmitryh
37b930c3b7
Unused import removed.
2016-10-15 14:29:32 +03:00
dzmitryh
85060784a7
End process logic clause has been corrected.
2016-10-15 14:27:15 +03:00
Joseph McCarthy
3d95696078
#358 Added license to all files using plugin
2016-01-27 22:20:42 +00:00
Ilkka Seppala
8b020837ea
Checkstyle corrections
2015-12-29 21:34:27 +02:00
Ilkka Seppala
5f033be54f
Fix PMD violations #327
2015-12-27 21:21:57 +02:00
Ilkka Seppala
cec9a99410
Adjust checkstyle rules. Make checkstyle fail the build when violations are found. Correct all current checkstyle violations.
2015-12-25 23:49:28 +02:00
Ilkka Seppala
6c1f025d0f
Apply code formatting rules to async-method-invocation example tests
2015-12-06 21:42:06 +02:00
Jeroen Meulemeester
1884df525b
Add proper unit tests for async-method-invocation #293
2015-12-06 13:43:01 +01:00
Ankur Kaushal
16a8c85af6
Reformat Async Method Invocation - Issue #224
2015-11-01 17:33:25 -05:00
Ilkka Seppala
1dc2d8d0c7
#107 JavaDoc improvements
2015-08-18 21:28:23 +03:00
Ilkka Seppala
8d62156683
#107 JavaDoc improvements for Async Method Invocation example
2015-08-18 21:11:39 +03:00
Tapio Rautonen
5cc83b85b4
#68 : Javadocs.
2015-07-22 23:36:59 +03:00
Tapio Rautonen
3e8ef01288
#68 : Implementation of Async Method Invocation pattern
2015-07-22 23:36:59 +03:00