2aa9e78ddd
Minor refactorings and code style changes ( #807 )
...
* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals
* Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments
* Removed unused import from Promise
* Addressed review comments
* Addressed checkstyle issue
2018-10-23 13:45:41 +05:30
25ed7c09c5
Refactored Event Queue ( #806 )
...
* 1) Test cases were not stopping AudioService before ending test case 2) Changed Audio to be a good singleton, previously because of Audio being bad singleton, test cases which were using static methods could have caused intermittent failures. 3) Made some other refactorings as well
* Removed sonar issue and converted Audio to eager singleton for simplicity
* Updated class diagram PNG
2018-10-21 21:15:33 +03:00
922fd62da6
Resolves #643 , test cases failed due to global state in CallsCount ( #803 )
...
* Resolves #643 , test cases failed due to presence of global state in CallsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.
* Updated class diagram png and added UCLS file
2018-10-21 21:14:07 +03:00
9e7a500743
Refactoring changes in Ambassador Pattern ( #805 )
...
* 1) Updated test cases to use Junit Assert method as compared to assert keyword 2) Proper testing of RemoteService using RandomProvider interface. Introduced RandomProvider interface so that randomness can be controlled from test cases. 3) For readability used constant for representing FAILURE
* Addressing review comments, Deleting unintentional file and used FAILURE constant in ClientTest as well
2018-10-21 21:12:03 +03:00
21a149ee77
Merge pull request #801 from iluwatar/HexagonalRefactoring
...
Minor refactorings in Hexagonal architecture
2018-10-21 09:54:28 +03:00
f5eaf06c1c
Merge pull request #802 from iluwatar/Issue#699
...
Resolves #699 Intermittent failure was due to Thread.sleep in the code
2018-10-21 09:25:06 +03:00
3c6fb0c53b
Merge pull request #800 from trumvekhuya/master
...
Fix small points in Strategy and Decorator pattern.
2018-10-21 08:46:24 +03:00
829df031c3
Intermittent failure was due to Thread.sleep in the code. While performing unit test cases there was race condition between two threads, so it was not guaranteed to work every time. Used an interface DelayProvider for simulating delay, and while unit testing fake delay provider is used that eradicates the use of Threads in unit test cases, which is not a good practice.
2018-10-15 16:36:27 +05:30
37ae182630
Resolved PMD issues
2018-10-15 13:30:20 +05:30
ab2c12e734
1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5
2018-10-15 13:21:00 +05:30
b3f0cc7e00
- Assign ClubberTroll to another variable in README
2018-10-15 11:52:56 +07:00
86e9c66ca5
- Assign new clubberTroll instance to another variable.
...
- Remove redundant Exception from throws list in unit tests.
2018-10-15 11:41:14 +07:00
a6e6c22bf6
Remove redundant Exception from throws list in DragonSlayerTest
2018-10-15 10:44:14 +07:00
db33cc533b
Remove CII best practices badge
2018-10-13 18:40:10 +03:00
8433c7b712
Merge pull request #793 from andrievsky/master
...
Fix redundant list alloc in LotteryNumbers
2018-10-13 18:28:40 +03:00
ee74fec53c
Fix pattern title
2018-09-30 21:36:32 +03:00
7a7e891384
Set version for next development iteration
2018-09-30 21:05:57 +03:00
26d6d96f78
Reach milestone 1.20.0
2018-09-30 21:03:48 +03:00
3cec7a9ec1
Merge pull request #796 from LyndonArmitage/module-ignore-test-output
...
Delete & Ignore output.txt & error.txt
2018-09-25 22:49:25 +03:00
b079aec1fd
Merge pull request #794 from iluwatar/Issue781
...
#781 Resolved ClasscastException from Acyclic Visitor
2018-09-25 22:45:25 +03:00
8f53df91b9
Delete & Ignore output.txt & error.txt
...
Both output.txt and error.txt are produced by tests.
Each file contained a header that was overridden upon executing said
tests causing tracked files to be changed.
Added them to a local .gitignore file for this module.
2018-09-24 10:08:02 +01:00
709405d964
Resolved checkstyle issues
2018-09-11 16:11:59 +05:30
f3749a2b9d
Solved the classcast exception and used instanceof instead. Improved javadocs a bit.
2018-09-11 15:58:14 +05:30
1d12d94bac
Fix redundant list alloc in LotteryNumbers
2018-09-11 11:55:53 +02:00
9e56e5cbc1
Merge pull request #791 from er2/executeAroundLambda
...
Execute Around - use lambda
2018-09-09 00:24:42 +05:30
1698b066f3
Merge pull request #767 from nikhilbarar/collection-pipeline
...
#564 : Collection Pipeline pattern
2018-09-09 00:21:45 +05:30
4ed039d807
Updated UCLS file and PNG image
2018-09-08 20:38:04 +05:30
ec6d2a8ebe
execute around lambda
2018-09-07 22:29:51 -04:00
98c3f93e82
Review changes in Test Cases
2018-09-04 20:52:11 +05:30
26fbbed62e
Typo in Readme
2018-09-01 15:48:36 +05:30
0f9089dd62
Typo in Readme
2018-09-01 15:48:07 +05:30
038befea26
Merge pull request #779 from mitchellirvin/bst-iterator
...
#778 : Binary Search Tree Iterator
2018-08-30 12:46:13 +05:30
9daa3140e4
Category Enum for category of Car
2018-08-29 22:02:17 +05:30
8458e426bc
correcting raw types for the item Iterator.
2018-08-29 07:36:52 -04:00
e6f84f2f41
modified return type of TreasureChestItemIterator's constructor to be Iterator
2018-08-28 07:46:02 -04:00
74f3799eb4
Merge pull request #788 from diffblue-assistant/finallyclosetotrywithresources
...
Use try-with-resources
2018-08-28 13:17:16 +05:30
b23d8430af
Added Missing class
2018-08-26 23:31:03 +05:30
cb6b0b3600
Checkstyle Fixes
2018-08-26 23:21:25 +05:30
cd44ef3c81
Review Changes
2018-08-26 23:12:33 +05:30
1c2ddfad54
Refactored App.java to remove duplicate code and elegantly demonstrate each implementation of the Iterator interface. Removed the redundant ItemIterator interface. Added insert() method to TreeNode class to allow for more elegant construction of BSTs.
2018-08-25 18:49:43 -04:00
f36de036f6
Use try-with-resources
...
Replace try statements that close a resource in the finally block with a
try-with-resources statement [1].
This commit was created automatically by Diffblue refactorings (https://www.diffblue.com/ ).
[1] https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
2018-08-23 13:44:55 +01:00
b64262303a
Merge pull request #787 from bordoisila1/checkstyle-minor-updates
...
Fixed minor changes suggested by Checkstyle
2018-08-21 11:20:16 +05:30
9d012772fd
Merge pull request #785 from sgyyz/fix-image-name
...
Fix converter image Display Issue
2018-08-21 11:12:40 +05:30
e1a2f141c5
Fixed minor changes suggested by Checkstyle
2018-08-20 22:36:58 -04:00
cce104a271
Fix converter image issue
2018-08-20 21:14:16 +08:00
16df157181
Add license headers
2018-08-13 08:13:06 +03:00
c34004bea5
Merge pull request #763 from 7agustibm/master
...
First proposal for #586 Hexagonal Architecture primary ports should have interfaces
2018-08-10 22:42:09 +03:00
3e0cfa5684
#778 Implemented BSTIterator. Included comprehensive unit and integration tests. Refactored file structure to be friendly to future contributors with iterators of more data structures. Added JUnitPlatform to enable running test suite across all iterator implementations. Added README to /binarysearchtree to document what it does and how it works.
2018-08-04 21:59:53 -04:00
ce459e8f9f
Merge branch 'master' into collection-pipeline
...
# Conflicts:
# pom.xml
2018-08-02 02:43:47 +05:30
535431fac1
Merge branch 'master' of https://github.com/iluwatar/java-design-patterns
2018-08-02 02:30:08 +05:30
