gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,230 Commits 254 Branches 19 Tags
Commit Graph

114 Commits

Author SHA1 Message Date
Ilkka Seppälä
9ebbc421dd Update license headers 2019-10-12 20:05:54 +03:00
Per Wramdemark
218ba44dbf Upgrade of maven plugins (#951) 
* Upgrade maven plugins

* Upgrade maven plugins

Some general code cleanup was necessary due to upgrade of PMD and checkstyle.

Also needed to add Junit 4 as a dependency due to Mockito.timout issue found here:
https://github.com/mockito/mockito/issues/152
 2019-10-05 14:23:20 +03:00
Ilkka Seppälä
b874adc296 Set version for next development iteration 2019-09-08 11:01:12 +03:00
Ilkka Seppälä
9bf7a059b8 Java Design Patterns v1.21.0 2019-09-08 10:49:40 +03:00
hoangnam2261
6daaeec5c6 Remove the transitive dependency(junit-jupiter-api) (#916) 2019-07-30 22:46:38 +03:00
Paweł Matejko
4446e74338 Hexagonal pattern fixes (#814) 
* Fixed wrong else condition

* Simplified creating Set of numbers

* Deleted unused imports

* Replaced 'for' loop with 'foreach' one

* Replaced explicit type with diamond

* Removed unnecesary brackets from lambda

* Removed unnecesary contains check before adding element to Set

* Fixed typo and changed non-english constant names
 2018-10-27 16:39:16 +05:30
Narendra Pathai
37ae182630 Resolved PMD issues 2018-10-15 13:30:20 +05:30
Narendra Pathai
ab2c12e734 1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5 2018-10-15 13:21:00 +05:30
Ilkka Seppälä
8433c7b712
Merge pull request #793 from andrievsky/master 
Fix redundant list alloc in LotteryNumbers
 2018-10-13 18:28:40 +03:00
Ilkka Seppälä
7a7e891384 Set version for next development iteration 2018-09-30 21:05:57 +03:00
Ilkka Seppälä
26d6d96f78 Reach milestone 1.20.0 2018-09-30 21:03:48 +03:00
Nick Andrievsky
1d12d94bac Fix redundant list alloc in LotteryNumbers 2018-09-11 11:55:53 +02:00
Ilkka Seppälä
16df157181 Add license headers 2018-08-13 08:13:06 +03:00
Agustí Becerra Milà
b453753790 Fix import not used 2018-07-08 19:38:54 +02:00
Agustí Becerra Milà
d2b900b524 Fix checkstyle & update interface services 2018-07-08 19:25:42 +02:00
Agustí Becerra Milà
ae07423470 First proposal 2018-07-01 16:29:07 +02:00
Ilkka Seppälä
1c0e0cd88b Set version for next development iteration 2018-03-31 10:36:05 +03:00
Ilkka Seppälä
3407392664 Reach milestone 1.19.0 2018-03-31 10:34:25 +03:00
baislsl
991ba320a6 Improve Javadoc 2018-02-19 22:01:14 +08:00
Ilkka Seppälä
dea2316f1f Set version for next development iteration 2018-01-01 16:58:29 +02:00
Ilkka Seppälä
cb38501ea2 Reach milestone 1.18.0 2018-01-01 16:50:05 +02:00
Artur Mogozov
6694d742a3 Migrate to JUnit5 2017-12-31 16:29:48 +09:00
Ilkka Seppälä
bf98299db2 #190 Remove pumlids from readmes 2017-11-28 21:28:53 +02:00
Ilkka Seppälä
b0f9582824 #190 Remove urm plugin 2017-11-28 20:55:52 +02:00
Ilkka Seppälä
0d4a8db114 Set version for next development iteration 2017-09-30 22:30:34 +03:00
Ilkka Seppälä
ba7142ca97 Reach milestone 1.17.0 2017-09-30 22:26:44 +03:00
Ilkka Seppälä
ac721c695c Set version for next development iteration 2017-06-30 20:33:29 +03:00
Ilkka Seppälä
d793160bce Reach milestone 1.16.0 2017-06-30 20:31:31 +03:00
Ilkka Seppälä
073d06c0ae Set version for next development iteration 2017-04-01 17:15:59 +03:00
Ilkka Seppälä
8fea969912 Reached milestone 1.15.0 2017-04-01 17:14:02 +03:00
Ilkka Seppälä
3f272bf291 Merge pull request #548 from muditporwal/master 
Checkstyle improvements #539 : Added JavaDocType Rule
 2017-04-01 14:45:52 +03:00
NooBxGockeL
c2a7b902a9 Work on #190: urm/puml updates 
* added pumlid where it was missing and possible
* removed pumlid where it generated a bad image
* regenerated some incorrect puml's
* added 'left to right direction' puml prefix to some diagrams to improve the automatic layouting
 2017-03-25 22:07:10 +01:00
Mudit Porwal
09585c3874 Removed AvoidStarImport Rule 
Added JavaDocType Rule
 2017-03-22 01:16:02 +08:00
Ilkka Seppälä
a1ff55b462 #190 Regenerate puml files 2017-02-11 21:46:56 +02:00
Ilkka Seppälä
9ec0935a1c Merge pull request #532 from leogtzr/master 
Adding initialization-on-demand idiom and noninstantiable class instead of interface constant idiom
 2017-01-23 08:21:07 +02:00
leogtzr
d6fc28e120 Changing code to use interfaces instead of implementations. 2017-01-21 15:47:54 -07:00
Ilkka Seppälä
0c8bb1c22e Set version for next development iteration 2016-12-31 10:24:26 +02:00
Ilkka Seppälä
0c48695fa5 Achieved milestone 1.14.0 2016-12-31 10:23:32 +02:00
Krisztián Nagy
95f2c19780 Sonar bug fixes using Yoda condition in equals expression when comparing String literal with String object. 
Using try-with-resources if we use Scanner to close the underlying stream is a good practice to handle resources.
Minimal refactor.
 2016-12-18 16:08:59 +01:00
Krisztián Nagy
120033b58b Sonar bug fixes using Yoda condition in equals expression when comparing String literal with String object. 
Using try-with-resources if we use Scanner to close the underlying stream is a good practice to handle resources.
Minimal refactor.
 2016-12-18 16:04:13 +01:00
Ilkka Seppälä
faa29f8025 Update license headers 2016-11-27 14:34:20 +02:00
Ilkka Seppälä
89e7f51e99 Merge pull request #519 from iluwatar/presentation 
Add hexagonal architecture presentation
 2016-11-27 13:50:04 +02:00
NooBxGockeL
7d995056ff Update URM Version to 1.4.4 and regenerated all puml files 2016-11-26 12:51:06 +01:00
Ilkka Seppälä
68ec24c62e Merge pull request #515 from dbryla/master 
#502 Added logging framework to repository
 2016-11-18 20:47:17 +02:00
Ilkka Seppälä
1abf5b11c3 Add presentation link to README.md 2016-11-13 11:37:49 +02:00
Ilkka Seppälä
22d973c460 Merge branch 'master' into presentation 2016-11-13 11:34:14 +02:00
Ilkka Seppälä
c850295aab Add new diagram 2016-11-13 11:23:22 +02:00
Ilkka Seppälä
4c24d99414 Work on Hexagonal Architecture presentation 2016-11-12 22:44:08 +02:00
Ilkka Seppälä
e1ae1067db Link Hexagonal Architecture pattern to corresponding blog entry 2016-11-06 12:26:03 +02:00
daniel-bryla
e138163c4f #502 Adjusted tests for logger introduction 2016-11-04 11:47:06 +01:00