Commit Graph

  • 61ef59de02 fix code example containing syntax error (#890) Aravind M 2019-08-11 23:36:27 +05:30
  • ccb257d525 fixed bug #883 (#885) Ranjeet 2019-08-04 19:41:56 +05:30
  • 6daaeec5c6 Remove the transitive dependency(junit-jupiter-api) (#916) hoangnam2261 2019-07-31 02:46:38 +07:00
  • 517c20960d Added one more Credit/Article about the benefits of Repository pattern (#882) Thiago Medeiros 2019-07-29 15:31:42 -03:00
  • 36e80c4e69 fixed failing tests (#860) (#880) S Sethi 2019-07-29 19:27:08 +01:00
  • 3454941dcd Typo coresponding -> corresponding (#879) pierDipi 2019-07-29 20:22:56 +02:00
  • b497d41f61 Modify Observer pattern UML (#877) DRad 2019-07-29 20:21:07 +02:00
  • aaabc8f517 Fix the dependency conflict issue (#872) HelloCoCooo 2019-07-30 02:16:21 +08:00
  • 2757b210ea Best practice when compare enum (#869) hoangnam2261 2019-07-30 01:12:14 +07:00
  • d9a567cf97 Commander pattern #505 (#857) AnaghaSasikumar 2019-07-29 23:39:08 +05:30
  • a113de6a14 Add licenses Ilkka Seppälä 2019-07-28 16:24:14 +03:00
  • f7e22a1cf6 508 : Sonar qube critical Issue Fix (#854) kanwarpreet25 2019-07-28 18:12:03 +05:30
  • c6ecf58687 508 : sonar qube critical issue fixes (#852) kanwarpreet25 2019-07-28 18:09:40 +05:30
  • 17bfc91f45 Change Travis CI build env. to Trusty (#911) ptrax 2019-07-28 06:20:18 -05:00
  • 0c6237c225 Type object pattern #555 (#848) AnaghaSasikumar 2019-07-25 00:38:30 +05:30
  • fedc2d9e47 Minor ReadMe Update (#864) saritchie 2019-04-06 22:41:35 -07:00
  • b6b4602baf 845 : unnecassary return deleted (#856) kanwarpreet25 2019-02-17 02:23:06 +05:30
  • eafe52e17a 756 : faq added (#855) kanwarpreet25 2019-02-15 23:30:21 +05:30
  • 5251ec4a93 removed unnecessary static modifier on enum definition (#853) Lucas Prone 2019-02-15 14:55:23 -03:00
  • 26f1a608ab Update license headers Ilkka Seppälä 2019-02-13 23:14:53 +02:00
  • 7a25c57474 Master worker pattern #799 (#831) AnaghaSasikumar 2019-02-14 02:34:16 +05:30
  • 55c7579983 Fix script blocking (#843) Rodolfo Forte 2019-02-04 07:35:06 +01:00
  • 10cb191533 Retry exponential backoff #775 (#829) AnaghaSasikumar 2019-02-04 11:57:13 +05:30
  • a6749cb63e Spatial partition pattern #562 (#828) AnaghaSasikumar 2018-12-23 03:07:31 +05:30
  • 7b8c9b07ed Fix typo (#832) Edy Cu Tjong 2018-12-17 13:42:54 +07:00
  • 0fa18d91c6 Added real world example of Command pattern Narendra Pathai 2018-12-03 18:58:20 +05:30
  • 53b673d5b0 No Need declare App class as a utility class (#827) hoangnam2261 2018-11-26 00:35:22 +07:00
  • 966c56311c Update Readme.md (#815) Anandhu Gopi 2018-11-04 23:42:04 +05:30
  • 150f72758e Add missing license headers Ilkka Seppälä 2018-11-03 09:13:59 +02:00
  • 4446e74338 Hexagonal pattern fixes (#814) Paweł Matejko 2018-10-27 13:09:16 +02:00
  • 70f6e54353 Fix blocker issues on Sonar #508 (#810) staillebois 2018-10-25 15:13:58 +02:00
  • 1f1fcae513 Refactor Page-object pattern (#812) staillebois 2018-10-24 22:17:46 +02:00
  • 2aa9e78ddd Minor refactorings and code style changes (#807) Narendra Pathai 2018-10-23 13:45:41 +05:30
  • 25ed7c09c5 Refactored Event Queue (#806) Narendra Pathai 2018-10-21 23:45:33 +05:30
  • 922fd62da6 Resolves #643, test cases failed due to global state in CallsCount (#803) Narendra Pathai 2018-10-21 23:44:07 +05:30
  • 9e7a500743 Refactoring changes in Ambassador Pattern (#805) Narendra Pathai 2018-10-21 23:42:03 +05:30
  • 0fad8b9b6c Addressed checkstyle issue MinorRefactorings npathai 2018-10-21 17:20:52 +05:30
  • 10179007e8 Addressed review comments npathai 2018-10-21 17:19:41 +05:30
  • 5a56b922e4 Updated class diagram PNG EventQueueRefactoring npathai 2018-10-21 14:06:08 +05:30
  • 0ed4747a71 Updated class diagram png and added UCLS file Issue#643 npathai 2018-10-21 13:57:32 +05:30
  • 21a149ee77 Merge pull request #801 from iluwatar/HexagonalRefactoring Ilkka Seppälä 2018-10-21 09:54:28 +03:00
  • f5eaf06c1c Merge pull request #802 from iluwatar/Issue#699 Ilkka Seppälä 2018-10-21 09:25:06 +03:00
  • 3c6fb0c53b Merge pull request #800 from trumvekhuya/master Ilkka Seppälä 2018-10-21 08:46:24 +03:00
  • 70b4931ab8 Removed unused import from Promise Narendra Pathai 2018-10-20 18:01:41 +05:30
  • 543eb9a4be Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments Narendra Pathai 2018-10-20 17:50:52 +05:30
  • 2f569d670a Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals Narendra Pathai 2018-10-17 21:11:31 +05:30
  • c0da4b3165 Removed sonar issue and converted Audio to eager singleton for simplicity Narendra Pathai 2018-10-16 12:55:33 +05:30
  • 9bbb4da3d5 1) Test cases were not stopping AudioService before ending test case 2) Changed Audio to be a good singleton, previously because of Audio being bad singleton, test cases which were using static methods could have caused intermittent failures. 3) Made some other refactorings as well Narendra Pathai 2018-10-16 12:15:39 +05:30
  • 339dacc01c Addressing review comments, Deleting unintentional file and used FAILURE constant in ClientTest as well AmbassadorRefactoring Narendra Pathai 2018-10-15 21:16:00 +05:30
  • ac3cdfbf35 1) Updated test cases to use Junit Assert method as compared to assert keyword 2) Proper testing of RemoteService using RandomProvider interface. Introduced RandomProvider interface so that randomness can be controlled from test cases. 3) For readability used constant for representing FAILURE Narendra Pathai 2018-10-15 20:16:04 +05:30
  • ced1dfe937 Resolves #643, test cases failed due to presence of global state in CallsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice. Narendra Pathai 2018-10-15 17:28:11 +05:30
  • 829df031c3 Intermittent failure was due to Thread.sleep in the code. While performing unit test cases there was race condition between two threads, so it was not guaranteed to work every time. Used an interface DelayProvider for simulating delay, and while unit testing fake delay provider is used that eradicates the use of Threads in unit test cases, which is not a good practice. Issue#699 Narendra Pathai 2018-10-15 16:36:27 +05:30
  • 37ae182630 Resolved PMD issues HexagonalRefactoring Narendra Pathai 2018-10-15 13:30:20 +05:30
  • ab2c12e734 1) Refactored LotteryNumbers to use Joiner from guava library to join lottery numbers. 2) Solved potential thread safety issue in LotteryTicketId class, where it was using raw primitive value and incrementing it which is not thread-safe. So used AtomicInteger for brevity 3) assertEquals arguments were in incorrect order at many places, so changed order of those 4) Replaced assertFalse and assertTrue at some places with assertEquals and assertNotEquals for reducing complexity of code 5) Removed public modifiers from test cases, as they are no more needed by JUnit 5 Narendra Pathai 2018-10-15 13:21:00 +05:30
  • b3f0cc7e00 - Assign ClubberTroll to another variable in README hoangNam 2018-10-15 11:52:56 +07:00
  • 86e9c66ca5 - Assign new clubberTroll instance to another variable. - Remove redundant Exception from throws list in unit tests. hoangNam 2018-10-15 11:41:14 +07:00
  • a6e6c22bf6 Remove redundant Exception from throws list in DragonSlayerTest hoangNam 2018-10-15 10:44:14 +07:00
  • db33cc533b Remove CII best practices badge Ilkka Seppälä 2018-10-13 18:40:10 +03:00
  • 8433c7b712 Merge pull request #793 from andrievsky/master Ilkka Seppälä 2018-10-13 18:28:40 +03:00
  • ee74fec53c Fix pattern title Ilkka Seppälä 2018-09-30 21:36:32 +03:00
  • 7a7e891384 Set version for next development iteration Ilkka Seppälä 2018-09-30 21:05:57 +03:00
  • 26d6d96f78 Reach milestone 1.20.0 1.20.0 Ilkka Seppälä 2018-09-30 21:03:48 +03:00
  • 3cec7a9ec1 Merge pull request #796 from LyndonArmitage/module-ignore-test-output Ilkka Seppälä 2018-09-25 22:49:25 +03:00
  • b079aec1fd Merge pull request #794 from iluwatar/Issue781 Ilkka Seppälä 2018-09-25 22:45:25 +03:00
  • 8f53df91b9 Delete & Ignore output.txt & error.txt Lyndon Armitage 2018-09-24 10:08:02 +01:00
  • 709405d964 Resolved checkstyle issues Issue781 Narendra Pathai 2018-09-11 16:11:59 +05:30
  • f3749a2b9d Solved the classcast exception and used instanceof instead. Improved javadocs a bit. Narendra Pathai 2018-09-11 15:58:14 +05:30
  • 1d12d94bac Fix redundant list alloc in LotteryNumbers Nick Andrievsky 2018-09-11 11:55:53 +02:00
  • 9e56e5cbc1 Merge pull request #791 from er2/executeAroundLambda Narendra Pathai 2018-09-09 00:24:42 +05:30
  • 1698b066f3 Merge pull request #767 from nikhilbarar/collection-pipeline Narendra Pathai 2018-09-09 00:21:45 +05:30
  • 4ed039d807 Updated UCLS file and PNG image nikhilbarar 2018-09-08 20:38:04 +05:30
  • ec6d2a8ebe execute around lambda Eric Riese 2018-09-07 22:29:51 -04:00
  • 98c3f93e82 Review changes in Test Cases nikhilbarar 2018-09-04 20:52:11 +05:30
  • 26fbbed62e Typo in Readme nikhilbarar 2018-09-01 15:48:36 +05:30
  • 0f9089dd62 Typo in Readme nikhilbarar 2018-09-01 15:48:07 +05:30
  • 038befea26 Merge pull request #779 from mitchellirvin/bst-iterator Narendra Pathai 2018-08-30 12:46:13 +05:30
  • 9daa3140e4 Category Enum for category of Car nikhilbarar 2018-08-29 22:02:17 +05:30
  • 8458e426bc correcting raw types for the item Iterator. mxi1809 2018-08-29 07:36:52 -04:00
  • e6f84f2f41 modified return type of TreasureChestItemIterator's constructor to be Iterator Mitchell Irvin 2018-08-28 07:46:02 -04:00
  • 74f3799eb4 Merge pull request #788 from diffblue-assistant/finallyclosetotrywithresources Narendra Pathai 2018-08-28 13:17:16 +05:30
  • b23d8430af Added Missing class nikhilbarar 2018-08-26 23:31:03 +05:30
  • cb6b0b3600 Checkstyle Fixes nikhilbarar 2018-08-26 23:21:25 +05:30
  • cd44ef3c81 Review Changes nikhilbarar 2018-08-26 23:12:33 +05:30
  • 1c2ddfad54 Refactored App.java to remove duplicate code and elegantly demonstrate each implementation of the Iterator interface. Removed the redundant ItemIterator interface. Added insert() method to TreeNode class to allow for more elegant construction of BSTs. Mitchell Irvin 2018-08-25 18:49:43 -04:00
  • f36de036f6 Use try-with-resources Diffblue assistant 2018-08-23 11:28:17 +01:00
  • b64262303a Merge pull request #787 from bordoisila1/checkstyle-minor-updates Narendra Pathai 2018-08-21 11:20:16 +05:30
  • 9d012772fd Merge pull request #785 from sgyyz/fix-image-name Narendra Pathai 2018-08-21 11:12:40 +05:30
  • e1a2f141c5 Fixed minor changes suggested by Checkstyle bordoisila1 2018-08-20 22:36:58 -04:00
  • cce104a271 Fix converter image issue Yongzhi Yang 2018-08-20 21:14:16 +08:00
  • 16df157181 Add license headers Ilkka Seppälä 2018-08-13 08:13:06 +03:00
  • c34004bea5 Merge pull request #763 from 7agustibm/master Ilkka Seppälä 2018-08-10 22:42:09 +03:00
  • 3e0cfa5684 #778 Implemented BSTIterator. Included comprehensive unit and integration tests. Refactored file structure to be friendly to future contributors with iterators of more data structures. Added JUnitPlatform to enable running test suite across all iterator implementations. Added README to /binarysearchtree to document what it does and how it works. Mitchell Irvin 2018-08-04 21:59:53 -04:00
  • ce459e8f9f Merge branch 'master' into collection-pipeline nikhilbarar 2018-08-02 02:43:47 +05:30
  • 535431fac1 Merge branch 'master' of https://github.com/iluwatar/java-design-patterns nikhilbarar 2018-08-02 02:30:08 +05:30
  • facb9e51a6 Merge pull request #774 from zenuo/master Ilkka Seppälä 2018-08-01 16:02:23 +03:00
  • 9eb8c30bcb Add Annotation 'Override' to com.iluwatar.reactor.app.AppClient.TcpLoggingClient.run method. zenuo 2018-07-18 17:06:19 +08:00
  • fc87f8b7d3 Merge branch 'master' of https://github.com/iluwatar/java-design-patterns nikhilbarar 2018-07-08 23:09:55 +05:30
  • b453753790 Fix import not used Agustí Becerra Milà 2018-07-08 19:38:54 +02:00
  • d2b900b524 Fix checkstyle & update interface services Agustí Becerra Milà 2018-07-08 19:25:42 +02:00
  • 2c8d1744df #564: Collection Pipeline pattern nikhilbarar 2018-07-02 00:42:04 +05:30