b6700924b2
Fix uninstall causing 403 errors and not removing packages
...
The 403 lighttpd errors were caused by removing the lighttpd config
directory and not removing lighttpd itself. This caused a subsequent
Pi-hole reinstall to not have all of the required lighttpd config files.
The error while removing packages was caused by combining arguments into
a string instead of listing each argument.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-17 16:13:31 -07:00
b505ad22e6
Merge pull request #2806 from pi-hole/fix/fedora-ci-tests
...
Pin the Fedora test docker container to 29
2019-06-16 20:19:44 +02:00
d67122dffc
Pin the Fedora test docker container to 29
...
The tests are currently failing due to a change in Fedora 30, which we
are not currently supporting.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-16 11:13:23 -07:00
f2be12f97b
Merge pull request #2796 from pi-hole/tweak/opendns-ipv6
...
Use the filtered IPv6 OpenDNS servers
2019-06-16 14:56:00 +02:00
67dda9c8bb
Merge pull request #2790 from mmotti/tidy/query
...
Small changes to regexp querying
2019-06-13 20:32:42 -04:00
c8987e20c2
Use the filtered IPv6 OpenDNS servers
...
The ones we were using previously were not filtered. See
https://support.opendns.com/hc/en-us/articles/227986667-Does-OpenDNS-Support-IPv6-
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-12 19:13:29 -07:00
bcf03647ef
Add comment and remove blankspace
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-12 16:02:59 +01:00
a9d0690f4d
Change the case of some variables
...
Just for consistency
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-10 18:50:52 +01:00
10fbed50f3
Shellcheck
...
Suggesting to use parameter expansion but we need to be able to identify the start of each line
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-10 18:10:25 +01:00
785f1fedd9
Tidy regexp queries
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-10 17:52:58 +01:00
b0c5dcf42f
Merge pull request #2780 from mmotti/fix/regexp_query
...
Fix for regexp queries through pihole -q
2019-06-05 13:19:39 -04:00
cf21efa103
Minor grammar changes
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-05 14:36:43 +01:00
7613e94ef6
Minor tweaks
...
Mainly for consistency
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-04 06:06:17 +01:00
b49c702f33
Consistency tweak
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-04 00:03:37 +01:00
09532638d5
Read from DB instead of regex.list
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-04 00:00:25 +01:00
97df6d7415
Stickler fix
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-03 19:56:10 +01:00
54bfaa28c1
Fix for regexp queries through pihole -q
...
Taking inspiration from: https://github.com/pi-hole/pi-hole/pull/2346
We will use awk to iterate through each regexp and print any that match the domain query.
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-03 19:32:59 +01:00
afd28fab03
Merge pull request #2767 from pi-hole/fix/multiple_pihole-FTL_PIDs
...
Improve PID detection in pihole-FTL.service
2019-06-01 01:03:55 -04:00
d92ced6fb6
Merge pull request #2734 from pi-hole/fix/query_black_and_whitelists_database
...
Query black and whitelists database
2019-06-01 00:55:05 -04:00
ae98fde321
Try to obtain PID from PIDFILE. If this fails (file does not exist or is empty), fall back to using pidof + awk
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-31 09:18:12 +02:00
44f8fcb600
We can print the table name without any extra check as we already returned early in case there are no results.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-31 08:39:18 +02:00
814fdcf9b6
Merge pull request #2768 from pi-hole/fix/dhcp-ignore-names
...
Add dhcp-ignore-names option when enabling DHCP service
2019-05-30 22:35:52 -04:00
5060605626
Print table name before entering the loop for the sake of simplicity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 21:44:59 +02:00
453ba14cbd
Merge pull request #2758 from pi-hole/fix/debug-log-gravity-database
...
Update debug script with gravity DB changes
2019-05-30 21:37:49 +02:00
c5df104a66
Add dhcp-ignore-names option when enabling DHCP service. We currently remove anything that starts with "dhcp-" to have a clean configuration and removed these lines without noticing when enabling the DHCP server.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 16:41:37 +02:00
f6213d4f4d
Use last PID in case pidof returns multiple PIDs for pihole-FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 15:26:27 +02:00
ca2ea388b7
Merge pull request #2763 from chrisys/development
...
Handle an empty local.list
2019-05-27 16:06:25 -04:00
69dba022c4
Handle an empty local.list
...
Handle the case of an empty local.list file which would otherwise prevent the system from starting
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io >
2019-05-27 10:27:28 -07:00
bfb99c361c
Note that the gravity size does not include the blacklist entries
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-21 17:12:47 -07:00
5796054305
Increase ID column width to 4
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:59:18 -07:00
a3e1473ac1
Set explicit column widths to prevent text from getting cut off
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:33:09 -07:00
7b5fc60e00
Improve table formatting
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:20:38 -07:00
807ce0af4e
Show whitelist, blacklist, and regexlist details
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:15:22 -07:00
3f05efd60f
Add extra newline
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:02:31 -07:00
03d93aa19a
Update debug script with gravity DB changes
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 20:58:57 -07:00
cad9386ff6
Merge pull request #2750 from pi-hole/release/v4.3
...
Update Dev with v4.3 fixes
2019-05-19 19:42:29 +02:00
7de6bbca61
Merge branch 'development' into release/v4.3
2019-05-18 13:18:14 -07:00
c8d32e0dd3
Merge pull request #2743 from haguenau/fix/shellcheck-install-script
...
Clean up basic install script
2019-05-16 23:22:01 -04:00
be3a21ae07
Put quotes at ends of strings
...
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-05-14 15:20:28 -04:00
69081a9175
Drop indirection from install_dependent_packages
...
Previously, install_dependent_packages would receive an array variable
name as its single parameter, and would use variable indirection to
access it; this change simplifies that function so that it instead
receives the expanded array.
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-05-14 15:20:28 -04:00
ab2f8a0c09
Quote variables in basic-install.sh
...
This greatly reduces the number of warnings emitted by ShellCheck, and
in turn should make it more likely that errors are caught in the
future.
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-05-14 15:20:28 -04:00
b961a501bb
Merge pull request #2611 from pi-hole/new/gravitydb
...
Store blocking domains in a database
2019-05-12 18:46:47 -04:00
8e1bf6e3d4
Merge branch 'development' into new/gravitydb
...
# Conflicts:
# advanced/Scripts/list.sh
# gravity.sh
# pihole
2019-05-12 15:20:52 -07:00
d6756eb46b
Merge pull request #2730 from pvogt09/development
...
Adds world readable attribute to files created by Pi-hole to circumve…
2019-05-12 15:44:20 -04:00
efbd42f7b5
Moves creation of pihole user before FTL installation
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-12 11:27:25 +02:00
3f90261520
Moves chmod after every creation of ${destination} instead of end of function
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-12 11:25:48 +02:00
ff5894d772
Merge pull request #2744 from pi-hole/fix/cron-job-errors-untagged
...
Fix for preventing git error message in cron logs
2019-05-11 22:59:32 -04:00
225285cb97
Removes chmod for ${source} and superfluous chmod for ${destination}
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-11 11:14:07 +02:00
3220e2b978
Fix for preventing git error message in cron logs
...
Fix to prevent "fatal: No names found, cannot describe anything" git message during scheduled update checks
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-11 10:57:44 +02:00
54ae458b61
Merge pull request #2733 from pi-hole/fix/debug-curl
...
Pi-hole Debug - tricorder upload function calls
2019-05-11 10:54:30 +02:00
